[pfx-dev] Re: dict_mongodb

2023-12-06 Thread Peter via Postfix-devel
On 7/12/23 04:53, Wietse Venema via Postfix-devel wrote: (major) there is no code to escape special characters when parts or all of a Postfix query are pasted into the MongoDB query filter. I think that at the very least, quotes and backslashes should be escaped with a backslash. I can add a litt

[pfx-dev] Re: SMTP smuggling

2023-12-20 Thread Peter via Postfix-devel
On 21/12/23 09:20, Herbert J. Skuhra via Postfix-devel wrote: On Wed, Dec 20, 2023 at 09:12:47PM +0100, John D'Orazio via Postfix-devel wrote: Please excuse me if this has been asked before, but I haven't found any information in the archives or on the postfix github repo. I recently encountered

[pfx-dev] Re: [PATCH] fix false positive warning in postfix-script

2024-07-25 Thread Peter via Postfix-devel
On 26/07/24 12:58, Viktor Dukhovni via Postfix-devel wrote: Or, if, as I believe, it is sufficiently portable: root=$(id -nu 0) || exit 1 Indeed this is fully POSIX compliant. find ... -user "$root" ... ...as is this... however, it gives no benefit over the equally POSIX complia

[pfx-dev] Re: [PATCH] fix false positive warning in postfix-script

2024-07-25 Thread Peter via Postfix-devel
On 26/07/24 15:20, Peter via Postfix-devel wrote: ... The only issue with this is that you could potentially have a user named "0", but that would also be an issue with the id command above. Linux systems do not allow usernames that start with a digit (unless you force the issue),

[pfx-dev] Re: [PATCH] fix false positive warning in postfix-script

2024-07-26 Thread Peter via Postfix-devel
On 26/07/24 16:35, wagner riffel via Postfix-devel wrote: Peter via Postfix-devel wrote: Personally my feeling is that if someone is so brain dead as to actually name an unprivileged user "0" they will get what they deserve and so I would personally be fine with just using find .

[pfx-dev] Default (commented) master.cf entries should include multi-instance name where appropriate.

2024-12-11 Thread Peter via Postfix-devel
Currently the stock postfix master.cf file contains these commented lines in the submission and submissions entries respectively: # -o syslog_name=postfix/submission # -o syslog_name=postfix/submissions But the default for syslog_name is this: syslog_name = ${multi_instance_name?{$multi_ins

[pfx-dev] Re: Default (commented) master.cf entries should include multi-instance name where appropriate.

2024-12-11 Thread Peter via Postfix-devel
On 12/12/24 13:12, Wietse Venema via Postfix-devel wrote: syslog_name = ${multi_instance_name?{$multi_instance_name}:{postfix}}/$service_name The main downside here is you'll end up with names such as postfix/smtpd/smtpd but it will at least be consistent. Also we could instead change the defau