Re: [PATCH] A Problem in compat_level_from_string()

2021-06-22 Thread David Bohman
Okay. After I identified the code which was causing the problem, my initial fix was to clear errno before each call to strtol(), and that resolved the problem. I then went in and looked at the code in more detail, as well as read the spec for strtol(). My change will work also, since strtol()

Re: [PATCH] A Problem in compat_level_from_string()

2021-06-22 Thread Viktor Dukhovni
On Tue, Jun 22, 2021 at 10:49:49AM -0700, David Bohman wrote: > You cannot assume that the value returned to 'endptr' is greater than > 'str' on a valid result. It could be a different string entirely, with > a lesser pointer value. That is up to the implementation. Postfix does not pass

Re: [PATCH] A Problem in compat_level_from_string()

2021-06-22 Thread David Bohman
Answers below. On Tue, Jun 22, 2021 at 9:51 AM Wietse Venema wrote: > > David Bohman: > > This is apparently a new routine in version 3.6. > > > > I upgraded from version 3.5.9 directly to 3.6.1 and ran into an issue. > > Postfix failed to start up without any diagnostic output. It took me a bit

Re: [PATCH] A Problem in compat_level_from_string()

2021-06-22 Thread Wietse Venema
David Bohman: > This is apparently a new routine in version 3.6. > > I upgraded from version 3.5.9 directly to 3.6.1 and ran into an issue. > Postfix failed to start up without any diagnostic output. It took me a bit > to narrow down the failure, but I discovered that this routine was failing >