Re: [Potlatch-dev] State of play

2012-03-05 Thread Andy Allan
On 5 March 2012 04:01, Steve Bennett stevag...@gmail.com wrote:

 undo on creating way fix,

 Definitely worthy of review - it's totally possible that I broke
 something else. Anyone else want to have a look at it? I guess we
 don't have any tests?

We don't have any tests that cover starting drawing a new way.

I'd absolutely love to have tests that cover all the Actions though -
it's so important not to mess up the data in some subtle way while
refactoring. After that, we can test whether pressing the buttons
has the desired effects.

There are some very basic Action tests at
https://github.com/systemed/potlatch2/tree/master/tests/src/net/systemeD/halcyon/connection/actions
already, but to say they are very basic is slightly overselling
them! We're also lacking tests on most of the Entity functionality
too.

Cheers,
Andy

___
Potlatch-dev mailing list
Potlatch-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/potlatch-dev


[Potlatch-dev] [OpenStreetMap] #4266: Intransparent areas

2012-03-05 Thread OpenStreetMap
#4266: Intransparent areas
-+--
 Reporter:  _al  |   Owner:  potlatch-dev@… 
   
 Type:  defect   |  Status:  new
   
 Priority:  critical |   Milestone: 
   
Component:  potlatch2| Version: 
   
 Keywords:  area intransparent transparency  |  
-+--
 Areas (eg. cemetery, sports_centre) are shown intransparent which is kind
 of... not a good idea.

-- 
Ticket URL: https://trac.openstreetmap.org/ticket/4266
OpenStreetMap http://www.openstreetmap.org/
OpenStreetMap is a free editable map of the whole world

___
Potlatch-dev mailing list
Potlatch-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/potlatch-dev


[Potlatch-dev] [OpenStreetMap] #4267: Potlatch 2 hangs up after some clicks (with update 04.03.2012)

2012-03-05 Thread OpenStreetMap
#4267: Potlatch 2 hangs up after some clicks (with update 04.03.2012)
---+
 Reporter:  Firefly!   |   Owner:  potlatch-dev@…
 Type:  defect |  Status:  new   
 Priority:  critical   |   Milestone:
Component:  potlatch2  | Version:  2.0   
 Keywords: |  
---+
 With the update of 04/03/2012 sometimes the Potlatch editor will hanging
 up. After some clicks it was not more possible to focus lines and points
 for edit or to draw new things. The other layers (zoom, move display
 range, menues and buttons) than still works.
 This problem came up on two different computers (Windows XP, Firefox in
 different versions, latest flash version).
 It seemed to be reproduceable when you select a line and try to start a
 branch/new way with shift+click while the browser reports transferring
 data from ... But waiting did not help.
 In the past I had this problem also 3 or 4 times after long editing for
 hours. But yesterday and this morning it came after minutes.

-- 
Ticket URL: https://trac.openstreetmap.org/ticket/4267
OpenStreetMap http://www.openstreetmap.org/
OpenStreetMap is a free editable map of the whole world

___
Potlatch-dev mailing list
Potlatch-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/potlatch-dev


Re: [Potlatch-dev] [OpenStreetMap] #4267: Potlatch 2 hangs up after some clicks (with update 04.03.2012)

2012-03-05 Thread OpenStreetMap
#4267: Potlatch 2 hangs up after some clicks (with update 04.03.2012)
---+
 Reporter:  Firefly!   |   Owner:  potlatch-dev@…
 Type:  defect |  Status:  new   
 Priority:  critical   |   Milestone:
Component:  potlatch2  | Version:  2.0   
 Keywords: |  
---+
Changes (by SomeoneElse):

 * cc: SomeoneElse (added)


Comment:

 I had not possible any more to focus lines and points for edit happen to
 me at just before Sun, 04 Mar 2012 11:39:13 +. The sequence of events
 was:

 o In http://www.openstreetmap.org/browse/changeset/10866345 I managed to
 create http://www.openstreetmap.org/browse/way/153170457/history with only
 one node http://www.openstreetmap.org/browse/node/1658878012/history in
 it. I think what happened was that I added the way with two nodes and
 deleted one node, and noticed the way disappear.

 o I then thought I bet that's left the way with just one node in it and
 so saved and closed that changeset.

 o In another changeset
 http://www.openstreetmap.org/browse/changeset/10867262 I deleted the
 remaining node. After doing so I couldn't select other nodes or ways. I
 was however able to save and close the new changeset.

 (just an anecdote, but hopefully it may help)

-- 
Ticket URL: https://trac.openstreetmap.org/ticket/4267#comment:2
OpenStreetMap http://www.openstreetmap.org/
OpenStreetMap is a free editable map of the whole world

___
Potlatch-dev mailing list
Potlatch-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/potlatch-dev


Re: [Potlatch-dev] [OpenStreetMap] #4267: Potlatch 2 hangs up after some clicks (with update 04.03.2012)

2012-03-05 Thread OpenStreetMap
#4267: Potlatch 2 hangs up after some clicks (with update 04.03.2012)
---+
 Reporter:  Firefly!   |   Owner:  potlatch-dev@…
 Type:  defect |  Status:  new   
 Priority:  critical   |   Milestone:
Component:  potlatch2  | Version:  2.0   
 Keywords: |  
---+

Comment(by SomeoneElse):

 Replying to [comment:2 SomeoneElse]:
  I had not possible any more to focus lines and points for edit happen
 to me at just before Sun, 04 Mar 2012 11:39:13 +. The sequence of
 events was:

 According to http://www.adobe.com/software/flash/about/
 I (SomeoneElse, not the bug reporter) have version 11,1,102,62 installed.
 It's Windows 7 64-bit, FF 3.6.27 32-bit FWIW.

-- 
Ticket URL: https://trac.openstreetmap.org/ticket/4267#comment:3
OpenStreetMap http://www.openstreetmap.org/
OpenStreetMap is a free editable map of the whole world

___
Potlatch-dev mailing list
Potlatch-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/potlatch-dev


Re: [Potlatch-dev] [OpenStreetMap] #4267: Potlatch 2 hangs up after some clicks (with update 04.03.2012)

2012-03-05 Thread OpenStreetMap
#4267: Potlatch 2 hangs up after some clicks (with update 04.03.2012)
---+
 Reporter:  Firefly!   |   Owner:  potlatch-dev@…
 Type:  defect |  Status:  new   
 Priority:  critical   |   Milestone:
Component:  potlatch2  | Version:  2.0   
 Keywords: |  
---+

Comment(by Firefly!):

 The Flash version on one of the used computers is 11.1.102.62, the other
 computer at home I updated two weeks ago.

 The problem seems not always reproduceable. Some minutes ago I could force
 it immediately (the OSM access is very slowly now), but at the time of
 writing of this ticket I could not (at that time the access speed was
 normally) ...

 Best regards!

-- 
Ticket URL: https://trac.openstreetmap.org/ticket/4267#comment:4
OpenStreetMap http://www.openstreetmap.org/
OpenStreetMap is a free editable map of the whole world

___
Potlatch-dev mailing list
Potlatch-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/potlatch-dev


[Potlatch-dev] [OpenStreetMap] #4269: tunnel=yes waterways aren't selectable (since 4/3/2012 changes)

2012-03-05 Thread OpenStreetMap
#4269: tunnel=yes waterways aren't selectable (since 4/3/2012 changes)
-+--
 Reporter:  SomeoneElse  |   Owner:  potlatch-dev@…
 Type:  defect   |  Status:  new   
 Priority:  minor|   Milestone:
Component:  potlatch2| Version:
 Keywords:   |  
-+--
 See here for example:

 
http://www.openstreetmap.org/edit?editor=potlatch2lat=53.155383lon=-1.376979zoom=18

 Switch to Potlatch 1 and you can see that the unselectable River Rother
 in the centre of the screen is actually a waterway.

-- 
Ticket URL: https://trac.openstreetmap.org/ticket/4269
OpenStreetMap http://www.openstreetmap.org/
OpenStreetMap is a free editable map of the whole world

___
Potlatch-dev mailing list
Potlatch-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/potlatch-dev