[Potlatch-dev] [OpenStreetMap] #4280: P2 does not correctly add nodes
#4280: P2 does not correctly add nodes -+-- Reporter: tom.davie@… | Owner: potlatch-dev@… Type: enhancement | Status: new Priority: minor| Milestone: Component: potlatch2| Version: Keywords: | -+-- Description: If you slightly missclick a way while adding a node to an edge which appears in many ways, the node can end up added only to some of the ways. steps to reproduce: 1. create a polygon with a landuse tag 2. create a polygon with a highway=primary tag sharing an edge with it 3. shift-click the way to add a node, but slightly miss so that you only click the highway, not the landuse edge. Expected behaviour: P2 finds all ways that have an edge running between the two nodes, and inserts the new node into all such ways. Actual behaviour: P2 only inserts a node into the ways that were actually under the mouse. -- Ticket URL: https://trac.openstreetmap.org/ticket/4280 OpenStreetMap http://www.openstreetmap.org/ OpenStreetMap is a free editable map of the whole world ___ Potlatch-dev mailing list Potlatch-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/potlatch-dev
Re: [Potlatch-dev] [OpenStreetMap] #4280: P2 does not correctly add nodes
I prefer the reported behaviour - there are cases where one wants to separate the two ways for a short distance - for example there may be a clearing in a forest adjacent to a road which elsewhere is the forest boundary. This would be difficult to achieve with the 'expected' behaviour. Roger Calvert On 09/03/2012 15:55, OpenStreetMap wrote: #4280: P2 does not correctly add nodes -+-- Reporter: tom.davie@… | Owner: potlatch-dev@… Type: enhancement | Status: new Priority: minor| Milestone: Component: potlatch2| Version: Keywords: | -+-- Description: If you slightly missclick a way while adding a node to an edge which appears in many ways, the node can end up added only to some of the ways. steps to reproduce: 1. create a polygon with a landuse tag 2. create a polygon with a highway=primary tag sharing an edge with it 3. shift-click the way to add a node, but slightly miss so that you only click the highway, not the landuse edge. Expected behaviour: P2 finds all ways that have an edge running between the two nodes, and inserts the new node into all such ways. Actual behaviour: P2 only inserts a node into the ways that were actually under the mouse. ___ Potlatch-dev mailing list Potlatch-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/potlatch-dev
Re: [Potlatch-dev] [OpenStreetMap] #4265: Unconnected roads
#4265: Unconnected roads ---+ Reporter: Maetma | Owner: potlatch-dev@… Type: defect | Status: new Priority: major | Milestone: Component: potlatch2 | Version: Keywords: | ---+ Comment(by Maetma): Example of bad changeset : http://www.openstreetmap.org/browse/changeset/10906079 Rue Arthur Rimbaud (153930056) is not connected at one of the side. Node: 1665464636 is only 0.01 meters from 364478371 -- Ticket URL: https://trac.openstreetmap.org/ticket/4265#comment:1 OpenStreetMap http://www.openstreetmap.org/ OpenStreetMap is a free editable map of the whole world ___ Potlatch-dev mailing list Potlatch-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/potlatch-dev
Re: [Potlatch-dev] [OpenStreetMap] #4264: Incorrect road
#4264: Incorrect road +--- Reporter: Maetma | Owner: potlatch-dev@… Type: defect | Status: reopened Priority: major | Milestone: Component: potlatch2 | Version: 2.0 Resolution: |Keywords: +--- Changes (by Maetma): * status: closed = reopened * resolution: invalid = Comment: Examples: http://www.openstreetmap.org/browse/changeset/10922002 http://www.openstreetmap.org/browse/changeset/10922023 -- Ticket URL: https://trac.openstreetmap.org/ticket/4264#comment:4 OpenStreetMap http://www.openstreetmap.org/ OpenStreetMap is a free editable map of the whole world ___ Potlatch-dev mailing list Potlatch-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/potlatch-dev
[Potlatch-dev] [OpenStreetMap] #4283: Improve error-handling on map_features.xml
#4283: Improve error-handling on map_features.xml ---+ Reporter: stevage| Owner: potlatch-dev@… Type: defect | Status: new Priority: minor | Milestone: Component: potlatch2 | Version: Keywords: | ---+ I recently made a change to one of the map_features subsidiaries which had a typo in it, and received a couple of unhelpful error messages. On loading: TypeError: Error #1090: XML parser failure: element is malformed. at net.systemeD.halcyon::NestedXMLLoader/fileLoaded()[I:\OSM\potgit6\potlatch2\net\systemeD\halcyon\NestedXMLLoader.as:39] When trying to display the simple editor: RangeError: Error #2006: The supplied index is out of bounds. at flash.display::DisplayObjectContainer/getChildAt() at mx.core::Container/getChildAt() at net.systemeD.potlatch2::CategorySelector/setSelectedFeature()[I:\OSM\potgit6\potlatch2\net\systemeD\potlatch2\CategorySelector.mxml:103] at net.systemeD.potlatch2::CategorySelector/__categoryStack_creationComplete()[I:\OSM\potgit6\potlatch2\net\systemeD\potlatch2\CategorySelector.mxml:12] at flash.events::EventDispatcher/dispatchEventFunction() at flash.events::EventDispatcher/dispatchEvent() at mx.core::UIComponent/dispatchEvent() at mx.core::UIComponent/set initialized() at mx.managers::LayoutManager/doPhasedInstantiation() at mx.managers::LayoutManager/doPhasedInstantiationCallback() at flash.utils::Timer/_timerDispatch() at flash.utils::Timer/tick() Now, since we can consider the map_features to be user-modifiable (as opposed to something we just QA before checking in), we should give more helpful error messages if they mess it up. -- Ticket URL: https://trac.openstreetmap.org/ticket/4283 OpenStreetMap http://www.openstreetmap.org/ OpenStreetMap is a free editable map of the whole world ___ Potlatch-dev mailing list Potlatch-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/potlatch-dev
Re: [Potlatch-dev] [OpenStreetMap] #4280: P2 does not correctly add nodes
#4280: P2 does not correctly add nodes -+-- Reporter: tom.davie@… | Owner: potlatch-dev@… Type: enhancement | Status: new Priority: minor| Milestone: Component: potlatch2| Version: Keywords: | -+-- Comment(by stevage): My preference: P2 notices there are multiple ways and offers you the choice. Alternative: P2 notices there are multiple ways and tries to guess which one you mean. (Still much better than the current situation, which is it basically picks at random.) One obvious heuristic would be to link like with like: if your way has a highway=*, it should connect with a highway=* rather than a boundary=* or a landuse=*. The current behaviour can be irritating (and worse, lead to the wrong result) when you have something like an administrative boundary running almost parallel with a road). I sometimes end up having to physically move the admin boundary out of the way so I can work on a road, then move it back afterwards. That ends up slightly moving those nodes, of course... -- Ticket URL: https://trac.openstreetmap.org/ticket/4280#comment:1 OpenStreetMap http://www.openstreetmap.org/ OpenStreetMap is a free editable map of the whole world ___ Potlatch-dev mailing list Potlatch-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/potlatch-dev
Re: [Potlatch-dev] State of play
On 10/03/12 03:08, Steve Bennett wrote: One thing I'm not sure about in this whole approach is what you're supposed to do with the zillions of branches you end up creating. Assuming that the pull requests all get accepted, am I then supposed to delete or archive these old branches? Seems like even more overhead, especially for tiny fixes... I would just delete them once they aren't needed anymore. And...now I see bad news in https://github.com/openstreetmap/potlatch2/network Am I right in saying that systemed is actually *behind* openstreetmap? So all my new branches are actually not based off the latest master at all? Doesn't look that way to me - systemed is about 5 commits ahead. Tom -- Tom Hughes (t...@compton.nu) http://compton.nu/ ___ Potlatch-dev mailing list Potlatch-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/potlatch-dev
