Re: [Potlatch-dev] [OpenStreetMap] #3671: Tag auto-completion is a bit random

2011-05-27 Thread Andy Allan 
On Fri, May 27, 2011 at 11:27 AM, Richard Fairhurst
 wrote:

> a) Andy pushes the patch to his repository on github
> b) I pull it into mine and review it (which takes 0.0005ms to check that
> it's a good patch, and about 30 minutes to remember how to do this in git)
> c) I push it to my potlatch2 repository on github (the Potlatch 2 master)
> and alert Tom
> d) Tom checks I haven't done anything evil and deploys it on osm.org

Arguably I'm slightly out-of-line marking trac reports as
"closed-fixed" before they are pulled by Richard and (arguably) they
should still be open until they hit the deployed version on osm.org.
But it makes my life easier to mark them as "fixed" when the fix has
been written (and when I'm pretty sure that that fix will be
accepted), and in our trac fixed automatically marks the issue as
closed.

Perhaps I should just tag a warning onto my trac comments that while
it's fixed it needs to wait on the next release before it'll become
live to save any confusion.

Cheers,
Andy

___
Potlatch-dev mailing list
Potlatch-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/potlatch-dev

Re: [Potlatch-dev] [OpenStreetMap] #3671: Tag auto-completion is a bit random

2011-05-27 Thread Richard Fairhurst 

SomeoneElse wrote:

Presumably a number of commits get bundled together before it goes live
on osm.org? I'm not seeing the change on the osm.org instance of
potlatch2 yet?


Yep - the process is:

a) Andy pushes the patch to his repository on github
b) I pull it into mine and review it (which takes 0.0005ms to check that 
it's a good patch, and about 30 minutes to remember how to do this in git)
c) I push it to my potlatch2 repository on github (the Potlatch 2 
master) and alert Tom

d) Tom checks I haven't done anything evil and deploys it on osm.org

All these stages are manual.

cheers
Richard

___
Potlatch-dev mailing list
Potlatch-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/potlatch-dev

Re: [Potlatch-dev] [OpenStreetMap] #3671: Tag auto-completion is a bit random

2011-05-27 Thread SomeoneElse 

On 27/05/2011 10:57, OpenStreetMap wrote:

#3671: Tag auto-completion is a bit random
--+-
   Reporter:  SomeoneElse  |   Owner:  potlatch-dev@…
   Type:  defect   |  Status:  closed
   Priority:  minor|   Milestone:
  Component:  potlatch2| Version:
Resolution:  fixed|Keywords:
--+-
Changes (by Andy Allan):

   * status:  new =>  closed
   * resolution:  =>  fixed


Comment:

  This was because only a limited number of tags (that is, the tags
  identifying features) were used to pre-populate the autocomplete lists.
  I've recently extended this to use tags from the different input fields -
  choice and freetext - and this covers practically all of the tags of
  interest including source and addr:housenumber.

  See
  
https://github.com/gravitystorm/Potlatch2/commit/a848ca4fd2a63c93e243279c991544e4858cc170
  and parent


Thanks for that - will make editing much easier.

Presumably a number of commits get bundled together before it goes live 
on osm.org?  I'm not seeing the change on the osm.org instance of 
potlatch2 yet?


Cheers,
Andy


___
Potlatch-dev mailing list
Potlatch-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/potlatch-dev

Re: [Potlatch-dev] [OpenStreetMap] #3671: Tag auto-completion is a bit random

2011-05-27 Thread OpenStreetMap 
#3671: Tag auto-completion is a bit random
--+-
  Reporter:  SomeoneElse  |   Owner:  potlatch-dev@…
  Type:  defect   |  Status:  closed
  Priority:  minor|   Milestone:
 Component:  potlatch2| Version:
Resolution:  fixed|Keywords:
--+-
Changes (by Andy Allan):

  * status:  new => closed
  * resolution:  => fixed


Comment:

 This was because only a limited number of tags (that is, the tags
 identifying features) were used to pre-populate the autocomplete lists.
 I've recently extended this to use tags from the different input fields -
 choice and freetext - and this covers practically all of the tags of
 interest including source and addr:housenumber.

 See
 
https://github.com/gravitystorm/Potlatch2/commit/a848ca4fd2a63c93e243279c991544e4858cc170
 and parent

-- 
Ticket URL: 
OpenStreetMap 
OpenStreetMap is a free editable map of the whole world

___
Potlatch-dev mailing list
Potlatch-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/potlatch-dev

[Potlatch-dev] [OpenStreetMap] #3671: Tag auto-completion is a bit random

2011-04-09 Thread OpenStreetMap 
#3671: Tag auto-completion is a bit random
-+--
 Reporter:  SomeoneElse  |   Owner:  potlatch-dev@…
 Type:  defect   |  Status:  new   
 Priority:  minor|   Milestone:
Component:  potlatch2| Version:
 Keywords:   |  
-+--
 The values available for tag auto-completion seem a bit random - they
 don't feature "source" for example.  When entering tags you have to be far
 more careful than with Potlatch 1 as it's far easier to enter half a tag.

-- 
Ticket URL: 
OpenStreetMap 
OpenStreetMap is a free editable map of the whole world

___
Potlatch-dev mailing list
Potlatch-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/potlatch-dev