Re: [Potlatch-dev] State of play
On Sat, Mar 10, 2012 at 6:41 PM, Tom Hughes t...@compton.nu wrote: I would just delete them once they aren't needed anymore. Delete them locally, you mean? Do you then need to push the deletion? Steve ___ Potlatch-dev mailing list Potlatch-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/potlatch-dev
Re: [Potlatch-dev] State of play
On 10/03/12 03:08, Steve Bennett wrote: One thing I'm not sure about in this whole approach is what you're supposed to do with the zillions of branches you end up creating. Assuming that the pull requests all get accepted, am I then supposed to delete or archive these old branches? Seems like even more overhead, especially for tiny fixes... I would just delete them once they aren't needed anymore. And...now I see bad news in https://github.com/openstreetmap/potlatch2/network Am I right in saying that systemed is actually *behind* openstreetmap? So all my new branches are actually not based off the latest master at all? Doesn't look that way to me - systemed is about 5 commits ahead. Tom -- Tom Hughes (t...@compton.nu) http://compton.nu/ ___ Potlatch-dev mailing list Potlatch-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/potlatch-dev
Re: [Potlatch-dev] State of play
On 5 March 2012 04:01, Steve Bennett stevag...@gmail.com wrote: undo on creating way fix, Definitely worthy of review - it's totally possible that I broke something else. Anyone else want to have a look at it? I guess we don't have any tests? We don't have any tests that cover starting drawing a new way. I'd absolutely love to have tests that cover all the Actions though - it's so important not to mess up the data in some subtle way while refactoring. After that, we can test whether pressing the buttons has the desired effects. There are some very basic Action tests at https://github.com/systemed/potlatch2/tree/master/tests/src/net/systemeD/halcyon/connection/actions already, but to say they are very basic is slightly overselling them! We're also lacking tests on most of the Entity functionality too. Cheers, Andy ___ Potlatch-dev mailing list Potlatch-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/potlatch-dev
Re: [Potlatch-dev] State of play
Current most obvious bug that I can see is that (in en-GB at least) the dreaded [object Object] is back on the GPS menu. Oh, and landuse=cemetery renders as a black opaque area. Appropriate I guess but probably not great for editing. :) cheers Richard ___ Potlatch-dev mailing list Potlatch-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/potlatch-dev
