[GitHub] cassandra pull request #265: 14705

2018-09-12 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/265#discussion_r217186512 --- Diff: src/java/org/apache/cassandra/batchlog/BatchlogManager.java --- @@ -459,36 +458,34 @@ private void writeHintsForUndeliveredEndpoints(int

[GitHub] cassandra pull request #265: 14705

2018-09-12 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/265#discussion_r217185707 --- Diff: src/java/org/apache/cassandra/service/AbstractWriteResponseHandler.java --- @@ -189,28 +189,30 @@ public final void expired() /**

[GitHub] cassandra pull request #265: 14705

2018-09-12 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/265#discussion_r217185167 --- Diff: src/java/org/apache/cassandra/service/reads/repair/BlockingReadRepair.java --- @@ -53,15 +53,16 @@ protected final Queue repairs =

[GitHub] cassandra pull request #265: 14705

2018-09-12 Thread belliottsmith
Github user belliottsmith commented on a diff in the pull request: https://github.com/apache/cassandra/pull/265#discussion_r217175374 --- Diff: src/java/org/apache/cassandra/service/reads/repair/BlockingReadRepair.java --- @@ -53,15 +53,16 @@ protected final Queue repairs

[GitHub] cassandra pull request #265: 14705

2018-09-12 Thread belliottsmith
Github user belliottsmith commented on a diff in the pull request: https://github.com/apache/cassandra/pull/265#discussion_r217112723 --- Diff: src/java/org/apache/cassandra/locator/ReplicaLayout.java --- @@ -18,364 +18,296 @@ package org.apache.cassandra.locator;

[GitHub] cassandra pull request #259: Cleanup repair path after Transient Replication

2018-09-12 Thread ifesdjeen
Github user ifesdjeen closed the pull request at: https://github.com/apache/cassandra/pull/259 --- - To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org

[GitHub] cassandra pull request #257: Allow transient range owner to serve as repair ...

2018-09-12 Thread ifesdjeen
Github user ifesdjeen closed the pull request at: https://github.com/apache/cassandra/pull/257 --- - To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org

[GitHub] cassandra pull request #261: Tr followup 4

2018-09-12 Thread ifesdjeen
Github user ifesdjeen closed the pull request at: https://github.com/apache/cassandra/pull/261 --- - To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org

[GitHub] cassandra pull request #262: Replicalayout followup

2018-09-12 Thread ifesdjeen
Github user ifesdjeen closed the pull request at: https://github.com/apache/cassandra/pull/262 --- - To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org

[GitHub] cassandra pull request #265: 14705

2018-09-12 Thread belliottsmith
Github user belliottsmith commented on a diff in the pull request: https://github.com/apache/cassandra/pull/265#discussion_r216916456 --- Diff: src/java/org/apache/cassandra/locator/ReplicaLayout.java --- @@ -194,14 +198,97 @@ public Token token() public static

[GitHub] cassandra pull request #265: 14705

2018-09-12 Thread belliottsmith
Github user belliottsmith commented on a diff in the pull request: https://github.com/apache/cassandra/pull/265#discussion_r216913748 --- Diff: src/java/org/apache/cassandra/locator/ReplicaPlan.java --- @@ -249,12 +229,32 @@ public int requiredParticipants() * we

[GitHub] cassandra pull request #265: 14705

2018-09-12 Thread belliottsmith
Github user belliottsmith commented on a diff in the pull request: https://github.com/apache/cassandra/pull/265#discussion_r216913492 --- Diff: src/java/org/apache/cassandra/locator/ReplicaPlan.java --- @@ -249,12 +229,32 @@ public int requiredParticipants() * we

[GitHub] cassandra pull request #265: 14705

2018-09-12 Thread belliottsmith
Github user belliottsmith commented on a diff in the pull request: https://github.com/apache/cassandra/pull/265#discussion_r216912914 --- Diff: src/java/org/apache/cassandra/service/reads/AbstractReadExecutor.java --- @@ -184,30 +185,28 @@ public static AbstractReadExecutor