[GitHub] cassandra pull request #273: Fix overflow of 32-bit integer during compactio...

2018-09-21 Thread belliottsmith
Github user belliottsmith commented on a diff in the pull request: https://github.com/apache/cassandra/pull/273#discussion_r219557250 --- Diff: src/java/org/apache/cassandra/utils/streamhist/StreamingTombstoneHistogramBuilder.java --- @@ -595,12 +600,22 @@ private boolean

[GitHub] cassandra pull request #273: Fix overflow of 32-bit integer during compactio...

2018-09-21 Thread belliottsmith
Github user belliottsmith commented on a diff in the pull request: https://github.com/apache/cassandra/pull/273#discussion_r219557162 --- Diff: src/java/org/apache/cassandra/utils/streamhist/StreamingTombstoneHistogramBuilder.java --- @@ -595,12 +600,22 @@ private boolean

[GitHub] cassandra pull request #267: Consolidate batch write code

2018-09-21 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/267#discussion_r219518994 --- Diff: src/java/org/apache/cassandra/locator/ReplicaPlans.java --- @@ -61,26 +73,62 @@ return forSingleReplicaWrite(keyspace, token,

[GitHub] cassandra pull request #267: Consolidate batch write code

2018-09-21 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/267#discussion_r219518928 --- Diff: src/java/org/apache/cassandra/service/StorageProxy.java --- @@ -1021,18 +1021,18 @@ private static void syncWriteToBatchlog(Collection

[GitHub] cassandra pull request #267: Consolidate batch write code

2018-09-21 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/267#discussion_r219508092 --- Diff: src/java/org/apache/cassandra/service/StorageProxy.java --- @@ -780,8 +780,9 @@ public static void mutateMV(ByteBuffer dataKey, Collection

[GitHub] cassandra pull request #267: Consolidate batch write code

2018-09-21 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/267#discussion_r219508033 --- Diff: src/java/org/apache/cassandra/locator/ReplicaPlans.java --- @@ -61,26 +73,62 @@ return forSingleReplicaWrite(keyspace, token,

[GitHub] cassandra pull request #266: Add a check for receiving digest response from ...

2018-09-21 Thread ifesdjeen
Github user ifesdjeen closed the pull request at: https://github.com/apache/cassandra/pull/266 --- - To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org

[GitHub] cassandra pull request #269: Review tr range movements

2018-09-21 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/269#discussion_r219488654 --- Diff: src/java/org/apache/cassandra/service/RangeRelocator.java --- @@ -0,0 +1,326 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] cassandra pull request #269: Review tr range movements

2018-09-21 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/269#discussion_r219488682 --- Diff: src/java/org/apache/cassandra/dht/RangeStreamer.java --- @@ -338,165 +386,152 @@ else if (useStrictConsistency)

[GitHub] cassandra pull request #269: Review tr range movements

2018-09-21 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/269#discussion_r219488550 --- Diff: src/java/org/apache/cassandra/dht/RangeStreamer.java --- @@ -446,16 +447,14 @@ else if (useStrictConsistency)

[GitHub] cassandra pull request #269: Review tr range movements

2018-09-21 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/269#discussion_r219488342 --- Diff: src/java/org/apache/cassandra/dht/RangeStreamer.java --- @@ -436,6 +436,7 @@ else if (useStrictConsistency) Set

[GitHub] cassandra pull request #269: Review tr range movements

2018-09-21 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/269#discussion_r219488307 --- Diff: src/java/org/apache/cassandra/dht/RangeStreamer.java --- @@ -265,10 +318,11 @@ public void addRanges(String keyspaceName, ReplicaCollection

[GitHub] cassandra-dtest pull request #37: Add tests for CASSANDRA-14145

2018-09-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cassandra-dtest/pull/37 --- - To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail:

[GitHub] cassandra-dtest issue #37: Add tests for CASSANDRA-14145

2018-09-21 Thread beobal
Github user beobal commented on the issue: https://github.com/apache/cassandra-dtest/pull/37 CASSANDRA-14755 is committed now, so I've rebased and squashed this & will commit manually. --- - To unsubscribe, e-mail:

[GitHub] cassandra pull request #269: Review tr range movements

2018-09-21 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/269#discussion_r219410357 --- Diff: src/java/org/apache/cassandra/dht/RangeStreamer.java --- @@ -446,16 +447,14 @@ else if (useStrictConsistency)