sunil9977 opened a new pull request, #3645:
URL: https://github.com/apache/cassandra/pull/3645
CASSANDRA-20025: Add support for IN clauses in SAI AND queries
1. Extended Expression.java to support IN clauses in Storage-Attached
Indexes (SAI).
2. Added a test case to evaluate it.
maulin-vasavada commented on code in PR #3638:
URL: https://github.com/apache/cassandra/pull/3638#discussion_r1823752049
##
src/java/org/apache/cassandra/config/EncryptionOptions.java:
##
@@ -173,7 +173,7 @@ public enum ConfigKey
this.keyName=keyName;
}
-
maulin-vasavada commented on code in PR #3638:
URL: https://github.com/apache/cassandra/pull/3638#discussion_r1823754007
##
src/java/org/apache/cassandra/config/EncryptionOptions.java:
##
@@ -173,7 +173,7 @@ public enum ConfigKey
this.keyName=keyName;
}
-
maulin-vasavada commented on code in PR #3638:
URL: https://github.com/apache/cassandra/pull/3638#discussion_r1823752497
##
src/java/org/apache/cassandra/config/EncryptionOptions.java:
##
@@ -173,7 +173,7 @@ public enum ConfigKey
this.keyName=keyName;
}
-
maulin-vasavada commented on code in PR #3638:
URL: https://github.com/apache/cassandra/pull/3638#discussion_r1823752497
##
src/java/org/apache/cassandra/config/EncryptionOptions.java:
##
@@ -173,7 +173,7 @@ public enum ConfigKey
this.keyName=keyName;
}
-
maulin-vasavada commented on code in PR #3638:
URL: https://github.com/apache/cassandra/pull/3638#discussion_r1823752049
##
src/java/org/apache/cassandra/config/EncryptionOptions.java:
##
@@ -173,7 +173,7 @@ public enum ConfigKey
this.keyName=keyName;
}
-
maulin-vasavada commented on code in PR #3638:
URL: https://github.com/apache/cassandra/pull/3638#discussion_r1823750089
##
test/distributed/org/apache/cassandra/distributed/test/JMXSslConfigDistributedTest.java:
##
@@ -0,0 +1,204 @@
+/*
+ * Licensed to the Apache Software Found
maulin-vasavada commented on code in PR #3638:
URL: https://github.com/apache/cassandra/pull/3638#discussion_r1823749785
##
test/distributed/org/apache/cassandra/distributed/test/JMXSslConfigDistributedTest.java:
##
@@ -0,0 +1,204 @@
+/*
+ * Licensed to the Apache Software Found
maulin-vasavada commented on code in PR #3638:
URL: https://github.com/apache/cassandra/pull/3638#discussion_r1823747361
##
test/distributed/org/apache/cassandra/distributed/impl/IsolatedJmx.java:
##
@@ -57,8 +60,8 @@ public class IsolatedJmx
private JMXServerUtils.JmxRegis
maulin-vasavada commented on code in PR #3638:
URL: https://github.com/apache/cassandra/pull/3638#discussion_r1823745419
##
test/distributed/org/apache/cassandra/distributed/test/JMXSslConfigDistributedTest.java:
##
@@ -0,0 +1,204 @@
+/*
+ * Licensed to the Apache Software Found
maulin-vasavada commented on code in PR #3638:
URL: https://github.com/apache/cassandra/pull/3638#discussion_r1823744702
##
test/distributed/org/apache/cassandra/distributed/test/JMXSslConfigDistributedTest.java:
##
@@ -0,0 +1,204 @@
+/*
+ * Licensed to the Apache Software Found
maulin-vasavada commented on code in PR #3638:
URL: https://github.com/apache/cassandra/pull/3638#discussion_r1823699272
##
examples/ssl-factory/test/unit/org/apache/cassandra/security/KubernetesSecretsPEMSslContextFactoryTest.java:
##
@@ -114,7 +114,7 @@ public void setup()
yifan-c commented on code in PR #143:
URL: https://github.com/apache/cassandra-sidecar/pull/143#discussion_r1823628935
##
server/src/main/java/org/apache/cassandra/sidecar/db/RestoreRange.java:
##
@@ -463,11 +469,11 @@ public long estimatedSpaceRequiredInBytes()
public St
yifan-c commented on code in PR #143:
URL: https://github.com/apache/cassandra-sidecar/pull/143#discussion_r1823629637
##
server/src/main/java/org/apache/cassandra/sidecar/restore/RestoreProcessor.java:
##
@@ -170,9 +169,6 @@ public void execute(Promise promise)
frankgh commented on code in PR #143:
URL: https://github.com/apache/cassandra-sidecar/pull/143#discussion_r1823580847
##
server/src/main/java/org/apache/cassandra/sidecar/db/RestoreRange.java:
##
@@ -463,11 +469,11 @@ public long estimatedSpaceRequiredInBytes()
public St
yifan-c opened a new pull request, #143:
URL: https://github.com/apache/cassandra-sidecar/pull/143
Patch by Yifan Cai; Reviewed by TBD for CASSANDRASC-155
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
arjunashok commented on code in PR #139:
URL: https://github.com/apache/cassandra-sidecar/pull/139#discussion_r1823489255
##
client-common/src/main/java/org/apache/cassandra/sidecar/common/ApiEndpointsV1.java:
##
@@ -109,6 +109,9 @@ public final class ApiEndpointsV1
public
absurdfarce commented on PR #1743:
URL:
https://github.com/apache/cassandra-java-driver/pull/1743#issuecomment-2448378351
Looks great, thanks @SiyaoIsHiding !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
absurdfarce merged PR #1743:
URL: https://github.com/apache/cassandra-java-driver/pull/1743
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr.
michaelsembwever commented on code in PR #1982:
URL:
https://github.com/apache/cassandra-java-driver/pull/1982#discussion_r1823359821
##
Jenkinsfile-asf:
##
@@ -66,7 +67,7 @@ pipeline {
def executeTests() {
def testJavaMajorVersion = (TEST_JAVA_VERSION =~ /@(?:1\.)?(\d+)/
smiklosovic commented on code in PR #3644:
URL: https://github.com/apache/cassandra/pull/3644#discussion_r182095
##
src/java/org/apache/cassandra/cache/InstrumentingCache.java:
##
@@ -84,6 +86,11 @@ public void setCapacity(long capacity)
map.setCapacity(capacity);
smiklosovic commented on code in PR #3644:
URL: https://github.com/apache/cassandra/pull/3644#discussion_r1823328283
##
src/java/org/apache/cassandra/cache/InstrumentingCache.java:
##
@@ -84,6 +86,11 @@ public void setCapacity(long capacity)
map.setCapacity(capacity);
smiklosovic commented on code in PR #3644:
URL: https://github.com/apache/cassandra/pull/3644#discussion_r1823328283
##
src/java/org/apache/cassandra/cache/InstrumentingCache.java:
##
@@ -84,6 +86,11 @@ public void setCapacity(long capacity)
map.setCapacity(capacity);
smiklosovic commented on code in PR #3644:
URL: https://github.com/apache/cassandra/pull/3644#discussion_r182095
##
src/java/org/apache/cassandra/cache/InstrumentingCache.java:
##
@@ -84,6 +86,11 @@ public void setCapacity(long capacity)
map.setCapacity(capacity);
smiklosovic commented on code in PR #3644:
URL: https://github.com/apache/cassandra/pull/3644#discussion_r182095
##
src/java/org/apache/cassandra/cache/InstrumentingCache.java:
##
@@ -84,6 +86,11 @@ public void setCapacity(long capacity)
map.setCapacity(capacity);
smiklosovic commented on code in PR #3644:
URL: https://github.com/apache/cassandra/pull/3644#discussion_r1823328283
##
src/java/org/apache/cassandra/cache/InstrumentingCache.java:
##
@@ -84,6 +86,11 @@ public void setCapacity(long capacity)
map.setCapacity(capacity);
SiyaoIsHiding opened a new pull request, #1982:
URL: https://github.com/apache/cassandra-java-driver/pull/1982
TODO: change the docker image name from
"janehe/cassandra-java-driver-dev-env" to
"apache.jfrog.io/cassan-docker/apache/cassandra-java-driver-testing-ubuntu2204"
The changes
SiyaoIsHiding commented on PR #106:
URL: https://github.com/apache/cassandra-builds/pull/106#issuecomment-2448171199
Thank you for educating me!! I watched that video and learned so much from
it.
Is there anything else about git practice that you want me to do?
--
This is an automated
SiyaoIsHiding commented on PR #106:
URL: https://github.com/apache/cassandra-builds/pull/106#issuecomment-2448176677
Got green run here:
http://35.228.140.106:8080/blue/organizations/jenkins/multi-branch-java-driver/detail/asf-ci/28/pipeline/95/
--
This is an automated message from the Ap
SiyaoIsHiding commented on code in PR #106:
URL: https://github.com/apache/cassandra-builds/pull/106#discussion_r1823225576
##
docker/testing/ubuntu2204_java_driver_testing.docker:
##
@@ -53,4 +53,12 @@ RUN git clone https://github.com/riptano/ccm.git && \
cd ccm && \
SiyaoIsHiding commented on PR #1743:
URL:
https://github.com/apache/cassandra-java-driver/pull/1743#issuecomment-2448051652
Thanks for the reviews and approvals! Commits squashed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
Mmuzaf commented on code in PR #3133:
URL: https://github.com/apache/cassandra/pull/3133#discussion_r1823049925
##
src/java/org/apache/cassandra/db/CounterMutation.java:
##
@@ -211,7 +210,7 @@ private PartitionUpdate
processModifications(PartitionUpdate changes)
List
joao-r-reis commented on code in PR #1828:
URL:
https://github.com/apache/cassandra-gocql-driver/pull/1828#discussion_r1823147182
##
marshal.go:
##
@@ -1709,6 +1719,169 @@ func unmarshalList(info TypeInfo, data []byte, value
interface{}) error {
return unmarshalErrorf(
lukasz-antoniak commented on code in PR #1828:
URL:
https://github.com/apache/cassandra-gocql-driver/pull/1828#discussion_r1822940511
##
helpers.go:
##
@@ -162,54 +164,152 @@ func getCassandraBaseType(name string) Type {
}
}
-func getCassandraType(name string, logger
Mmuzaf commented on code in PR #3133:
URL: https://github.com/apache/cassandra/pull/3133#discussion_r1823047019
##
src/java/org/apache/cassandra/io/sstable/format/SSTableReader.java:
##
@@ -716,9 +716,8 @@ public void setupOnline()
// under normal operation we can do th
absurdfarce commented on code in PR #1958:
URL:
https://github.com/apache/cassandra-java-driver/pull/1958#discussion_r1823018023
##
test-infra/src/main/java/com/datastax/oss/driver/api/testinfra/ccm/CcmBridge.java:
##
@@ -175,25 +176,24 @@ private static boolean isWindows() {
Mmuzaf opened a new pull request, #3644:
URL: https://github.com/apache/cassandra/pull/3644
Thanks for sending a pull request! Here are some tips if you're new here:
* Ensure you have added or run the [appropriate
tests](https://cassandra.apache.org/_/development/testing.html) for y
Mmuzaf commented on code in PR #3133:
URL: https://github.com/apache/cassandra/pull/3133#discussion_r1823045462
##
src/java/org/apache/cassandra/db/ColumnFamilyStore.java:
##
@@ -3048,19 +3049,19 @@ public boolean isEmpty()
public boolean isRowCacheEnabled()
{
-
Mmuzaf commented on code in PR #3133:
URL: https://github.com/apache/cassandra/pull/3133#discussion_r1823066870
##
src/java/org/apache/cassandra/db/ColumnFamilyStore.java:
##
@@ -3048,19 +3049,19 @@ public boolean isEmpty()
public boolean isRowCacheEnabled()
{
-
Mmuzaf commented on PR #3133:
URL: https://github.com/apache/cassandra/pull/3133#issuecomment-2447823989
I think all the method calls like `getCapacity() != 0` and `getCapacity() ==
0` should be replaced by a method in the DatabaseDescriptor class that is clear
and easy to use whether a cac
worryg0d commented on code in PR #1822:
URL:
https://github.com/apache/cassandra-gocql-driver/pull/1822#discussion_r1823049464
##
conn.go:
##
@@ -1347,7 +1527,8 @@ func (c *Conn) executeQuery(ctx context.Context, qry
*Query) *Iter {
params.pageSize = qry.pageSi
Mmuzaf commented on code in PR #3133:
URL: https://github.com/apache/cassandra/pull/3133#discussion_r1823047991
##
src/java/org/apache/cassandra/io/sstable/format/SSTableReader.java:
##
@@ -1333,7 +1332,7 @@ public void cacheKey(DecoratedKey key, RowIndexEntry info)
{
absurdfarce commented on PR #1958:
URL:
https://github.com/apache/cassandra-java-driver/pull/1958#issuecomment-2447775240
Thanks for sticking with this @lukasz-antoniak!
Can you resolve the conflicts above? I'd like to get a Jenkins run of this
branch to make sure we don't have any
joao-r-reis commented on PR #1770:
URL:
https://github.com/apache/cassandra-gocql-driver/pull/1770#issuecomment-2447717740
Maybe we can shorten the package name a bit to `hostpoolpolicy`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
lukasz-antoniak commented on code in PR #1828:
URL:
https://github.com/apache/cassandra-gocql-driver/pull/1828#discussion_r1822942040
##
metadata.go:
##
@@ -947,11 +947,11 @@ func getColumnMetadata(session *Session, keyspaceName
string) ([]ColumnMetadata,
return column
lukasz-antoniak commented on code in PR #1828:
URL:
https://github.com/apache/cassandra-gocql-driver/pull/1828#discussion_r1822940873
##
helpers.go:
##
@@ -162,54 +164,152 @@ func getCassandraBaseType(name string) Type {
}
}
-func getCassandraType(name string, logger
joao-r-reis commented on code in PR #1822:
URL:
https://github.com/apache/cassandra-gocql-driver/pull/1822#discussion_r1822399213
##
conn.go:
##
@@ -1347,7 +1527,8 @@ func (c *Conn) executeQuery(ctx context.Context, qry
*Query) *Iter {
params.pageSize = qry.pag
joao-r-reis closed pull request #1812: CASSANDRA-19796 – cassandra-gocql-driver
CI
URL: https://github.com/apache/cassandra-gocql-driver/pull/1812
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
joao-r-reis commented on code in PR #1828:
URL:
https://github.com/apache/cassandra-gocql-driver/pull/1828#discussion_r1822889588
##
helpers.go:
##
@@ -162,54 +164,152 @@ func getCassandraBaseType(name string) Type {
}
}
-func getCassandraType(name string, logger Std
smiklosovic opened a new pull request, #3643:
URL: https://github.com/apache/cassandra/pull/3643
Thanks for sending a pull request! Here are some tips if you're new here:
* Ensure you have added or run the [appropriate
tests](https://cassandra.apache.org/_/development/testing.html)
joao-r-reis commented on code in PR #1822:
URL:
https://github.com/apache/cassandra-gocql-driver/pull/1822#discussion_r1822512163
##
conn.go:
##
@@ -1347,7 +1527,8 @@ func (c *Conn) executeQuery(ctx context.Context, qry
*Query) *Iter {
params.pageSize = qry.pag
joao-r-reis commented on code in PR #1822:
URL:
https://github.com/apache/cassandra-gocql-driver/pull/1822#discussion_r1822512163
##
conn.go:
##
@@ -1347,7 +1527,8 @@ func (c *Conn) executeQuery(ctx context.Context, qry
*Query) *Iter {
params.pageSize = qry.pag
tengu-alt opened a new pull request, #1838:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1838
This PR provides marshal/unmarshal error messages enhancement.
According to #671 errors were updated by the supported types list.
--
This is an automated message from the Apache G
worryg0d commented on code in PR #1822:
URL:
https://github.com/apache/cassandra-gocql-driver/pull/1822#discussion_r1822432779
##
conn.go:
##
@@ -1347,7 +1527,8 @@ func (c *Conn) executeQuery(ctx context.Context, qry
*Query) *Iter {
params.pageSize = qry.pageSi
joao-r-reis commented on code in PR #1822:
URL:
https://github.com/apache/cassandra-gocql-driver/pull/1822#discussion_r1822401006
##
conn.go:
##
@@ -1347,7 +1527,8 @@ func (c *Conn) executeQuery(ctx context.Context, qry
*Query) *Iter {
params.pageSize = qry.pag
smiklosovic commented on code in PR #3638:
URL: https://github.com/apache/cassandra/pull/3638#discussion_r1822351976
##
src/java/org/apache/cassandra/utils/jmx/DefaultJmxSocketFactory.java:
##
@@ -0,0 +1,84 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+
worryg0d commented on code in PR #1822:
URL:
https://github.com/apache/cassandra-gocql-driver/pull/1822#discussion_r1822350152
##
conn.go:
##
@@ -1430,6 +1529,34 @@ func (c *Conn) executeQuery(ctx context.Context, qry
*Query) *Iter {
case *resultVoidFrame:
worryg0d commented on code in PR #1822:
URL:
https://github.com/apache/cassandra-gocql-driver/pull/1822#discussion_r1822350152
##
conn.go:
##
@@ -1430,6 +1529,34 @@ func (c *Conn) executeQuery(ctx context.Context, qry
*Query) *Iter {
case *resultVoidFrame:
worryg0d commented on code in PR #1822:
URL:
https://github.com/apache/cassandra-gocql-driver/pull/1822#discussion_r1822340559
##
conn.go:
##
@@ -1430,13 +1612,36 @@ func (c *Conn) executeQuery(ctx context.Context, qry
*Query) *Iter {
case *resultVoidFrame:
worryg0d commented on code in PR #1822:
URL:
https://github.com/apache/cassandra-gocql-driver/pull/1822#discussion_r1822337941
##
conn.go:
##
@@ -1430,13 +1612,36 @@ func (c *Conn) executeQuery(ctx context.Context, qry
*Query) *Iter {
case *resultVoidFrame:
worryg0d commented on code in PR #1822:
URL:
https://github.com/apache/cassandra-gocql-driver/pull/1822#discussion_r1822337031
##
conn.go:
##
@@ -1430,13 +1612,36 @@ func (c *Conn) executeQuery(ctx context.Context, qry
*Query) *Iter {
case *resultVoidFrame:
worryg0d commented on code in PR #1822:
URL:
https://github.com/apache/cassandra-gocql-driver/pull/1822#discussion_r1822332752
##
conn.go:
##
@@ -1347,7 +1527,8 @@ func (c *Conn) executeQuery(ctx context.Context, qry
*Query) *Iter {
params.pageSize = qry.pageSi
lukasz-antoniak opened a new pull request, #1981:
URL: https://github.com/apache/cassandra-java-driver/pull/1981
Fix
[JAVA-3158](https://datastax-oss.atlassian.net/jira/software/c/projects/JAVA/issues/JAVA-3158).
--
This is an automated message from the Apache Git Service.
To respond to t
63 matches
Mail list logo
