[GitHub] cassandra issue #257: Allow transient range owner to serve as repair coordin...

2018-09-07 Thread ifesdjeen
Github user ifesdjeen commented on the issue: https://github.com/apache/cassandra/pull/257 Heh, now I need to take a look as well) --- - To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional comm

[GitHub] cassandra issue #257: Allow transient range owner to serve as repair coordin...

2018-09-07 Thread bdeggleston
Github user bdeggleston commented on the issue: https://github.com/apache/cassandra/pull/257 @ifesdjeen did some further consolidation of the sync task class hierarchy [here](https://github.com/bdeggleston/cassandra/tree/alexp/tr-followup-1/review2). I'm not really opposed to doing th

[GitHub] cassandra issue #257: Allow transient range owner to serve as repair coordin...

2018-09-06 Thread ifesdjeen
Github user ifesdjeen commented on the issue: https://github.com/apache/cassandra/pull/257 @aweisberg fixed imports and spelling. Thank you for spotting those. --- - To unsubscribe, e-mail: pr-unsubscr...@cassandra.a

[GitHub] cassandra issue #257: Allow transient range owner to serve as repair coordin...

2018-09-06 Thread ifesdjeen
Github user ifesdjeen commented on the issue: https://github.com/apache/cassandra/pull/257 @bdeggleston thank you for the review and changes, they look great! I agree the class hierarchy became not very optimal. I was concentrating on the AssumetrciLocalSyncTask and didn't cha

[GitHub] cassandra issue #257: Allow transient range owner to serve as repair coordin...

2018-09-05 Thread bdeggleston
Github user bdeggleston commented on the issue: https://github.com/apache/cassandra/pull/257 I think I've mostly convinced myself this is all you need to do to support coordinating repairs for locally transient ranges. I have a commit [here](https://github.com/bdeggleston/cassandra/tr