[GitHub] cassandra pull request #265: 14705

2018-09-12 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/265#discussion_r217186512 --- Diff: src/java/org/apache/cassandra/batchlog/BatchlogManager.java --- @@ -459,36 +458,34 @@ private void writeHintsForUndeliveredEndpoints(int

[GitHub] cassandra pull request #265: 14705

2018-09-12 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/265#discussion_r217185707 --- Diff: src/java/org/apache/cassandra/service/AbstractWriteResponseHandler.java --- @@ -189,28 +189,30 @@ public final void expired() /**

[GitHub] cassandra pull request #265: 14705

2018-09-12 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/265#discussion_r217185167 --- Diff: src/java/org/apache/cassandra/service/reads/repair/BlockingReadRepair.java --- @@ -53,15 +53,16 @@ protected final Queue repairs =

[GitHub] cassandra pull request #265: 14705

2018-09-12 Thread belliottsmith
Github user belliottsmith commented on a diff in the pull request: https://github.com/apache/cassandra/pull/265#discussion_r217175374 --- Diff: src/java/org/apache/cassandra/service/reads/repair/BlockingReadRepair.java --- @@ -53,15 +53,16 @@ protected final Queue repairs

[GitHub] cassandra pull request #265: 14705

2018-09-12 Thread belliottsmith
Github user belliottsmith commented on a diff in the pull request: https://github.com/apache/cassandra/pull/265#discussion_r217112723 --- Diff: src/java/org/apache/cassandra/locator/ReplicaLayout.java --- @@ -18,364 +18,296 @@ package org.apache.cassandra.locator;

[GitHub] cassandra pull request #265: 14705

2018-09-12 Thread belliottsmith
Github user belliottsmith commented on a diff in the pull request: https://github.com/apache/cassandra/pull/265#discussion_r216916456 --- Diff: src/java/org/apache/cassandra/locator/ReplicaLayout.java --- @@ -194,14 +198,97 @@ public Token token() public static

[GitHub] cassandra pull request #265: 14705

2018-09-12 Thread belliottsmith
Github user belliottsmith commented on a diff in the pull request: https://github.com/apache/cassandra/pull/265#discussion_r216913748 --- Diff: src/java/org/apache/cassandra/locator/ReplicaPlan.java --- @@ -249,12 +229,32 @@ public int requiredParticipants() * we

[GitHub] cassandra pull request #265: 14705

2018-09-12 Thread belliottsmith
Github user belliottsmith commented on a diff in the pull request: https://github.com/apache/cassandra/pull/265#discussion_r216913492 --- Diff: src/java/org/apache/cassandra/locator/ReplicaPlan.java --- @@ -249,12 +229,32 @@ public int requiredParticipants() * we

[GitHub] cassandra pull request #265: 14705

2018-09-12 Thread belliottsmith
Github user belliottsmith commented on a diff in the pull request: https://github.com/apache/cassandra/pull/265#discussion_r216912914 --- Diff: src/java/org/apache/cassandra/service/reads/AbstractReadExecutor.java --- @@ -184,30 +185,28 @@ public static AbstractReadExecutor

[GitHub] cassandra pull request #265: 14705

2018-09-11 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/265#discussion_r216846177 --- Diff: src/java/org/apache/cassandra/service/reads/DigestResolver.java --- @@ -93,16 +93,14 @@ public PartitionIterator getData() {

[GitHub] cassandra pull request #265: 14705

2018-09-11 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/265#discussion_r216839700 --- Diff: src/java/org/apache/cassandra/service/reads/AbstractReadExecutor.java --- @@ -184,30 +185,28 @@ public static AbstractReadExecutor

[GitHub] cassandra pull request #265: 14705

2018-09-10 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/265#discussion_r216486027 --- Diff: src/java/org/apache/cassandra/locator/ReplicaLayout.java --- @@ -194,14 +198,97 @@ public Token token() public static

[GitHub] cassandra pull request #265: 14705

2018-09-10 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/265#discussion_r216473482 --- Diff: src/java/org/apache/cassandra/locator/ReplicaPlan.java --- @@ -249,12 +229,32 @@ public int requiredParticipants() * we

[GitHub] cassandra pull request #265: 14705

2018-09-10 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/265#discussion_r216473356 --- Diff: src/java/org/apache/cassandra/locator/ReplicaPlan.java --- @@ -249,12 +229,32 @@ public int requiredParticipants() * we

[GitHub] cassandra pull request #265: 14705

2018-09-10 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/265#discussion_r216451203 --- Diff: src/java/org/apache/cassandra/locator/ReplicaLayout.java --- @@ -18,364 +18,296 @@ package org.apache.cassandra.locator;

[GitHub] cassandra pull request #265: 14705

2018-09-10 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/265#discussion_r216442898 --- Diff: src/java/org/apache/cassandra/service/reads/repair/BlockingReadRepair.java --- @@ -53,15 +53,16 @@ protected final Queue repairs =

[GitHub] cassandra pull request #265: 14705

2018-09-10 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/265#discussion_r216434289 --- Diff: src/java/org/apache/cassandra/service/reads/AbstractReadExecutor.java --- @@ -196,7 +196,7 @@ public static AbstractReadExecutor

[GitHub] cassandra pull request #265: 14705

2018-09-10 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/265#discussion_r216432759 --- Diff: test/unit/org/apache/cassandra/locator/ReplicaCollectionTest.java --- @@ -182,7 +160,17 @@ private void assertSubList(C subCollection, int