[GitHub] cassandra pull request #271: 14726

2018-10-01 Thread belliottsmith
Github user belliottsmith commented on a diff in the pull request: https://github.com/apache/cassandra/pull/271#discussion_r221530400 --- Diff: src/java/org/apache/cassandra/locator/EndpointsByRange.java --- @@ -54,9 +55,13 @@ public void putAll(Range range, EndpointsForRange

[GitHub] cassandra pull request #271: 14726

2018-10-01 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/271#discussion_r221529971 --- Diff: src/java/org/apache/cassandra/locator/AbstractReplicaCollection.java --- @@ -58,45 +63,332 @@ }; } -

[GitHub] cassandra pull request #271: 14726

2018-10-01 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/271#discussion_r221529863 --- Diff: src/java/org/apache/cassandra/locator/AbstractReplicaCollection.java --- @@ -58,45 +63,332 @@ }; } -

[GitHub] cassandra pull request #271: 14726

2018-10-01 Thread belliottsmith
Github user belliottsmith commented on a diff in the pull request: https://github.com/apache/cassandra/pull/271#discussion_r221526704 --- Diff: src/java/org/apache/cassandra/locator/ReplicaMultimap.java --- @@ -39,21 +39,28 @@ public abstract C get(K key); public

[GitHub] cassandra pull request #271: 14726

2018-09-28 Thread belliottsmith
Github user belliottsmith commented on a diff in the pull request: https://github.com/apache/cassandra/pull/271#discussion_r221306464 --- Diff: src/java/org/apache/cassandra/locator/AbstractReplicaCollection.java --- @@ -58,45 +63,332 @@ }; } -

[GitHub] cassandra pull request #271: 14726

2018-09-27 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/271#discussion_r220986153 --- Diff: src/java/org/apache/cassandra/locator/AbstractReplicaCollection.java --- @@ -58,45 +63,332 @@ }; } -

[GitHub] cassandra pull request #271: 14726

2018-09-27 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/271#discussion_r220966312 --- Diff: src/java/org/apache/cassandra/locator/AbstractReplicaCollection.java --- @@ -58,45 +63,332 @@ }; } -

[GitHub] cassandra pull request #271: 14726

2018-09-27 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/271#discussion_r220951620 --- Diff: src/java/org/apache/cassandra/locator/AbstractReplicaCollection.java --- @@ -58,45 +63,332 @@ }; } -

[GitHub] cassandra pull request #271: 14726

2018-09-27 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/271#discussion_r220871785 --- Diff: test/unit/org/apache/cassandra/locator/ReplicaCollectionTest.java --- @@ -141,28 +147,37 @@ public void testOrderOfIteration() {

[GitHub] cassandra pull request #271: 14726

2018-09-27 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/271#discussion_r220874274 --- Diff: test/unit/org/apache/cassandra/locator/ReplicaCollectionTest.java --- @@ -141,28 +147,37 @@ public void testOrderOfIteration() {

[GitHub] cassandra pull request #271: 14726

2018-09-27 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/271#discussion_r220869142 --- Diff: src/java/org/apache/cassandra/locator/EndpointsForRange.java --- @@ -40,13 +37,13 @@ public class EndpointsForRange extends Endpoints

[GitHub] cassandra pull request #271: 14726

2018-09-27 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/271#discussion_r220871228 --- Diff: src/java/org/apache/cassandra/locator/Endpoints.java --- @@ -36,13 +33,16 @@ */ public abstract class Endpoints> extends

[GitHub] cassandra pull request #271: 14726

2018-09-26 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/271#discussion_r220639909 --- Diff: src/java/org/apache/cassandra/locator/EndpointsForToken.java --- @@ -37,14 +34,14 @@ public class EndpointsForToken extends Endpoints

[GitHub] cassandra pull request #271: 14726

2018-09-26 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/271#discussion_r220639872 --- Diff: src/java/org/apache/cassandra/locator/EndpointsForToken.java --- @@ -21,12 +21,9 @@ import com.google.common.base.Preconditions;

[GitHub] cassandra pull request #271: 14726

2018-09-26 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/271#discussion_r220639181 --- Diff: src/java/org/apache/cassandra/locator/EndpointsForRange.java --- @@ -40,13 +37,13 @@ public class EndpointsForRange extends Endpoints

[GitHub] cassandra pull request #271: 14726

2018-09-26 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/271#discussion_r220635308 --- Diff: src/java/org/apache/cassandra/locator/EndpointsForRange.java --- @@ -57,95 +54,77 @@ private EndpointsForRange(Range range, List list,

[GitHub] cassandra pull request #271: 14726

2018-09-26 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/271#discussion_r220635043 --- Diff: src/java/org/apache/cassandra/locator/EndpointsForRange.java --- @@ -57,95 +54,77 @@ private EndpointsForRange(Range range, List list,

[GitHub] cassandra pull request #271: 14726

2018-09-26 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/271#discussion_r220621697 --- Diff: src/java/org/apache/cassandra/locator/AbstractReplicaCollection.java --- @@ -58,45 +63,332 @@ }; } -