[GitHub] cassandra pull request #239: [CASSANDRA-14556] Optimize Streaming

2018-07-23 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/239#discussion_r204562307 --- Diff: src/java/org/apache/cassandra/db/streaming/CassandraOutgoingFile.java --- @@ -114,13 +155,51 @@ public void write(StreamSession session,

[GitHub] cassandra pull request #239: [CASSANDRA-14556] Optimize Streaming

2018-07-23 Thread iamaleksey
Github user iamaleksey commented on a diff in the pull request: https://github.com/apache/cassandra/pull/239#discussion_r204531887 --- Diff: src/java/org/apache/cassandra/db/streaming/CassandraOutgoingFile.java --- @@ -114,13 +155,51 @@ public void write(StreamSession session,

[GitHub] cassandra pull request #239: [CASSANDRA-14556] Optimize Streaming

2018-07-23 Thread iamaleksey
Github user iamaleksey commented on a diff in the pull request: https://github.com/apache/cassandra/pull/239#discussion_r204537184 --- Diff: src/java/org/apache/cassandra/db/streaming/ComponentInfo.java --- @@ -0,0 +1,97 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] cassandra pull request #239: [CASSANDRA-14556] Optimize Streaming

2018-07-23 Thread iamaleksey
Github user iamaleksey commented on a diff in the pull request: https://github.com/apache/cassandra/pull/239#discussion_r204538045 --- Diff: src/java/org/apache/cassandra/db/streaming/ComponentInfo.java --- @@ -0,0 +1,97 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] cassandra pull request #239: [CASSANDRA-14556] Optimize Streaming

2018-07-23 Thread iamaleksey
Github user iamaleksey commented on a diff in the pull request: https://github.com/apache/cassandra/pull/239#discussion_r204458523 --- Diff: src/java/org/apache/cassandra/config/DatabaseDescriptor.java --- @@ -2260,6 +2260,20 @@ public static int getStreamingConnectionsPerHost()

[GitHub] cassandra pull request #239: [CASSANDRA-14556] Optimize Streaming

2018-07-23 Thread dineshjoshi
Github user dineshjoshi commented on a diff in the pull request: https://github.com/apache/cassandra/pull/239#discussion_r204586299 --- Diff: src/java/org/apache/cassandra/db/streaming/CassandraOutgoingFile.java --- @@ -114,13 +155,51 @@ public void write(StreamSession session,

[GitHub] cassandra pull request #236: 9608 trunk

2018-07-23 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/236#discussion_r204368353 --- Diff: src/java/org/apache/cassandra/io/util/FileUtils.java --- @@ -64,24 +68,31 @@ public static final long ONE_TB = 1024 * ONE_GB;

[GitHub] cassandra pull request #236: 9608 trunk

2018-07-23 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/236#discussion_r204355461 --- Diff: build.xml --- @@ -66,8 +67,14 @@ - - +

[GitHub] cassandra pull request #236: 9608 trunk

2018-07-23 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/236#discussion_r204370957 --- Diff: src/java/org/apache/cassandra/io/util/FileUtils.java --- @@ -350,13 +396,38 @@ public static String getRelativePath(String basePath, String

[GitHub] cassandra pull request #236: 9608 trunk

2018-07-23 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/236#discussion_r204369509 --- Diff: src/java/org/apache/cassandra/io/util/FileUtils.java --- @@ -350,13 +396,38 @@ public static String getRelativePath(String basePath, String

[GitHub] cassandra pull request #236: 9608 trunk

2018-07-23 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/236#discussion_r204369082 --- Diff: src/java/org/apache/cassandra/io/util/FileUtils.java --- @@ -106,11 +117,46 @@ public static void createHardLink(File from, File to)

[GitHub] cassandra pull request #236: 9608 trunk

2018-07-23 Thread snazy
Github user snazy commented on a diff in the pull request: https://github.com/apache/cassandra/pull/236#discussion_r204380974 --- Diff: build.xml --- @@ -1665,7 +1763,7 @@ - + --- End diff -- Oops, re-added ---

[GitHub] cassandra pull request #236: 9608 trunk

2018-07-23 Thread snazy
Github user snazy commented on a diff in the pull request: https://github.com/apache/cassandra/pull/236#discussion_r204382546 --- Diff: src/java/org/apache/cassandra/io/util/FileUtils.java --- @@ -350,13 +396,38 @@ public static String getRelativePath(String basePath, String path)

[GitHub] cassandra pull request #236: 9608 trunk

2018-07-23 Thread snazy
Github user snazy commented on a diff in the pull request: https://github.com/apache/cassandra/pull/236#discussion_r204380932 --- Diff: src/java/org/apache/cassandra/cql3/functions/JavaBasedUDFunction.java --- @@ -591,14 +592,17 @@ private NameEnvironmentAnswer findType(String

[GitHub] cassandra pull request #236: 9608 trunk

2018-07-23 Thread snazy
Github user snazy commented on a diff in the pull request: https://github.com/apache/cassandra/pull/236#discussion_r204381413 --- Diff: src/java/org/apache/cassandra/io/util/FileUtils.java --- @@ -64,24 +68,31 @@ public static final long ONE_TB = 1024 * ONE_GB;

[GitHub] cassandra pull request #239: [CASSANDRA-14556] Optimize Streaming

2018-07-23 Thread iamaleksey
Github user iamaleksey commented on a diff in the pull request: https://github.com/apache/cassandra/pull/239#discussion_r204437695 --- Diff: src/java/org/apache/cassandra/db/streaming/CassandraOutgoingFile.java --- @@ -114,13 +155,51 @@ public void write(StreamSession session,