[GitHub] cassandra pull request #193: Better document in code InetAddressAndPort usag...
GitHub user aweisberg opened a pull request: https://github.com/apache/cassandra/pull/193 Better document in code InetAddressAndPort usage post 7544 You can merge this pull request into a Git repository by running: $ git pull https://github.com/aweisberg/cassandra cassandra-14226 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cassandra/pull/193.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #193 commit 477a4e29d7a331a1175b25ad91061cba30d08e23 Author: Ariel WeisbergDate: 2018-02-09T22:38:52Z Better document in code InetAddressAndPort usage post 7544 --- - To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org
[GitHub] cassandra-dtest issue #6: 12148 style
Github user josh-mckenzie commented on the issue: https://github.com/apache/cassandra-dtest/pull/6 Right, operating under the assumption that Jim's initial logic (that I reviewed back then) is accurate. This is more a "style sanity check" thing. --- - To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org
[GitHub] cassandra-dtest issue #6: 12148 style
Github user ptnapoleon commented on the issue: https://github.com/apache/cassandra-dtest/pull/6 I'm not yet familiar with pytest and I know nothing about CDC, but this all looks legitimate. +1 --- - To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org