[GitHub] cassandra pull request #253: 13630

2018-09-07 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/253#discussion_r216118578 --- Diff: src/java/org/apache/cassandra/net/MessageOut.java --- @@ -180,6 +199,73 @@ public String toString() return sbuf.toString();

[GitHub] cassandra pull request #253: 13630

2018-09-07 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/253#discussion_r216118489 --- Diff: src/java/org/apache/cassandra/net/async/ByteBufDataOutputStreamPlus.java --- @@ -196,10 +220,12 @@ protected void doFlush(int count) throws IO

[GitHub] cassandra pull request #262: Replicalayout followup

2018-09-07 Thread ifesdjeen
GitHub user ifesdjeen opened a pull request: https://github.com/apache/cassandra/pull/262 Replicalayout followup You can merge this pull request into a Git repository by running: $ git pull https://github.com/belliottsmith/cassandra replicalayout-followup Alternatively you ca

[GitHub] cassandra pull request #253: 13630

2018-09-07 Thread dineshjoshi
Github user dineshjoshi commented on a diff in the pull request: https://github.com/apache/cassandra/pull/253#discussion_r216088059 --- Diff: src/java/org/apache/cassandra/net/MessageIn.java --- @@ -231,4 +241,437 @@ public String toString() sbuf.append("FROM:").append(

[GitHub] cassandra pull request #253: 13630

2018-09-07 Thread dineshjoshi
Github user dineshjoshi commented on a diff in the pull request: https://github.com/apache/cassandra/pull/253#discussion_r216106193 --- Diff: src/java/org/apache/cassandra/net/MessageOut.java --- @@ -180,6 +199,73 @@ public String toString() return sbuf.toString();

[GitHub] cassandra pull request #253: 13630

2018-09-07 Thread dineshjoshi
Github user dineshjoshi commented on a diff in the pull request: https://github.com/apache/cassandra/pull/253#discussion_r216098891 --- Diff: src/java/org/apache/cassandra/net/async/ByteBufDataOutputStreamPlus.java --- @@ -196,10 +220,12 @@ protected void doFlush(int count) throws

[GitHub] cassandra pull request #253: 13630

2018-09-07 Thread dineshjoshi
Github user dineshjoshi commented on a diff in the pull request: https://github.com/apache/cassandra/pull/253#discussion_r216105848 --- Diff: src/java/org/apache/cassandra/net/MessageOut.java --- @@ -180,6 +199,73 @@ public String toString() return sbuf.toString();

[GitHub] cassandra pull request #253: 13630

2018-09-07 Thread dineshjoshi
Github user dineshjoshi commented on a diff in the pull request: https://github.com/apache/cassandra/pull/253#discussion_r216103691 --- Diff: src/java/org/apache/cassandra/net/async/MessageInHandler.java --- @@ -18,143 +18,296 @@ package org.apache.cassandra.net.async;

[GitHub] cassandra pull request #253: 13630

2018-09-07 Thread dineshjoshi
Github user dineshjoshi commented on a diff in the pull request: https://github.com/apache/cassandra/pull/253#discussion_r216106796 --- Diff: src/java/org/apache/cassandra/net/MessageOut.java --- @@ -180,6 +199,73 @@ public String toString() return sbuf.toString();

[GitHub] cassandra pull request #253: 13630

2018-09-07 Thread dineshjoshi
Github user dineshjoshi commented on a diff in the pull request: https://github.com/apache/cassandra/pull/253#discussion_r216102238 --- Diff: test/unit/org/apache/cassandra/net/MessageInProcessorPre40Test.java --- @@ -0,0 +1,115 @@ +/* + * Licensed to the Apache Software Fo

[GitHub] cassandra pull request #253: 13630

2018-09-07 Thread dineshjoshi
Github user dineshjoshi commented on a diff in the pull request: https://github.com/apache/cassandra/pull/253#discussion_r216087977 --- Diff: src/java/org/apache/cassandra/net/MessageIn.java --- @@ -231,4 +241,437 @@ public String toString() sbuf.append("FROM:").append(

[GitHub] cassandra pull request #253: 13630

2018-09-07 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/253#discussion_r216103837 --- Diff: src/java/org/apache/cassandra/streaming/async/NettyStreamingMessageSender.java --- @@ -393,6 +393,18 @@ private Channel getOrCreateChannel()

[GitHub] cassandra pull request #253: 13630

2018-09-07 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/253#discussion_r216103840 --- Diff: src/java/org/apache/cassandra/net/async/RebufferingByteBufDataInputPlus.java --- @@ -36,6 +37,11 @@ public class RebufferingByteBuf

[GitHub] cassandra pull request #253: 13630

2018-09-07 Thread dineshjoshi
Github user dineshjoshi commented on a diff in the pull request: https://github.com/apache/cassandra/pull/253#discussion_r216086521 --- Diff: src/java/org/apache/cassandra/net/async/RebufferingByteBufDataInputPlus.java --- @@ -36,6 +37,11 @@ public class RebufferingByteB

[GitHub] cassandra pull request #253: 13630

2018-09-07 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/253#discussion_r216069307 --- Diff: src/java/org/apache/cassandra/net/MessageIn.java --- @@ -231,4 +241,437 @@ public String toString() sbuf.append("FROM:").append(fr

[GitHub] cassandra issue #228: Add option to sanity check tombstones on reads/compact...

2018-09-07 Thread aweisberg
Github user aweisberg commented on the issue: https://github.com/apache/cassandra/pull/228 Believe this is no longer in use. --- - To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands,

[GitHub] cassandra pull request #228: Add option to sanity check tombstones on reads/...

2018-09-07 Thread aweisberg
Github user aweisberg closed the pull request at: https://github.com/apache/cassandra/pull/228 --- - To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org

[GitHub] cassandra pull request #258: DecayingEstimatedHistogramReservoir.EstimatedHi...

2018-09-07 Thread aweisberg
Github user aweisberg closed the pull request at: https://github.com/apache/cassandra/pull/258 --- - To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org

[GitHub] cassandra issue #258: DecayingEstimatedHistogramReservoir.EstimatedHistogram...

2018-09-07 Thread aweisberg
Github user aweisberg commented on the issue: https://github.com/apache/cassandra/pull/258 Committed as https://github.com/apache/cassandra/commit/8d443805f06e7abb25f768f6c800b7ae71bd4a41 --- - To unsubscribe, e-mai

[GitHub] cassandra issue #260: AbstractReplicaCollection equals and hash code should ...

2018-09-07 Thread aweisberg
Github user aweisberg commented on the issue: https://github.com/apache/cassandra/pull/260 Committed as https://github.com/apache/cassandra/commit/ab2faa8a48c0e97f309b0221b31e41d009f0f3b4 --- - To unsubscribe, e-mai

[GitHub] cassandra pull request #260: AbstractReplicaCollection equals and hash code ...

2018-09-07 Thread aweisberg
Github user aweisberg closed the pull request at: https://github.com/apache/cassandra/pull/260 --- - To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org

[GitHub] cassandra issue #257: Allow transient range owner to serve as repair coordin...

2018-09-07 Thread ifesdjeen
Github user ifesdjeen commented on the issue: https://github.com/apache/cassandra/pull/257 Heh, now I need to take a look as well) --- - To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional comm

[GitHub] cassandra pull request #253: 13630

2018-09-07 Thread dineshjoshi
Github user dineshjoshi commented on a diff in the pull request: https://github.com/apache/cassandra/pull/253#discussion_r216047177 --- Diff: src/java/org/apache/cassandra/net/async/MessageOutHandler.java --- @@ -140,8 +125,17 @@ public void write(ChannelHandlerContext ctx, Object o

[GitHub] cassandra issue #257: Allow transient range owner to serve as repair coordin...

2018-09-07 Thread bdeggleston
Github user bdeggleston commented on the issue: https://github.com/apache/cassandra/pull/257 @ifesdjeen did some further consolidation of the sync task class hierarchy [here](https://github.com/bdeggleston/cassandra/tree/alexp/tr-followup-1/review2). I'm not really opposed to doing th

[GitHub] cassandra pull request #261: Tr followup 4

2018-09-07 Thread ifesdjeen
GitHub user ifesdjeen opened a pull request: https://github.com/apache/cassandra/pull/261 Tr followup 4 cc @belliottsmith You can merge this pull request into a Git repository by running: $ git pull https://github.com/ifesdjeen/cassandra tr-followup-4 Alternatively you can re

[GitHub] cassandra pull request #253: 13630

2018-09-07 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/253#discussion_r215955652 --- Diff: src/java/org/apache/cassandra/net/async/RebufferingByteBufDataInputPlus.java --- @@ -183,6 +195,11 @@ public int available() throws EOFExcepti

[GitHub] cassandra pull request #253: 13630

2018-09-07 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/253#discussion_r215944830 --- Diff: src/java/org/apache/cassandra/net/async/RebufferingByteBufDataInputPlus.java --- @@ -183,6 +195,11 @@ public int available() throws EOFExcepti

[GitHub] cassandra pull request #253: 13630

2018-09-07 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/253#discussion_r215939675 --- Diff: src/java/org/apache/cassandra/net/async/RebufferingByteBufDataInputPlus.java --- @@ -36,6 +37,11 @@ public class RebufferingByteBuf

[GitHub] cassandra pull request #253: 13630

2018-09-07 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/253#discussion_r215936173 --- Diff: src/java/org/apache/cassandra/net/async/MessageOutHandler.java --- @@ -140,8 +125,17 @@ public void write(ChannelHandlerContext ctx, Object o,