[GitHub] [cassandra] bereng commented on pull request #570: CASSANDRA-13606 Improve handling of 2i initialization failures

2020-05-28 Thread GitBox
bereng commented on pull request #570: URL: https://github.com/apache/cassandra/pull/570#issuecomment-635762103 Lgtm. Wdyt? This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [cassandra] ekaterinadimitrova2 closed pull request #605: Cassandra 15234 3

2020-05-28 Thread GitBox
ekaterinadimitrova2 closed pull request #605: URL: https://github.com/apache/cassandra/pull/605 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [cassandra] ekaterinadimitrova2 opened a new pull request #605: Cassandra 15234 3

2020-05-28 Thread GitBox
ekaterinadimitrova2 opened a new pull request #605: URL: https://github.com/apache/cassandra/pull/605 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [cassandra] ekaterinadimitrova2 closed pull request #604: Cassandra 15234 3

2020-05-28 Thread GitBox
ekaterinadimitrova2 closed pull request #604: URL: https://github.com/apache/cassandra/pull/604 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [cassandra] ekaterinadimitrova2 opened a new pull request #604: Cassandra 15234 3

2020-05-28 Thread GitBox
ekaterinadimitrova2 opened a new pull request #604: URL: https://github.com/apache/cassandra/pull/604 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [cassandra] adelapena commented on pull request #570: CASSANDRA-13606 Improve handling of 2i initialization failures

2020-05-28 Thread GitBox
adelapena commented on pull request #570: URL: https://github.com/apache/cassandra/pull/570#issuecomment-635442414 Cassandra CI re-running [utests](https://ci-cassandra.apache.org/view/all/job/Cassandra-devbranch-test/112/) and [dtests](https://ci-cassandra.apache.org/view/all/job/Cassand

[GitHub] [cassandra] bereng closed pull request #596: CASSANDRA-15819 Nodetool enablefullquerylog blocking param parsing fix

2020-05-28 Thread GitBox
bereng closed pull request #596: URL: https://github.com/apache/cassandra/pull/596 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [cassandra] bereng closed pull request #559: CASSANDRA-13666 Avoid rendering static 2i entries as stales and removing them

2020-05-28 Thread GitBox
bereng closed pull request #559: URL: https://github.com/apache/cassandra/pull/559 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [cassandra] bereng closed pull request #565: 13666 4.0

2020-05-28 Thread GitBox
bereng closed pull request #565: URL: https://github.com/apache/cassandra/pull/565 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [cassandra] bereng closed pull request #564: 13666 3.11

2020-05-28 Thread GitBox
bereng closed pull request #564: URL: https://github.com/apache/cassandra/pull/564 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [cassandra] blerer commented on a change in pull request #602: CASSANDRA-15825 Flaky test fix. Avoid compactions under our feet.

2020-05-28 Thread GitBox
blerer commented on a change in pull request #602: URL: https://github.com/apache/cassandra/pull/602#discussion_r431866018 ## File path: test/unit/org/apache/cassandra/db/streaming/CassandraStreamManagerTest.java ## @@ -161,6 +161,9 @@ private static void mutateRepaired(SSTabl

[GitHub] [cassandra] jasonstack commented on a change in pull request #586: Cassandra 15665 trunk 15666

2020-05-28 Thread GitBox
jasonstack commented on a change in pull request #586: URL: https://github.com/apache/cassandra/pull/586#discussion_r431897689 ## File path: src/java/org/apache/cassandra/streaming/messages/StreamMessageHeader.java ## @@ -32,14 +34,16 @@ import static org.apache.cassandra.lo

[GitHub] [cassandra] jasonstack commented on pull request #586: Cassandra 15665 trunk 15666

2020-05-28 Thread GitBox
jasonstack commented on pull request #586: URL: https://github.com/apache/cassandra/pull/586#issuecomment-635397876 rebased and applied review feedback. CI Running: https://circleci.com/workflow-run/947320b4-3c52-4113-91ab-36d622a45e23 -

[GitHub] [cassandra] jasonstack commented on a change in pull request #586: Cassandra 15665 trunk 15666

2020-05-28 Thread GitBox
jasonstack commented on a change in pull request #586: URL: https://github.com/apache/cassandra/pull/586#discussion_r431891202 ## File path: src/java/org/apache/cassandra/streaming/StreamManager.java ## @@ -176,17 +176,10 @@ public void removeNotificationListener(NotificationL

[GitHub] [cassandra] smiklosovic closed pull request #566: CASSANDRA-15759 - added progress_in_percents column for virtual table sstable_tasks

2020-05-28 Thread GitBox
smiklosovic closed pull request #566: URL: https://github.com/apache/cassandra/pull/566 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [cassandra] jasonstack commented on a change in pull request #586: Cassandra 15665 trunk 15666

2020-05-28 Thread GitBox
jasonstack commented on a change in pull request #586: URL: https://github.com/apache/cassandra/pull/586#discussion_r431886313 ## File path: src/java/org/apache/cassandra/streaming/async/StreamingInboundHandler.java ## @@ -232,24 +225,9 @@ else if (t instanceof StreamReceiveEx

[GitHub] [cassandra] jasonstack commented on a change in pull request #586: Cassandra 15665 trunk 15666

2020-05-28 Thread GitBox
jasonstack commented on a change in pull request #586: URL: https://github.com/apache/cassandra/pull/586#discussion_r431882843 ## File path: src/java/org/apache/cassandra/streaming/async/StreamingInboundHandler.java ## @@ -232,24 +225,9 @@ else if (t instanceof StreamReceiveEx

[GitHub] [cassandra] bereng commented on pull request #570: CASSANDRA-13606 Improve handling of 2i initialization failures

2020-05-28 Thread GitBox
bereng commented on pull request #570: URL: https://github.com/apache/cassandra/pull/570#issuecomment-635379425 @adelapena circle CI is on a partial outage and it fails on dtests env set up etc. If you fancy firing one in cassandra ci good, otherwise I'll try to get CI runs again tomorrow

[GitHub] [cassandra] jasonstack commented on a change in pull request #586: Cassandra 15665 trunk 15666

2020-05-28 Thread GitBox
jasonstack commented on a change in pull request #586: URL: https://github.com/apache/cassandra/pull/586#discussion_r431865566 ## File path: src/java/org/apache/cassandra/streaming/async/StreamingInboundHandler.java ## @@ -40,15 +39,12 @@ import io.netty.util.concurrent.FastT

[GitHub] [cassandra] blerer commented on a change in pull request #586: Cassandra 15665 trunk 15666

2020-05-28 Thread GitBox
blerer commented on a change in pull request #586: URL: https://github.com/apache/cassandra/pull/586#discussion_r431792772 ## File path: src/java/org/apache/cassandra/streaming/async/StreamingInboundHandler.java ## @@ -232,24 +225,9 @@ else if (t instanceof StreamReceiveExcept