[GitHub] cassandra pull request #224: 14405 replicas

2018-06-27 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r198604608 --- Diff: src/java/org/apache/cassandra/service/StorageProxy.java --- @@ -78,7 +78,6 @@ import

[GitHub] cassandra pull request #224: 14405 replicas

2018-06-27 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r198592967 --- Diff: src/java/org/apache/cassandra/locator/OldNetworkTopologyStrategy.java --- @@ -36,27 +36,30 @@ */ public class

[GitHub] cassandra pull request #224: 14405 replicas

2018-06-26 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r198265430 --- Diff: src/java/org/apache/cassandra/locator/Replicas.java --- @@ -50,6 +50,30 @@ public abstract int size(); protected abstract

[GitHub] cassandra pull request #224: 14405 replicas

2018-06-26 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r198251878 --- Diff: src/java/org/apache/cassandra/locator/Replicas.java --- @@ -50,6 +50,30 @@ public abstract int size(); protected abstract

[GitHub] cassandra pull request #224: 14405 replicas

2018-06-26 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r198213823 --- Diff: src/java/org/apache/cassandra/locator/Replicas.java --- @@ -50,6 +50,30 @@ public abstract int size(); protected abstract

[GitHub] cassandra pull request #224: 14405 replicas

2018-06-21 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r197156422 --- Diff: src/java/org/apache/cassandra/service/StorageService.java --- @@ -4231,53 +4211,53 @@ private void calculateToFromStreams(Collection

[GitHub] cassandra pull request #224: 14405 replicas

2018-06-21 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r197124802 --- Diff: src/java/org/apache/cassandra/db/ConsistencyLevel.java --- @@ -148,40 +150,45 @@ public boolean isLocal(InetAddressAndPort endpoint)

[GitHub] cassandra pull request #224: 14405 replicas

2018-06-21 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r197136141 --- Diff: src/java/org/apache/cassandra/service/StorageService.java --- @@ -4231,53 +4211,53 @@ private void calculateToFromStreams(Collection

[GitHub] cassandra pull request #224: 14405 replicas

2018-06-21 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r197131513 --- Diff: src/java/org/apache/cassandra/locator/ReplicationFactor.java --- @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] cassandra pull request #224: 14405 replicas

2018-06-21 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r197129915 --- Diff: src/java/org/apache/cassandra/locator/NetworkTopologyStrategy.java --- @@ -90,41 +98,53 @@ public NetworkTopologyStrategy(String

[GitHub] cassandra pull request #224: 14405 replicas

2018-06-21 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r197126709 --- Diff: src/java/org/apache/cassandra/dht/RangeStreamer.java --- @@ -259,36 +266,36 @@ private boolean useStrictSourcesForRanges(String keyspaceName)

[GitHub] cassandra pull request #224: 14405 replicas

2018-06-21 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r197125691 --- Diff: src/java/org/apache/cassandra/db/ConsistencyLevel.java --- @@ -190,50 +197,50 @@ public int countLocalEndpoints(Iterable liveEndpoints)

[GitHub] cassandra pull request #224: 14405 replicas

2018-06-21 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r197154559 --- Diff: src/java/org/apache/cassandra/locator/AbstractReplicationStrategy.java --- @@ -202,61 +204,65 @@ private Keyspace getKeyspace() *

[GitHub] cassandra pull request #224: 14405 replicas

2018-06-21 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r197125767 --- Diff: src/java/org/apache/cassandra/db/ConsistencyLevel.java --- @@ -190,50 +197,50 @@ public int countLocalEndpoints(Iterable liveEndpoints)

[GitHub] cassandra pull request #224: 14405 replicas

2018-06-21 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r197130296 --- Diff: src/java/org/apache/cassandra/locator/ReplicaList.java --- @@ -0,0 +1,270 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] cassandra pull request #224: 14405 replicas

2018-06-21 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r197130790 --- Diff: src/java/org/apache/cassandra/locator/ReplicaList.java --- @@ -0,0 +1,270 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] cassandra pull request #224: 14405 replicas

2018-06-21 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r197133241 --- Diff: src/java/org/apache/cassandra/service/StorageProxy.java --- @@ -344,47 +343,43 @@ private static void recordCasContention(int contentions)

[GitHub] cassandra pull request #224: 14405 replicas

2018-06-21 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r197149200 --- Diff: src/java/org/apache/cassandra/service/StorageProxy.java --- @@ -1275,36 +1272,38 @@ private static WriteResponseHandlerWrapper

[GitHub] cassandra pull request #224: 14405 replicas

2018-06-21 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r197159962 --- Diff: src/java/org/apache/cassandra/locator/ReplicaList.java --- @@ -0,0 +1,270 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] cassandra pull request #224: 14405 replicas

2018-06-21 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r197136522 --- Diff: src/java/org/apache/cassandra/service/StorageService.java --- @@ -4231,53 +4211,53 @@ private void calculateToFromStreams(Collection

[GitHub] cassandra pull request #224: 14405 replicas

2018-06-21 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r197128495 --- Diff: src/java/org/apache/cassandra/locator/AbstractReplicationStrategy.java --- @@ -329,6 +335,10 @@ public static void

[GitHub] cassandra pull request #224: 14405 replicas

2018-06-21 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r197129440 --- Diff: src/java/org/apache/cassandra/locator/NetworkTopologyStrategy.java --- @@ -90,41 +98,53 @@ public NetworkTopologyStrategy(String

[GitHub] cassandra pull request #224: 14405 replicas

2018-06-21 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r197126256 --- Diff: src/java/org/apache/cassandra/db/ConsistencyLevel.java --- @@ -242,11 +249,11 @@ public boolean isSufficientLiveNodes(Keyspace keyspace,

[GitHub] cassandra pull request #224: 14405 replicas

2018-06-21 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r197156136 --- Diff: src/java/org/apache/cassandra/service/StorageService.java --- @@ -4231,53 +4211,53 @@ private void calculateToFromStreams(Collection

[GitHub] cassandra pull request #224: 14405 replicas

2018-06-21 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r197156892 --- Diff: src/java/org/apache/cassandra/locator/TokenMetadata.java --- @@ -733,19 +733,19 @@ public InetAddressAndPort getEndpoint(Token token)

[GitHub] cassandra pull request #224: 14405 replicas

2018-06-21 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r197131214 --- Diff: src/java/org/apache/cassandra/locator/ReplicationFactor.java --- @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] cassandra pull request #224: 14405 replicas

2018-06-21 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r197161771 --- Diff: test/microbench/org/apache/cassandra/test/microbench/PendingRangesBench.java --- @@ -97,13 +103,13 @@ public void

[GitHub] cassandra pull request #224: 14405 replicas

2018-06-21 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r197153506 --- Diff: src/java/org/apache/cassandra/db/view/ViewUtils.java --- @@ -58,46 +57,55 @@ private ViewUtils() * * @return

[GitHub] cassandra pull request #224: 14405 replicas

2018-06-21 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r197132925 --- Diff: src/java/org/apache/cassandra/service/StorageProxy.java --- @@ -344,47 +343,43 @@ private static void recordCasContention(int contentions)

[GitHub] cassandra pull request #224: 14405 replicas

2018-06-15 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r195811425 --- Diff: src/java/org/apache/cassandra/locator/Replicas.java --- @@ -50,6 +50,30 @@ public abstract int size(); protected abstract

[GitHub] cassandra pull request #224: 14405 replicas

2018-06-14 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r195479970 --- Diff: src/java/org/apache/cassandra/locator/Replicas.java --- @@ -50,6 +50,30 @@ public abstract int size(); protected abstract

[GitHub] cassandra pull request #224: 14405 replicas

2018-06-12 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r194812259 --- Diff: src/java/org/apache/cassandra/locator/PendingRangeMaps.java --- @@ -23,196 +23,176 @@ import com.google.common.collect.Iterators;

[GitHub] cassandra pull request #224: 14405 replicas

2018-06-12 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r194793488 --- Diff: src/java/org/apache/cassandra/service/reads/AbstractReadExecutor.java --- @@ -344,17 +351,18 @@ public void maybeTryAdditionalReplicas()

[GitHub] cassandra pull request #224: 14405 replicas

2018-06-12 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r194793501 --- Diff: src/java/org/apache/cassandra/service/reads/AbstractReadExecutor.java --- @@ -269,24 +272,26 @@ public void executeAsync() {

[GitHub] cassandra pull request #224: 14405 replicas

2018-06-12 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r194793477 --- Diff: src/java/org/apache/cassandra/service/reads/AbstractReadExecutor.java --- @@ -269,24 +272,26 @@ public void executeAsync() {

[GitHub] cassandra pull request #224: 14405 replicas

2018-06-11 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r194581559 --- Diff: test/unit/org/apache/cassandra/locator/NetworkTopologyStrategyTest.java --- @@ -36,12 +37,17 @@ import

[GitHub] cassandra pull request #224: 14405 replicas

2018-06-11 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r194581551 --- Diff: src/java/org/apache/cassandra/locator/ReplicaList.java --- @@ -0,0 +1,283 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-18 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189397458 --- Diff: src/java/org/apache/cassandra/locator/PendingRangeMaps.java --- @@ -23,196 +23,176 @@ import com.google.common.collect.Iterators;

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-18 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189397262 --- Diff: src/java/org/apache/cassandra/locator/Replica.java --- @@ -0,0 +1,221 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-18 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189394058 --- Diff: src/java/org/apache/cassandra/locator/PendingRangeMaps.java --- @@ -23,196 +23,176 @@ import com.google.common.collect.Iterators;

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-18 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189392952 --- Diff: src/java/org/apache/cassandra/dht/RangeFetchMapCalculator.java --- @@ -347,15 +349,16 @@ else if (vertex.isRangeVertex()) private

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-17 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189119609 --- Diff: src/java/org/apache/cassandra/service/reads/DataResolver.java --- @@ -64,12 +72,19 @@ public PartitionIterator resolve() // at

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-17 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189116984 --- Diff: src/java/org/apache/cassandra/locator/Replicas.java --- @@ -0,0 +1,313 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-17 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189117046 --- Diff: src/java/org/apache/cassandra/service/WriteResponseHandler.java --- @@ -42,26 +44,26 @@ private static final

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-17 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189117060 --- Diff: src/java/org/apache/cassandra/service/reads/DataResolver.java --- @@ -30,21 +36,23 @@ import

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-17 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189117008 --- Diff: src/java/org/apache/cassandra/service/StorageProxy.java --- @@ -541,12 +536,12 @@ public void run() return callback; }

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-17 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189117019 --- Diff: src/java/org/apache/cassandra/locator/ReplicaList.java --- @@ -0,0 +1,244 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-17 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189116992 --- Diff: src/java/org/apache/cassandra/locator/Replicas.java --- @@ -0,0 +1,313 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-17 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189116971 --- Diff: src/java/org/apache/cassandra/locator/ReplicaList.java --- @@ -0,0 +1,244 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-17 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189117042 --- Diff: src/java/org/apache/cassandra/service/StorageService.java --- @@ -3845,16 +3852,9 @@ public void forceTerminateAllRepairSessions()

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-17 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189117005 --- Diff: src/java/org/apache/cassandra/service/StorageProxy.java --- @@ -503,12 +498,12 @@ private static void sendCommit(Commit commit, Iterable

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-17 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189117001 --- Diff: src/java/org/apache/cassandra/locator/TokenMetadata.java --- @@ -1204,21 +1205,21 @@ private String printPendingRanges() return

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-17 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189109427 --- Diff: src/java/org/apache/cassandra/service/AbstractWriteResponseHandler.java --- @@ -225,7 +223,7 @@ protected boolean

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-17 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189108331 --- Diff: src/java/org/apache/cassandra/net/MessagingService.java --- @@ -591,8 +592,9 @@ public void run() if

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-17 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189092456 --- Diff: src/java/org/apache/cassandra/locator/ReplicaMultimap.java --- @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-17 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189092476 --- Diff: src/java/org/apache/cassandra/locator/ReplicaSet.java --- @@ -0,0 +1,142 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-17 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189092447 --- Diff: src/java/org/apache/cassandra/locator/ReplicaList.java --- @@ -0,0 +1,244 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-17 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189092419 --- Diff: src/java/org/apache/cassandra/locator/ReplicaList.java --- @@ -0,0 +1,244 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-17 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189092468 --- Diff: src/java/org/apache/cassandra/locator/ReplicaSet.java --- @@ -0,0 +1,142 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-17 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189092440 --- Diff: src/java/org/apache/cassandra/locator/ReplicaList.java --- @@ -0,0 +1,244 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-17 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189091639 --- Diff: src/java/org/apache/cassandra/locator/Replica.java --- @@ -0,0 +1,221 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-17 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189091647 --- Diff: src/java/org/apache/cassandra/locator/Replica.java --- @@ -0,0 +1,221 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-17 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189091637 --- Diff: src/java/org/apache/cassandra/locator/Replica.java --- @@ -0,0 +1,221 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-17 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189091280 --- Diff: src/java/org/apache/cassandra/locator/AbstractReplicationStrategy.java --- @@ -202,61 +204,63 @@ private Keyspace getKeyspace() *

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-17 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189091069 --- Diff: src/java/org/apache/cassandra/db/ConsistencyLevel.java --- @@ -190,50 +197,50 @@ public int countLocalEndpoints(Iterable liveEndpoints)

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-17 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189049318 --- Diff: src/java/org/apache/cassandra/locator/Replica.java --- @@ -0,0 +1,221 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-17 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189038875 --- Diff: src/java/org/apache/cassandra/db/compaction/CompactionManager.java --- @@ -871,7 +868,7 @@ public void forceUserDefinedCleanup(String

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-17 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189038308 --- Diff: src/java/org/apache/cassandra/db/ColumnFamilyStore.java --- @@ -1591,7 +1589,7 @@ public long getExpectedCompactedFileSize(Iterable

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-17 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189038385 --- Diff: src/java/org/apache/cassandra/db/ColumnFamilyStore.java --- @@ -1868,7 +1866,7 @@ public void compactionDiskSpaceCheck(boolean enable)

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-16 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r188786670 --- Diff: src/java/org/apache/cassandra/cql3/statements/AlterKeyspaceStatement.java --- @@ -96,7 +98,35 @@ private void

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-16 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r188785532 --- Diff: src/java/org/apache/cassandra/cql3/statements/AlterKeyspaceStatement.java --- @@ -96,7 +98,35 @@ private void

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-16 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r188785202 --- Diff: src/java/org/apache/cassandra/cql3/statements/AlterKeyspaceStatement.java --- @@ -96,7 +98,35 @@ private void

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-16 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r188784654 --- Diff: src/java/org/apache/cassandra/cql3/statements/AlterKeyspaceStatement.java --- @@ -96,7 +98,35 @@ private void

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-16 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r188783933 --- Diff: src/java/org/apache/cassandra/cql3/statements/AlterKeyspaceStatement.java --- @@ -96,7 +98,35 @@ private void

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-16 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r188770805 --- Diff: doc/source/architecture/dynamo.rst --- @@ -74,6 +74,26 @@ nodes in each rack, the data load on the smallest rack may be much higher. Simi

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-16 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r188758082 --- Diff: test/unit/org/apache/cassandra/locator/NetworkTopologyStrategyTest.java --- @@ -36,12 +37,17 @@ import

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-16 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r188747102 --- Diff: src/java/org/apache/cassandra/locator/PendingRangeMaps.java --- @@ -23,196 +23,176 @@ import com.google.common.collect.Iterators;

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-16 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r188746162 --- Diff: src/java/org/apache/cassandra/locator/TokenMetadata.java --- @@ -904,38 +905,38 @@ private static PendingRangeMaps

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-16 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r188451194 --- Diff: src/java/org/apache/cassandra/service/StorageProxy.java --- @@ -1098,7 +1095,7 @@ private static void asyncRemoveFromBatchlog(Collection

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-16 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r188107704 --- Diff: src/java/org/apache/cassandra/locator/Replica.java --- @@ -0,0 +1,221 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-16 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r188436562 --- Diff: src/java/org/apache/cassandra/locator/TokenMetadata.java --- @@ -1204,21 +1205,21 @@ private String printPendingRanges() return

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-16 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r188452249 --- Diff: src/java/org/apache/cassandra/service/StorageProxy.java --- @@ -1364,68 +1363,72 @@ public static void sendToHintedEndpoints(final Mutation

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-16 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r188686055 --- Diff: src/java/org/apache/cassandra/service/StorageService.java --- @@ -3863,17 +3863,12 @@ public void forceTerminateAllRepairSessions()

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-16 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r188443108 --- Diff: src/java/org/apache/cassandra/service/AbstractWriteResponseHandler.java --- @@ -225,7 +223,7 @@ protected boolean

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-16 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r188352903 --- Diff: src/java/org/apache/cassandra/locator/Replicas.java --- @@ -0,0 +1,313 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-16 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r188116936 --- Diff: src/java/org/apache/cassandra/locator/Replica.java --- @@ -0,0 +1,221 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-16 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r188102629 --- Diff: src/java/org/apache/cassandra/locator/Replica.java --- @@ -0,0 +1,221 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-16 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r188110522 --- Diff: src/java/org/apache/cassandra/locator/ReplicaList.java --- @@ -0,0 +1,244 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-16 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r187710293 --- Diff: src/java/org/apache/cassandra/locator/Replicas.java --- @@ -0,0 +1,313 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-16 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r188435314 --- Diff: src/java/org/apache/cassandra/locator/TokenMetadata.java --- @@ -856,25 +857,25 @@ private static PendingRangeMaps

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-16 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r187442479 --- Diff: src/java/org/apache/cassandra/service/reads/DataResolver.java --- @@ -64,12 +72,19 @@ public PartitionIterator resolve() // at

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-16 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r188107218 --- Diff: src/java/org/apache/cassandra/locator/Replica.java --- @@ -0,0 +1,221 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-16 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r188361596 --- Diff: src/java/org/apache/cassandra/locator/Replicas.java --- @@ -0,0 +1,313 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-16 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r187672097 --- Diff: src/java/org/apache/cassandra/dht/RangeFetchMapCalculator.java --- @@ -347,15 +349,16 @@ else if (vertex.isRangeVertex()) private

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-16 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r187474479 --- Diff: src/java/org/apache/cassandra/db/ReadCommand.java --- @@ -128,6 +130,7 @@ protected ReadCommand(Kind kind, protected abstract

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-10 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r187383690 --- Diff: doc/source/architecture/dynamo.rst --- @@ -74,6 +74,26 @@ nodes in each rack, the data load on the smallest rack may be much higher. Simi

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-10 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r187383489 --- Diff: doc/source/architecture/dynamo.rst --- @@ -74,6 +74,26 @@ nodes in each rack, the data load on the smallest rack may be much higher. Simi

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-09 Thread bdeggleston
GitHub user bdeggleston opened a pull request: https://github.com/apache/cassandra/pull/224 14405 replicas You can merge this pull request into a Git repository by running: $ git pull https://github.com/bdeggleston/cassandra 14405-replicas Alternatively you can review and