[GitHub] cassandra pull request #236: 9608 trunk

2018-07-26 Thread jasobrown
Github user jasobrown closed the pull request at: https://github.com/apache/cassandra/pull/236 --- - To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org

[GitHub] cassandra pull request #236: 9608 trunk

2018-07-23 Thread snazy
Github user snazy commented on a diff in the pull request: https://github.com/apache/cassandra/pull/236#discussion_r204382546 --- Diff: src/java/org/apache/cassandra/io/util/FileUtils.java --- @@ -350,13 +396,38 @@ public static String getRelativePath(String basePath, String path)

[GitHub] cassandra pull request #236: 9608 trunk

2018-07-23 Thread snazy
Github user snazy commented on a diff in the pull request: https://github.com/apache/cassandra/pull/236#discussion_r204381413 --- Diff: src/java/org/apache/cassandra/io/util/FileUtils.java --- @@ -64,24 +68,31 @@ public static final long ONE_TB = 1024 * ONE_GB;

[GitHub] cassandra pull request #236: 9608 trunk

2018-07-23 Thread snazy
Github user snazy commented on a diff in the pull request: https://github.com/apache/cassandra/pull/236#discussion_r204380974 --- Diff: build.xml --- @@ -1665,7 +1763,7 @@ - + --- End diff -- Oops, re-added ---

[GitHub] cassandra pull request #236: 9608 trunk

2018-07-23 Thread snazy
Github user snazy commented on a diff in the pull request: https://github.com/apache/cassandra/pull/236#discussion_r204380932 --- Diff: src/java/org/apache/cassandra/cql3/functions/JavaBasedUDFunction.java --- @@ -591,14 +592,17 @@ private NameEnvironmentAnswer findType(String

[GitHub] cassandra pull request #236: 9608 trunk

2018-07-23 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/236#discussion_r204370957 --- Diff: src/java/org/apache/cassandra/io/util/FileUtils.java --- @@ -350,13 +396,38 @@ public static String getRelativePath(String basePath, String

[GitHub] cassandra pull request #236: 9608 trunk

2018-07-23 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/236#discussion_r204355461 --- Diff: build.xml --- @@ -66,8 +67,14 @@ - - +

[GitHub] cassandra pull request #236: 9608 trunk

2018-07-23 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/236#discussion_r204369082 --- Diff: src/java/org/apache/cassandra/io/util/FileUtils.java --- @@ -106,11 +117,46 @@ public static void createHardLink(File from, File to)

[GitHub] cassandra pull request #236: 9608 trunk

2018-07-23 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/236#discussion_r204368353 --- Diff: src/java/org/apache/cassandra/io/util/FileUtils.java --- @@ -64,24 +68,31 @@ public static final long ONE_TB = 1024 * ONE_GB;

[GitHub] cassandra pull request #236: 9608 trunk

2018-07-23 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/236#discussion_r204369509 --- Diff: src/java/org/apache/cassandra/io/util/FileUtils.java --- @@ -350,13 +396,38 @@ public static String getRelativePath(String basePath, String

[GitHub] cassandra pull request #236: 9608 trunk

2018-07-02 Thread snazy
Github user snazy commented on a diff in the pull request: https://github.com/apache/cassandra/pull/236#discussion_r199440838 --- Diff: build.xml --- @@ -110,16 +118,35 @@ - + + + + + +

[GitHub] cassandra pull request #236: 9608 trunk

2018-07-02 Thread snazy
Github user snazy commented on a diff in the pull request: https://github.com/apache/cassandra/pull/236#discussion_r199440796 --- Diff: src/java/org/apache/cassandra/io/util/FileUtils.java --- @@ -67,23 +71,84 @@ public static final boolean isCleanerAvailable;

[GitHub] cassandra pull request #236: 9608 trunk

2018-07-02 Thread snazy
Github user snazy commented on a diff in the pull request: https://github.com/apache/cassandra/pull/236#discussion_r199440835 --- Diff: build.xml --- @@ -462,7 +501,9 @@ - + --- End diff --

[GitHub] cassandra pull request #236: 9608 trunk

2018-07-02 Thread snazy
Github user snazy commented on a diff in the pull request: https://github.com/apache/cassandra/pull/236#discussion_r199440825 --- Diff: build.xml --- @@ -703,6 +744,13 @@ + + --- End diff -- Otherwise an older asm

[GitHub] cassandra pull request #236: 9608 trunk

2018-07-02 Thread snazy
Github user snazy commented on a diff in the pull request: https://github.com/apache/cassandra/pull/236#discussion_r199440779 --- Diff: src/java/org/apache/cassandra/cql3/functions/JavaBasedUDFunction.java --- @@ -591,14 +612,48 @@ private NameEnvironmentAnswer findType(String

[GitHub] cassandra pull request #236: 9608 trunk

2018-07-02 Thread snazy
Github user snazy commented on a diff in the pull request: https://github.com/apache/cassandra/pull/236#discussion_r199440701 --- Diff: src/java/org/apache/cassandra/io/util/FileUtils.java --- @@ -106,11 +171,57 @@ public static void createHardLink(File from, File to)

[GitHub] cassandra pull request #236: 9608 trunk

2018-07-02 Thread snazy
Github user snazy commented on a diff in the pull request: https://github.com/apache/cassandra/pull/236#discussion_r199440821 --- Diff: conf/jvm11.options --- @@ -0,0 +1,89 @@ +### +#

[GitHub] cassandra pull request #236: 9608 trunk

2018-07-02 Thread snazy
Github user snazy commented on a diff in the pull request: https://github.com/apache/cassandra/pull/236#discussion_r199440783 --- Diff: src/java/org/apache/cassandra/utils/NativeLibrary.java --- @@ -78,7 +77,14 @@ static { FILE_DESCRIPTOR_FD_FIELD =

[GitHub] cassandra pull request #236: 9608 trunk

2018-07-02 Thread snazy
Github user snazy commented on a diff in the pull request: https://github.com/apache/cassandra/pull/236#discussion_r199440768 --- Diff: src/java/org/apache/cassandra/io/util/FileUtils.java --- @@ -67,23 +71,84 @@ public static final boolean isCleanerAvailable;

[GitHub] cassandra pull request #236: 9608 trunk

2018-07-02 Thread snazy
Github user snazy commented on a diff in the pull request: https://github.com/apache/cassandra/pull/236#discussion_r199440790 --- Diff: src/java/org/apache/cassandra/security/ThreadAwareSecurityManager.java --- @@ -208,7 +225,5 @@ public void checkPackageAccess(String pkg)

[GitHub] cassandra pull request #236: 9608 trunk

2018-07-02 Thread snazy
Github user snazy commented on a diff in the pull request: https://github.com/apache/cassandra/pull/236#discussion_r199440755 --- Diff: src/java/org/apache/cassandra/io/util/FileUtils.java --- @@ -67,23 +71,84 @@ public static final boolean isCleanerAvailable;

[GitHub] cassandra pull request #236: 9608 trunk

2018-06-30 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/236#discussion_r199330506 --- Diff: src/java/org/apache/cassandra/io/util/FileUtils.java --- @@ -67,23 +71,84 @@ public static final boolean isCleanerAvailable;

[GitHub] cassandra pull request #236: 9608 trunk

2018-06-30 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/236#discussion_r199330666 --- Diff: src/java/org/apache/cassandra/io/util/FileUtils.java --- @@ -67,23 +71,84 @@ public static final boolean isCleanerAvailable;

[GitHub] cassandra pull request #236: 9608 trunk

2018-06-30 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/236#discussion_r199331081 --- Diff: src/java/org/apache/cassandra/io/util/FileUtils.java --- @@ -106,11 +171,57 @@ public static void createHardLink(File from, File to)

[GitHub] cassandra pull request #236: 9608 trunk

2018-06-29 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/236#discussion_r199260315 --- Diff: src/java/org/apache/cassandra/security/ThreadAwareSecurityManager.java --- @@ -208,7 +225,5 @@ public void checkPackageAccess(String pkg)

[GitHub] cassandra pull request #236: 9608 trunk

2018-06-29 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/236#discussion_r199260807 --- Diff: src/java/org/apache/cassandra/utils/NativeLibrary.java --- @@ -78,7 +77,14 @@ static { FILE_DESCRIPTOR_FD_FIELD

[GitHub] cassandra pull request #236: 9608 trunk

2018-06-29 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/236#discussion_r199259098 --- Diff: src/java/org/apache/cassandra/io/util/FileUtils.java --- @@ -67,23 +71,84 @@ public static final boolean isCleanerAvailable;

[GitHub] cassandra pull request #236: 9608 trunk

2018-06-29 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/236#discussion_r195913415 --- Diff: build.xml --- @@ -462,7 +501,9 @@ - + --- End diff --

[GitHub] cassandra pull request #236: 9608 trunk

2018-06-29 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/236#discussion_r195913343 --- Diff: build.xml --- @@ -110,16 +118,35 @@ - + + + + + +

[GitHub] cassandra pull request #236: 9608 trunk

2018-06-29 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/236#discussion_r199253772 --- Diff: conf/jvm11.options --- @@ -0,0 +1,89 @@ +### +#

[GitHub] cassandra pull request #236: 9608 trunk

2018-06-29 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/236#discussion_r195913429 --- Diff: build.xml --- @@ -703,6 +744,13 @@ + + --- End diff -- why do you need to

[GitHub] cassandra pull request #236: 9608 trunk

2018-06-16 Thread jasobrown
GitHub user jasobrown opened a pull request: https://github.com/apache/cassandra/pull/236 9608 trunk You can merge this pull request into a Git repository by running: $ git pull https://github.com/snazy/cassandra 9608-trunk Alternatively you can review and apply these