[GitHub] cassandra pull request #224: 14405 replicas

2018-05-17 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189038385 --- Diff: src/java/org/apache/cassandra/db/ColumnFamilyStore.java --- @@ -1868,7 +1866,7 @@ public void compactionDiskSpaceCheck(boolean enable)

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-17 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189038308 --- Diff: src/java/org/apache/cassandra/db/ColumnFamilyStore.java --- @@ -1591,7 +1589,7 @@ public long getExpectedCompactedFileSize(Iterable

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-17 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189039085 --- Diff: src/java/org/apache/cassandra/db/view/ViewBuilder.java --- @@ -135,14 +137,15 @@ private synchronized void build() }

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-17 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189039639 --- Diff: src/java/org/apache/cassandra/locator/TokenMetadata.java --- @@ -856,25 +857,25 @@ private static PendingRangeMaps

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-17 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189038708 --- Diff: src/java/org/apache/cassandra/db/compaction/CompactionManager.java --- @@ -468,7 +465,7 @@ public AllSSTableOpStatus performCleanup(final

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-17 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189038958 --- Diff: src/java/org/apache/cassandra/db/compaction/Verifier.java --- @@ -209,7 +208,9 @@ public void verify()

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-17 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189038875 --- Diff: src/java/org/apache/cassandra/db/compaction/CompactionManager.java --- @@ -871,7 +868,7 @@ public void forceUserDefinedCleanup(String

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-17 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189038759 --- Diff: src/java/org/apache/cassandra/db/compaction/CompactionManager.java --- @@ -533,7 +530,7 @@ public AllSSTableOpStatus relocateSSTables(final

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-17 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189049318 --- Diff: src/java/org/apache/cassandra/locator/Replica.java --- @@ -0,0 +1,221 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-17 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189030217 --- Diff: src/java/org/apache/cassandra/locator/ReplicationFactor.java --- @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache Software

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-17 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189091637 --- Diff: src/java/org/apache/cassandra/locator/Replica.java --- @@ -0,0 +1,221 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-17 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189091280 --- Diff: src/java/org/apache/cassandra/locator/AbstractReplicationStrategy.java --- @@ -202,61 +204,63 @@ private Keyspace getKeyspace() *

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-17 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189091069 --- Diff: src/java/org/apache/cassandra/db/ConsistencyLevel.java --- @@ -190,50 +197,50 @@ public int countLocalEndpoints(Iterable liveEndpoints)

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-17 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189091062 --- Diff: src/java/org/apache/cassandra/db/ConsistencyLevel.java --- @@ -190,50 +197,50 @@ public int countLocalEndpoints(Iterable liveEndpoints)

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-17 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189092476 --- Diff: src/java/org/apache/cassandra/locator/ReplicaSet.java --- @@ -0,0 +1,142 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-17 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189092447 --- Diff: src/java/org/apache/cassandra/locator/ReplicaList.java --- @@ -0,0 +1,244 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-17 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189092456 --- Diff: src/java/org/apache/cassandra/locator/ReplicaMultimap.java --- @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-17 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189108331 --- Diff: src/java/org/apache/cassandra/net/MessagingService.java --- @@ -591,8 +592,9 @@ public void run() if

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-17 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189109427 --- Diff: src/java/org/apache/cassandra/service/AbstractWriteResponseHandler.java --- @@ -225,7 +223,7 @@ protected boolean

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-17 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189116984 --- Diff: src/java/org/apache/cassandra/locator/Replicas.java --- @@ -0,0 +1,313 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-17 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189117046 --- Diff: src/java/org/apache/cassandra/service/WriteResponseHandler.java --- @@ -42,26 +44,26 @@ private static final

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-17 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189117060 --- Diff: src/java/org/apache/cassandra/service/reads/DataResolver.java --- @@ -30,21 +36,23 @@ import

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-17 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189117019 --- Diff: src/java/org/apache/cassandra/locator/ReplicaList.java --- @@ -0,0 +1,244 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-17 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189117008 --- Diff: src/java/org/apache/cassandra/service/StorageProxy.java --- @@ -541,12 +536,12 @@ public void run() return callback; }

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-17 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189117005 --- Diff: src/java/org/apache/cassandra/service/StorageProxy.java --- @@ -503,12 +498,12 @@ private static void sendCommit(Commit commit, Iterable

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-17 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189116992 --- Diff: src/java/org/apache/cassandra/locator/Replicas.java --- @@ -0,0 +1,313 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-17 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189116971 --- Diff: src/java/org/apache/cassandra/locator/ReplicaList.java --- @@ -0,0 +1,244 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-17 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189117001 --- Diff: src/java/org/apache/cassandra/locator/TokenMetadata.java --- @@ -1204,21 +1205,21 @@ private String printPendingRanges() return

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-17 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189117042 --- Diff: src/java/org/apache/cassandra/service/StorageService.java --- @@ -3845,16 +3852,9 @@ public void forceTerminateAllRepairSessions()

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-17 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189117028 --- Diff: src/java/org/apache/cassandra/service/StorageProxy.java --- @@ -1364,68 +1363,72 @@ public static void sendToHintedEndpoints(final Mutation

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-17 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189119609 --- Diff: src/java/org/apache/cassandra/service/reads/DataResolver.java --- @@ -64,12 +72,19 @@ public PartitionIterator resolve() // at

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-17 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189092468 --- Diff: src/java/org/apache/cassandra/locator/ReplicaSet.java --- @@ -0,0 +1,142 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-17 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189092419 --- Diff: src/java/org/apache/cassandra/locator/ReplicaList.java --- @@ -0,0 +1,244 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-17 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189092440 --- Diff: src/java/org/apache/cassandra/locator/ReplicaList.java --- @@ -0,0 +1,244 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-17 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189092384 --- Diff: src/java/org/apache/cassandra/locator/ReplicaList.java --- @@ -0,0 +1,244 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-17 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189092409 --- Diff: src/java/org/apache/cassandra/locator/ReplicaList.java --- @@ -0,0 +1,244 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-17 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189091639 --- Diff: src/java/org/apache/cassandra/locator/Replica.java --- @@ -0,0 +1,221 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-17 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189091647 --- Diff: src/java/org/apache/cassandra/locator/Replica.java --- @@ -0,0 +1,221 @@ +/* + * Licensed to the Apache Software Foundation (ASF)