[GitHub] cassandra pull request #271: 14726

2018-09-27 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/271#discussion_r220951620 --- Diff: src/java/org/apache/cassandra/locator/AbstractReplicaCollection.java --- @@ -58,45 +63,332 @@ }; } -

[GitHub] cassandra pull request #271: 14726

2018-09-27 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/271#discussion_r220966312 --- Diff: src/java/org/apache/cassandra/locator/AbstractReplicaCollection.java --- @@ -58,45 +63,332 @@ }; } -

[GitHub] cassandra pull request #271: 14726

2018-09-27 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/271#discussion_r220986153 --- Diff: src/java/org/apache/cassandra/locator/AbstractReplicaCollection.java --- @@ -58,45 +63,332 @@ }; } -

[GitHub] cassandra pull request #271: 14726

2018-09-27 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/271#discussion_r220869142 --- Diff: src/java/org/apache/cassandra/locator/EndpointsForRange.java --- @@ -40,13 +37,13 @@ public class EndpointsForRange extends Endpoints

[GitHub] cassandra pull request #271: 14726

2018-09-27 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/271#discussion_r220874274 --- Diff: test/unit/org/apache/cassandra/locator/ReplicaCollectionTest.java --- @@ -141,28 +147,37 @@ public void testOrderOfIteration() {

[GitHub] cassandra pull request #271: 14726

2018-09-27 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/271#discussion_r220871228 --- Diff: src/java/org/apache/cassandra/locator/Endpoints.java --- @@ -36,13 +33,16 @@ */ public abstract class Endpoints> extends

[GitHub] cassandra pull request #271: 14726

2018-09-27 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/271#discussion_r220871785 --- Diff: test/unit/org/apache/cassandra/locator/ReplicaCollectionTest.java --- @@ -141,28 +147,37 @@ public void testOrderOfIteration() {