[GitHub] [cassandra] bereng commented on pull request #570: CASSANDRA-13606 Improve handling of 2i initialization failures

bereng commented on pull request #570: URL: https://github.com/apache/cassandra/pull/570#issuecomment-631991871 Hi @adelapena. Thx for the commit. I patched it and apply it here. Feel free to push here directly next time so it's authored by you rather than me so I don't steal your thunder

[GitHub] [cassandra] jasonstack commented on a change in pull request #493: CASSANDRA-8272 trunk Fix replica-side filtering

jasonstack commented on a change in pull request #493: URL: https://github.com/apache/cassandra/pull/493#discussion_r428653697 ## File path: src/java/org/apache/cassandra/service/reads/ReplicaFilteringProtection.java ## @@ -0,0 +1,473 @@ +/* + * Licensed to the Apache Software

[GitHub] [cassandra] bereng commented on pull request #570: CASSANDRA-13606 Improve handling of 2i initialization failures

bereng commented on pull request #570: URL: https://github.com/apache/cassandra/pull/570#issuecomment-632103017 CI runs: - [CI j8](https://app.circleci.com/pipelines/github/bereng/cassandra/34/workflows/aca7db2f-b52d-452d-8264-c0a478c11a76) - [CI j11](https://app.circleci.com/pipelin

[GitHub] [cassandra] maedhroz commented on a change in pull request #493: CASSANDRA-8272 trunk Fix replica-side filtering

maedhroz commented on a change in pull request #493: URL: https://github.com/apache/cassandra/pull/493#discussion_r428738789 ## File path: src/java/org/apache/cassandra/service/reads/ReplicaFilteringProtection.java ## @@ -0,0 +1,473 @@ +/* + * Licensed to the Apache Software F

[GitHub] [cassandra] adelapena commented on a change in pull request #493: CASSANDRA-8272 trunk Fix replica-side filtering

adelapena commented on a change in pull request #493: URL: https://github.com/apache/cassandra/pull/493#discussion_r428793495 ## File path: src/java/org/apache/cassandra/service/reads/ReplicaFilteringProtection.java ## @@ -0,0 +1,473 @@ +/* + * Licensed to the Apache Software

[GitHub] [cassandra] adelapena commented on a change in pull request #493: CASSANDRA-8272 trunk Fix replica-side filtering

adelapena commented on a change in pull request #493: URL: https://github.com/apache/cassandra/pull/493#discussion_r428798039 ## File path: src/java/org/apache/cassandra/service/reads/ReplicaFilteringProtection.java ## @@ -0,0 +1,473 @@ +/* + * Licensed to the Apache Software

[GitHub] [cassandra] adelapena commented on pull request #493: CASSANDRA-8272 trunk Fix replica-side filtering

adelapena commented on pull request #493: URL: https://github.com/apache/cassandra/pull/493#issuecomment-632240298 Besides transient replicas, another pending matter is for what versions we want to apply the patch. Strictly this is a bug fix, but it has been known for so many time that it

[GitHub] [cassandra] rgroothuijsen opened a new pull request #598: CASSANDRA-15802: Strip comment blocks from cqlsh input before processing statements

rgroothuijsen opened a new pull request #598: URL: https://github.com/apache/cassandra/pull/598 It has been reported that including a semicolon in a CQL comment block causes an error, since cqlsh does not discern whether it is currently inside a comment block while preparing statements. As

[GitHub] [cassandra] maedhroz commented on a change in pull request #493: CASSANDRA-8272 trunk Fix replica-side filtering

maedhroz commented on a change in pull request #493: URL: https://github.com/apache/cassandra/pull/493#discussion_r428827859 ## File path: src/java/org/apache/cassandra/service/reads/ReplicaFilteringProtection.java ## @@ -0,0 +1,473 @@ +/* + * Licensed to the Apache Software F

[GitHub] [cassandra] maedhroz commented on a change in pull request #493: CASSANDRA-8272 trunk Fix replica-side filtering

maedhroz commented on a change in pull request #493: URL: https://github.com/apache/cassandra/pull/493#discussion_r428827859 ## File path: src/java/org/apache/cassandra/service/reads/ReplicaFilteringProtection.java ## @@ -0,0 +1,473 @@ +/* + * Licensed to the Apache Software F

[GitHub] [cassandra] maedhroz commented on a change in pull request #493: CASSANDRA-8272 trunk Fix replica-side filtering

maedhroz commented on a change in pull request #493: URL: https://github.com/apache/cassandra/pull/493#discussion_r428827859 ## File path: src/java/org/apache/cassandra/service/reads/ReplicaFilteringProtection.java ## @@ -0,0 +1,473 @@ +/* + * Licensed to the Apache Software F