[GitHub] cassandra pull request #204: 14115 v1

2018-03-15 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/204#discussion_r174927597 --- Diff: src/java/org/apache/cassandra/db/streaming/CassandraStreamManager.java --- @@ -0,0 +1,158 @@ +/* + * Licensed to the Apache

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-09 Thread bdeggleston
GitHub user bdeggleston opened a pull request: https://github.com/apache/cassandra/pull/224 14405 replicas You can merge this pull request into a Git repository by running: $ git pull https://github.com/bdeggleston/cassandra 14405-replicas Alternatively you can review

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-17 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189038385 --- Diff: src/java/org/apache/cassandra/db/ColumnFamilyStore.java --- @@ -1868,7 +1866,7 @@ public void compactionDiskSpaceCheck(boolean enable

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-17 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189038308 --- Diff: src/java/org/apache/cassandra/db/ColumnFamilyStore.java --- @@ -1591,7 +1589,7 @@ public long getExpectedCompactedFileSize(Iterable

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-17 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189039085 --- Diff: src/java/org/apache/cassandra/db/view/ViewBuilder.java --- @@ -135,14 +137,15 @@ private synchronized void build

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-17 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189039639 --- Diff: src/java/org/apache/cassandra/locator/TokenMetadata.java --- @@ -856,25 +857,25 @@ private static PendingRangeMaps calculatePendingRanges

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-17 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189038708 --- Diff: src/java/org/apache/cassandra/db/compaction/CompactionManager.java --- @@ -468,7 +465,7 @@ public AllSSTableOpStatus performCleanup(final

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-17 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189038958 --- Diff: src/java/org/apache/cassandra/db/compaction/Verifier.java --- @@ -209,7 +208,9 @@ public void verify() markAndThrow

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-17 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189038875 --- Diff: src/java/org/apache/cassandra/db/compaction/CompactionManager.java --- @@ -871,7 +868,7 @@ public void forceUserDefinedCleanup(String

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-17 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189038759 --- Diff: src/java/org/apache/cassandra/db/compaction/CompactionManager.java --- @@ -533,7 +530,7 @@ public AllSSTableOpStatus relocateSSTables(final

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-17 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189049318 --- Diff: src/java/org/apache/cassandra/locator/Replica.java --- @@ -0,0 +1,221 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-17 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189030217 --- Diff: src/java/org/apache/cassandra/locator/ReplicationFactor.java --- @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache Software

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-16 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r188800538 --- Diff: src/java/org/apache/cassandra/batchlog/BatchlogManager.java --- @@ -490,16 +497,16 @@ private static int gcgs(Collection mutations

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-18 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189392952 --- Diff: src/java/org/apache/cassandra/dht/RangeFetchMapCalculator.java --- @@ -347,15 +349,16 @@ else if (vertex.isRangeVertex()) private

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-18 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189394058 --- Diff: src/java/org/apache/cassandra/locator/PendingRangeMaps.java --- @@ -23,196 +23,176 @@ import com.google.common.collect.Iterators

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-18 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189397458 --- Diff: src/java/org/apache/cassandra/locator/PendingRangeMaps.java --- @@ -23,196 +23,176 @@ import com.google.common.collect.Iterators

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-18 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189397262 --- Diff: src/java/org/apache/cassandra/locator/Replica.java --- @@ -0,0 +1,221 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-17 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189091637 --- Diff: src/java/org/apache/cassandra/locator/Replica.java --- @@ -0,0 +1,221 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-17 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189091280 --- Diff: src/java/org/apache/cassandra/locator/AbstractReplicationStrategy.java --- @@ -202,61 +204,63 @@ private Keyspace getKeyspace

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-17 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189091069 --- Diff: src/java/org/apache/cassandra/db/ConsistencyLevel.java --- @@ -190,50 +197,50 @@ public int countLocalEndpoints(Iterable liveEndpoints

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-17 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189091062 --- Diff: src/java/org/apache/cassandra/db/ConsistencyLevel.java --- @@ -190,50 +197,50 @@ public int countLocalEndpoints(Iterable liveEndpoints

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-17 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189092476 --- Diff: src/java/org/apache/cassandra/locator/ReplicaSet.java --- @@ -0,0 +1,142 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-17 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189092447 --- Diff: src/java/org/apache/cassandra/locator/ReplicaList.java --- @@ -0,0 +1,244 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-17 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189092456 --- Diff: src/java/org/apache/cassandra/locator/ReplicaMultimap.java --- @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-17 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189108331 --- Diff: src/java/org/apache/cassandra/net/MessagingService.java --- @@ -591,8 +592,9 @@ public void run

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-17 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189109427 --- Diff: src/java/org/apache/cassandra/service/AbstractWriteResponseHandler.java --- @@ -225,7 +223,7 @@ protected boolean waitingFor

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-17 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189116984 --- Diff: src/java/org/apache/cassandra/locator/Replicas.java --- @@ -0,0 +1,313 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-17 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189117046 --- Diff: src/java/org/apache/cassandra/service/WriteResponseHandler.java --- @@ -42,26 +44,26 @@ private static final

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-17 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189117060 --- Diff: src/java/org/apache/cassandra/service/reads/DataResolver.java --- @@ -30,21 +36,23 @@ import

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-17 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189117019 --- Diff: src/java/org/apache/cassandra/locator/ReplicaList.java --- @@ -0,0 +1,244 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-17 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189117008 --- Diff: src/java/org/apache/cassandra/service/StorageProxy.java --- @@ -541,12 +536,12 @@ public void run() return callback

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-17 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189117005 --- Diff: src/java/org/apache/cassandra/service/StorageProxy.java --- @@ -503,12 +498,12 @@ private static void sendCommit(Commit commit, Iterable

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-17 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189116992 --- Diff: src/java/org/apache/cassandra/locator/Replicas.java --- @@ -0,0 +1,313 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-17 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189116971 --- Diff: src/java/org/apache/cassandra/locator/ReplicaList.java --- @@ -0,0 +1,244 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-17 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189117001 --- Diff: src/java/org/apache/cassandra/locator/TokenMetadata.java --- @@ -1204,21 +1205,21 @@ private String printPendingRanges() return

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-17 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189117042 --- Diff: src/java/org/apache/cassandra/service/StorageService.java --- @@ -3845,16 +3852,9 @@ public void forceTerminateAllRepairSessions

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-17 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189117028 --- Diff: src/java/org/apache/cassandra/service/StorageProxy.java --- @@ -1364,68 +1363,72 @@ public static void sendToHintedEndpoints(final Mutation

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-17 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189119609 --- Diff: src/java/org/apache/cassandra/service/reads/DataResolver.java --- @@ -64,12 +72,19 @@ public PartitionIterator resolve

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-17 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189092468 --- Diff: src/java/org/apache/cassandra/locator/ReplicaSet.java --- @@ -0,0 +1,142 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-17 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189092419 --- Diff: src/java/org/apache/cassandra/locator/ReplicaList.java --- @@ -0,0 +1,244 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-17 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189092440 --- Diff: src/java/org/apache/cassandra/locator/ReplicaList.java --- @@ -0,0 +1,244 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-17 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189092384 --- Diff: src/java/org/apache/cassandra/locator/ReplicaList.java --- @@ -0,0 +1,244 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-17 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189092409 --- Diff: src/java/org/apache/cassandra/locator/ReplicaList.java --- @@ -0,0 +1,244 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-17 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189091639 --- Diff: src/java/org/apache/cassandra/locator/Replica.java --- @@ -0,0 +1,221 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-17 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r189091647 --- Diff: src/java/org/apache/cassandra/locator/Replica.java --- @@ -0,0 +1,221 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-16 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r188782098 --- Diff: src/java/org/apache/cassandra/cql3/statements/AlterKeyspaceStatement.java --- @@ -96,7 +98,35 @@ private void warnIfIncreasingRF

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-16 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r188782694 --- Diff: src/java/org/apache/cassandra/cql3/statements/AlterKeyspaceStatement.java --- @@ -96,7 +98,35 @@ private void warnIfIncreasingRF

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-16 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r188785202 --- Diff: src/java/org/apache/cassandra/cql3/statements/AlterKeyspaceStatement.java --- @@ -96,7 +98,35 @@ private void warnIfIncreasingRF

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-16 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r188786457 --- Diff: src/java/org/apache/cassandra/cql3/statements/AlterKeyspaceStatement.java --- @@ -96,7 +98,35 @@ private void warnIfIncreasingRF

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-16 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r188770805 --- Diff: doc/source/architecture/dynamo.rst --- @@ -74,6 +74,26 @@ nodes in each rack, the data load on the smallest rack may be much higher. Simi

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-16 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r188770789 --- Diff: doc/source/architecture/dynamo.rst --- @@ -74,6 +74,26 @@ nodes in each rack, the data load on the smallest rack may be much higher. Simi

[GitHub] cassandra pull request #224: 14405 replicas

2018-06-11 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r194581551 --- Diff: src/java/org/apache/cassandra/locator/ReplicaList.java --- @@ -0,0 +1,283 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] cassandra pull request #224: 14405 replicas

2018-06-11 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r194581559 --- Diff: test/unit/org/apache/cassandra/locator/NetworkTopologyStrategyTest.java --- @@ -36,12 +37,17 @@ import

[GitHub] cassandra pull request #224: 14405 replicas

2018-06-11 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r194581549 --- Diff: src/java/org/apache/cassandra/locator/ReplicaSet.java --- @@ -0,0 +1,156 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] cassandra pull request #224: 14405 replicas

2018-06-12 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r194793488 --- Diff: src/java/org/apache/cassandra/service/reads/AbstractReadExecutor.java --- @@ -344,17 +351,18 @@ public void maybeTryAdditionalReplicas

[GitHub] cassandra pull request #224: 14405 replicas

2018-06-12 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r194793501 --- Diff: src/java/org/apache/cassandra/service/reads/AbstractReadExecutor.java --- @@ -269,24 +272,26 @@ public void executeAsync

[GitHub] cassandra pull request #224: 14405 replicas

2018-06-12 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r194793477 --- Diff: src/java/org/apache/cassandra/service/reads/AbstractReadExecutor.java --- @@ -269,24 +272,26 @@ public void executeAsync

[GitHub] cassandra pull request #224: 14405 replicas

2018-06-12 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r194919778 --- Diff: test/long/org/apache/cassandra/locator/DynamicEndpointSnitchLongTest.java --- @@ -54,19 +54,19 @@ public void testConcurrency() throws

[GitHub] cassandra issue #224: 14405 replicas

2018-06-12 Thread bdeggleston
Github user bdeggleston commented on the issue: https://github.com/apache/cassandra/pull/224 bq. You probably want an AbstractReplicaSet and AbstractReplicaList with no storage that define how equals (against any derived class of AbstractReplicaSet or List depending). fixed

[GitHub] cassandra pull request #224: 14405 replicas

2018-06-12 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r194812259 --- Diff: src/java/org/apache/cassandra/locator/PendingRangeMaps.java --- @@ -23,196 +23,176 @@ import com.google.common.collect.Iterators

[GitHub] cassandra pull request #224: 14405 replicas

2018-06-18 Thread bdeggleston
Github user bdeggleston commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r196133429 --- Diff: src/java/org/apache/cassandra/locator/Replicas.java --- @@ -50,6 +50,30 @@ public abstract int size(); protected abstract