[GitHub] cassandra pull request #236: 9608 trunk

2018-06-16 Thread jasobrown
GitHub user jasobrown opened a pull request: https://github.com/apache/cassandra/pull/236 9608 trunk You can merge this pull request into a Git repository by running: $ git pull https://github.com/snazy/cassandra 9608-trunk Alternatively you can review and apply

[GitHub] cassandra pull request #236: 9608 trunk

2018-06-29 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/236#discussion_r195913343 --- Diff: build.xml --- @@ -110,16 +118,35 @@ - + + + + + +

[GitHub] cassandra pull request #236: 9608 trunk

2018-06-29 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/236#discussion_r199253772 --- Diff: conf/jvm11.options --- @@ -0,0 +1,89

[GitHub] cassandra pull request #236: 9608 trunk

2018-06-29 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/236#discussion_r195913415 --- Diff: build.xml --- @@ -462,7 +501,9 @@ - + --- End diff

[GitHub] cassandra pull request #236: 9608 trunk

2018-06-29 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/236#discussion_r199253798 --- Diff: conf/cassandra-env.sh --- @@ -86,50 +86,36 @@ calculate_heap_sizes() fi } -# Determine the sort of JVM we'll

[GitHub] cassandra pull request #236: 9608 trunk

2018-06-29 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/236#discussion_r195913429 --- Diff: build.xml --- @@ -703,6 +744,13 @@ + + --- End diff -- why do you need

[GitHub] cassandra pull request #236: 9608 trunk

2018-06-29 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/236#discussion_r199259098 --- Diff: src/java/org/apache/cassandra/io/util/FileUtils.java --- @@ -67,23 +71,84 @@ public static final boolean isCleanerAvailable

[GitHub] cassandra pull request #236: 9608 trunk

2018-06-29 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/236#discussion_r199260807 --- Diff: src/java/org/apache/cassandra/utils/NativeLibrary.java --- @@ -78,7 +77,14 @@ static { FILE_DESCRIPTOR_FD_FIELD

[GitHub] cassandra pull request #236: 9608 trunk

2018-06-29 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/236#discussion_r199266510 --- Diff: src/java/org/apache/cassandra/cql3/functions/JavaBasedUDFunction.java --- @@ -591,14 +612,48 @@ private NameEnvironmentAnswer findType(String

[GitHub] cassandra pull request #236: 9608 trunk

2018-06-29 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/236#discussion_r199260315 --- Diff: src/java/org/apache/cassandra/security/ThreadAwareSecurityManager.java --- @@ -208,7 +225,5 @@ public void checkPackageAccess(String pkg

[GitHub] cassandra pull request #236: 9608 trunk

2018-06-30 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/236#discussion_r199330666 --- Diff: src/java/org/apache/cassandra/io/util/FileUtils.java --- @@ -67,23 +71,84 @@ public static final boolean isCleanerAvailable

[GitHub] cassandra pull request #236: 9608 trunk

2018-06-30 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/236#discussion_r199330506 --- Diff: src/java/org/apache/cassandra/io/util/FileUtils.java --- @@ -67,23 +71,84 @@ public static final boolean isCleanerAvailable

[GitHub] cassandra pull request #236: 9608 trunk

2018-06-30 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/236#discussion_r199331081 --- Diff: src/java/org/apache/cassandra/io/util/FileUtils.java --- @@ -106,11 +171,57 @@ public static void createHardLink(File from, File

[GitHub] cassandra pull request #184: Cassandra 7544 rebased2

2018-01-11 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/184#discussion_r159255891 --- Diff: src/java/org/apache/cassandra/locator/InetAddressAndPort.java --- @@ -0,0 +1,193 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] cassandra pull request #184: Cassandra 7544 rebased2

2018-01-11 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/184#discussion_r160539548 --- Diff: src/java/org/apache/cassandra/net/MessageOut.java --- @@ -80,12 +81,17 @@ public class MessageOut { private static final

[GitHub] cassandra pull request #184: Cassandra 7544 rebased2

2018-01-11 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/184#discussion_r160283145 --- Diff: src/java/org/apache/cassandra/db/LegacySystemKeyspaceMigrator.java --- @@ -0,0 +1,183 @@ +/* + * Licensed to the Apache Software

[GitHub] cassandra pull request #184: Cassandra 7544 rebased2

2018-01-11 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/184#discussion_r160276907 --- Diff: src/java/org/apache/cassandra/db/LegacySystemKeyspaceMigrator.java --- @@ -0,0 +1,183 @@ +/* + * Licensed to the Apache Software

[GitHub] cassandra pull request #184: Cassandra 7544 rebased2

2018-01-11 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/184#discussion_r160538757 --- Diff: src/java/org/apache/cassandra/net/MessageOut.java --- @@ -133,11 +139,13 @@ public MessageOut(InetAddress from, MessagingService.Verb verb, T

[GitHub] cassandra pull request #184: Cassandra 7544 rebased2

2018-01-11 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/184#discussion_r160490410 --- Diff: src/java/org/apache/cassandra/gms/Gossiper.java --- @@ -319,14 +323,25 @@ public long getEndpointDowntime(InetAddress ep

[GitHub] cassandra pull request #184: Cassandra 7544 rebased2

2018-01-11 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/184#discussion_r160496090 --- Diff: src/java/org/apache/cassandra/gms/VersionedValue.java --- @@ -138,6 +139,11 @@ public VersionedValue bootReplacing(InetAddress oldNode

[GitHub] cassandra pull request #184: Cassandra 7544 rebased2

2018-01-11 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/184#discussion_r160540192 --- Diff: src/java/org/apache/cassandra/net/MessageOut.java --- @@ -80,12 +81,17 @@ public class MessageOut { private static final

[GitHub] cassandra pull request #184: Cassandra 7544 rebased2

2018-01-11 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/184#discussion_r160281918 --- Diff: src/java/org/apache/cassandra/db/LegacySystemKeyspaceMigrator.java --- @@ -0,0 +1,183 @@ +/* + * Licensed to the Apache Software

[GitHub] cassandra pull request #184: Cassandra 7544 rebased2

2018-01-11 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/184#discussion_r160533135 --- Diff: src/java/org/apache/cassandra/net/ForwardToContainer.java --- @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] cassandra pull request #184: Cassandra 7544 rebased2

2018-01-11 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/184#discussion_r160285588 --- Diff: src/java/org/apache/cassandra/db/SystemKeyspace.java --- @@ -607,39 +672,65 @@ public static long getTruncatedAt(TableId id

[GitHub] cassandra pull request #184: Cassandra 7544 rebased2

2018-01-11 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/184#discussion_r160284046 --- Diff: src/java/org/apache/cassandra/db/SystemKeyspace.java --- @@ -91,47 +92,52 @@ private SystemKeyspace() public static final String

[GitHub] cassandra pull request #184: Cassandra 7544 rebased2

2018-01-11 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/184#discussion_r160535682 --- Diff: src/java/org/apache/cassandra/net/MessageDeliveryTask.java --- @@ -96,19 +98,11 @@ private void handleFailure(Throwable t

[GitHub] cassandra pull request #184: Cassandra 7544 rebased2

2018-01-11 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/184#discussion_r160520881 --- Diff: src/java/org/apache/cassandra/net/CompactEndpointSerializationHelper.java --- @@ -21,28 +21,142 @@ import java.net.Inet4Address

[GitHub] cassandra pull request #184: Cassandra 7544 rebased2

2018-01-11 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/184#discussion_r160496553 --- Diff: src/java/org/apache/cassandra/hadoop/ConfigHelper.java --- @@ -349,6 +350,16 @@ public static String getOutputInitialAddress(Configuration

[GitHub] cassandra pull request #184: Cassandra 7544 rebased2

2018-01-11 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/184#discussion_r160537959 --- Diff: src/java/org/apache/cassandra/net/MessageIn.java --- @@ -89,37 +88,39 @@ private MessageIn(InetAddress from, public static

[GitHub] cassandra pull request #184: Cassandra 7544 rebased2

2018-01-11 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/184#discussion_r160495552 --- Diff: src/java/org/apache/cassandra/gms/Gossiper.java --- @@ -1207,12 +1239,27 @@ private void applyNewStates(InetAddress addr, EndpointState

[GitHub] cassandra pull request #184: Cassandra 7544 rebased2

2018-01-11 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/184#discussion_r160491216 --- Diff: src/java/org/apache/cassandra/gms/Gossiper.java --- @@ -1112,21 +1131,34 @@ public boolean isSilentShutdownState(EndpointState epState

[GitHub] cassandra pull request #184: Cassandra 7544 rebased2

2018-01-11 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/184#discussion_r160490807 --- Diff: src/java/org/apache/cassandra/gms/Gossiper.java --- @@ -623,18 +641,19 @@ else if (newState.getHeartBeatState().getHeartBeatVersion

[GitHub] cassandra pull request #184: Cassandra 7544 rebased2

2018-01-11 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/184#discussion_r160523743 --- Diff: src/java/org/apache/cassandra/net/CompactEndpointSerializationHelper.java --- @@ -21,28 +21,142 @@ import java.net.Inet4Address

[GitHub] cassandra pull request #184: Cassandra 7544 rebased2

2018-01-11 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/184#discussion_r160288035 --- Diff: src/java/org/apache/cassandra/db/commitlog/CommitLogDescriptor.java --- @@ -40,6 +40,7 @@ import

[GitHub] cassandra pull request #184: Cassandra 7544 rebased2

2018-01-16 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/184#discussion_r161926116 --- Diff: conf/cassandra.yaml --- @@ -960,6 +967,7 @@ server_encryption_options: # cipher_suites: [TLS_RSA_WITH_AES_128_CBC_SHA

[GitHub] cassandra pull request #184: Cassandra 7544 rebased2

2018-01-16 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/184#discussion_r161921935 --- Diff: src/java/org/apache/cassandra/streaming/StreamResultFuture.java --- @@ -135,11 +136,13 @@ public StreamCoordinator getCoordinator

[GitHub] cassandra pull request #184: Cassandra 7544 rebased2

2018-01-17 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/184#discussion_r162180384 --- Diff: src/java/org/apache/cassandra/gms/ApplicationState.java --- @@ -19,24 +19,25 @@ public enum ApplicationState { -STATUS

[GitHub] cassandra pull request #191: 13993

2018-02-14 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/191#discussion_r168186136 --- Diff: src/java/org/apache/cassandra/net/MessagingService.java --- @@ -1664,4 +1676,113 @@ public static boolean isEncryptedConnection

[GitHub] cassandra pull request #191: 13993

2018-02-14 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/191#discussion_r168186466 --- Diff: src/java/org/apache/cassandra/net/MessagingService.java --- @@ -1664,4 +1676,113 @@ public static boolean isEncryptedConnection

[GitHub] cassandra pull request #191: 13993

2018-02-14 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/191#discussion_r168186702 --- Diff: src/java/org/apache/cassandra/net/MessagingService.java --- @@ -254,6 +258,8 @@ public long getTimeout() return

[GitHub] cassandra pull request #191: 13993

2018-02-14 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/191#discussion_r168185310 --- Diff: src/java/org/apache/cassandra/net/MessagingService.java --- @@ -1664,4 +1676,113 @@ public static boolean isEncryptedConnection

[GitHub] cassandra pull request #191: 13993

2018-02-14 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/191#discussion_r168186993 --- Diff: src/java/org/apache/cassandra/net/MessagingService.java --- @@ -1664,4 +1676,113 @@ public static boolean isEncryptedConnection

[GitHub] cassandra pull request #191: 13993

2018-02-14 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/191#discussion_r168319052 --- Diff: src/java/org/apache/cassandra/net/MessagingService.java --- @@ -1664,4 +1676,113 @@ public static boolean isEncryptedConnection

[GitHub] cassandra pull request #191: 13993

2018-02-14 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/191#discussion_r168326107 --- Diff: src/java/org/apache/cassandra/net/MessagingService.java --- @@ -1664,4 +1676,113 @@ public static boolean isEncryptedConnection

[GitHub] cassandra pull request #191: 13993

2018-02-14 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/191#discussion_r168316916 --- Diff: src/java/org/apache/cassandra/net/MessagingService.java --- @@ -1664,4 +1676,113 @@ public static boolean isEncryptedConnection

[GitHub] cassandra pull request #191: 13993

2018-02-14 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/191#discussion_r168318195 --- Diff: src/java/org/apache/cassandra/net/MessagingService.java --- @@ -1664,4 +1676,113 @@ public static boolean isEncryptedConnection

[GitHub] cassandra pull request #191: 13993

2018-02-14 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/191#discussion_r168324237 --- Diff: src/java/org/apache/cassandra/net/MessagingService.java --- @@ -1664,4 +1676,113 @@ public static boolean isEncryptedConnection

[GitHub] cassandra pull request #184: Cassandra 7544 rebased2

2018-01-02 Thread jasobrown
GitHub user jasobrown opened a pull request: https://github.com/apache/cassandra/pull/184 Cassandra 7544 rebased2 You can merge this pull request into a Git repository by running: $ git pull https://github.com/aweisberg/cassandra cassandra-7544-rebased2 Alternatively you can

[GitHub] cassandra-dtest pull request #15: Cassandra 7544

2018-01-02 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra-dtest/pull/15#discussion_r159245703 --- Diff: repair_tests/incremental_repair_test.py --- @@ -168,9 +171,10 @@ def _make_fake_session(self, keyspace, table): for node

[GitHub] cassandra-dtest pull request #15: Cassandra 7544

2018-01-02 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra-dtest/pull/15#discussion_r159247693 --- Diff: snitch_test.py --- @@ -35,15 +36,29 @@ def test_prefer_local_reconnect_on_listen_address(self): NODE1_LISTEN_ADDRESS

[GitHub] cassandra-dtest pull request #15: Cassandra 7544

2018-01-02 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra-dtest/pull/15#discussion_r159246279 --- Diff: requirements.txt --- @@ -4,7 +4,7 @@ futures six -e git+https://github.com/datastax/python-driver.git@cassandra-test#egg

[GitHub] cassandra-dtest pull request #15: Cassandra 7544

2018-01-02 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra-dtest/pull/15#discussion_r159234036 --- Diff: byteman/4.0/decommission_failure_inject.btm --- @@ -10,8 +10,8 @@ METHOD prepareSynAck AT INVOKE startStreamingFiles BIND peer

[GitHub] cassandra-dtest pull request #15: Cassandra 7544

2018-01-02 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra-dtest/pull/15#discussion_r159247279 --- Diff: secondary_indexes_test.py --- @@ -1153,6 +1153,7 @@ def __init__(self, *args, **kwargs): r'Streaming error occurred

[GitHub] cassandra-dtest pull request #15: Cassandra 7544

2018-01-02 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra-dtest/pull/15#discussion_r159245209 --- Diff: rebuild_test.py --- @@ -140,7 +140,9 @@ def resumable_rebuild_test(self): """ self.ignore_log_

[GitHub] cassandra-dtest pull request #15: Cassandra 7544

2018-01-02 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra-dtest/pull/15#discussion_r159248098 --- Diff: topology_test.py --- @@ -197,7 +197,7 @@ def resumable_decommission_test(self): Test decommission operation

[GitHub] cassandra-dtest pull request #15: Cassandra 7544

2018-01-02 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra-dtest/pull/15#discussion_r159247123 --- Diff: replace_address_test.py --- @@ -35,7 +35,7 @@ class BaseReplaceAddressTest(Tester): def _setup(self, n=3, opts=None

[GitHub] cassandra issue #236: 9608 trunk

2018-07-26 Thread jasobrown
Github user jasobrown commented on the issue: https://github.com/apache/cassandra/pull/236 Committed as sha `6ba2fb9395226491872b41312d978a169f36fcdb` --- - To unsubscribe, e-mail: pr-unsubscr

[GitHub] cassandra pull request #236: 9608 trunk

2018-07-26 Thread jasobrown
Github user jasobrown closed the pull request at: https://github.com/apache/cassandra/pull/236 --- - To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org

[GitHub] cassandra-dtest issue #31: CASSANDRA-9608 fix jmxutils.py

2018-07-26 Thread jasobrown
Github user jasobrown commented on the issue: https://github.com/apache/cassandra-dtest/pull/31 +1, assuming a +1 on CASSANDRA-9608 --- - To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional

[GitHub] cassandra issue #236: 9608 trunk

2018-07-26 Thread jasobrown
Github user jasobrown commented on the issue: https://github.com/apache/cassandra/pull/236 Is javaexec.in.sh needed anymore? Looks like all the java checks are in `cassandra.in.sh` now. The file is not referenced by dtests or ccm, either

[GitHub] cassandra pull request #253: 13630

2018-08-21 Thread jasobrown
GitHub user jasobrown opened a pull request: https://github.com/apache/cassandra/pull/253 13630 You can merge this pull request into a Git repository by running: $ git pull https://github.com/jasobrown/cassandra 13630 Alternatively you can review and apply these changes

[GitHub] cassandra pull request #255: Marcuse/14618

2018-08-28 Thread jasobrown
GitHub user jasobrown opened a pull request: https://github.com/apache/cassandra/pull/255 Marcuse/14618 You can merge this pull request into a Git repository by running: $ git pull https://github.com/krummas/cassandra marcuse/14618 Alternatively you can review and apply

[GitHub] cassandra pull request #255: Marcuse/14618

2018-08-29 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/255#discussion_r213547995 --- Diff: src/java/org/apache/cassandra/tools/fqltool/FQLQueryIterator.java --- @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Software

[GitHub] cassandra pull request #255: Marcuse/14618

2018-08-29 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/255#discussion_r213541568 --- Diff: src/java/org/apache/cassandra/tools/fqltool/commands/Replay.java --- @@ -0,0 +1,151 @@ +/* + * Licensed to the Apache Software

[GitHub] cassandra pull request #255: Marcuse/14618

2018-08-29 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/255#discussion_r213555484 --- Diff: src/java/org/apache/cassandra/tools/fqltool/FQLQuery.java --- @@ -0,0 +1,263 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] cassandra pull request #255: Marcuse/14618

2018-08-29 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/255#discussion_r213546045 --- Diff: src/java/org/apache/cassandra/tools/fqltool/QueryReplayer.java --- @@ -0,0 +1,150 @@ +/* + * Licensed to the Apache Software

[GitHub] cassandra pull request #255: Marcuse/14618

2018-08-29 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/255#discussion_r213542113 --- Diff: src/java/org/apache/cassandra/tools/fqltool/commands/Replay.java --- @@ -0,0 +1,151 @@ +/* + * Licensed to the Apache Software

[GitHub] cassandra pull request #255: Marcuse/14618

2018-08-29 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/255#discussion_r213546020 --- Diff: src/java/org/apache/cassandra/tools/fqltool/QueryReplayer.java --- @@ -0,0 +1,150 @@ +/* + * Licensed to the Apache Software

[GitHub] cassandra pull request #255: Marcuse/14618

2018-08-29 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/255#discussion_r213543592 --- Diff: src/java/org/apache/cassandra/tools/fqltool/commands/Replay.java --- @@ -0,0 +1,151 @@ +/* + * Licensed to the Apache Software

[GitHub] cassandra pull request #255: Marcuse/14618

2018-08-29 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/255#discussion_r213546773 --- Diff: src/java/org/apache/cassandra/tools/fqltool/commands/Replay.java --- @@ -0,0 +1,151 @@ +/* + * Licensed to the Apache Software

[GitHub] cassandra pull request #255: Marcuse/14618

2018-08-29 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/255#discussion_r213672027 --- Diff: src/java/org/apache/cassandra/tools/fqltool/ResultHandler.java --- @@ -0,0 +1,124 @@ +/* + * Licensed to the Apache Software

[GitHub] cassandra pull request #255: Marcuse/14618

2018-08-29 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/255#discussion_r213670908 --- Diff: src/java/org/apache/cassandra/tools/fqltool/ResultHandler.java --- @@ -0,0 +1,124 @@ +/* + * Licensed to the Apache Software

[GitHub] cassandra pull request #255: Marcuse/14618

2018-08-29 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/255#discussion_r213674616 --- Diff: src/java/org/apache/cassandra/tools/fqltool/ResultComparator.java --- @@ -0,0 +1,122 @@ +/* + * Licensed to the Apache Software

[GitHub] cassandra pull request #255: Marcuse/14618

2018-08-29 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/255#discussion_r213655476 --- Diff: src/java/org/apache/cassandra/tools/fqltool/DriverResultSet.java --- @@ -0,0 +1,253 @@ +/* + * Licensed to the Apache Software

[GitHub] cassandra pull request #255: Marcuse/14618

2018-08-29 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/255#discussion_r213667954 --- Diff: src/java/org/apache/cassandra/tools/fqltool/ResultComparator.java --- @@ -0,0 +1,122 @@ +/* + * Licensed to the Apache Software

[GitHub] cassandra pull request #236: 9608 trunk

2018-07-23 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/236#discussion_r204211370 --- Diff: conf/jvm11-clients.options --- @@ -0,0 +1,21

[GitHub] cassandra pull request #236: 9608 trunk

2018-07-23 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/236#discussion_r204368353 --- Diff: src/java/org/apache/cassandra/io/util/FileUtils.java --- @@ -64,24 +68,31 @@ public static final long ONE_TB = 1024 * ONE_GB

[GitHub] cassandra pull request #236: 9608 trunk

2018-07-23 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/236#discussion_r204362780 --- Diff: build.xml --- @@ -1665,7 +1763,7 @@ - + --- End diff -- Why does this not depend on `get

[GitHub] cassandra pull request #236: 9608 trunk

2018-07-23 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/236#discussion_r204355461 --- Diff: build.xml --- @@ -66,8 +67,14 @@ - - +

[GitHub] cassandra pull request #236: 9608 trunk

2018-07-23 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/236#discussion_r204364994 --- Diff: src/java/org/apache/cassandra/cql3/functions/JavaBasedUDFunction.java --- @@ -591,14 +592,17 @@ private NameEnvironmentAnswer findType(String

[GitHub] cassandra pull request #236: 9608 trunk

2018-07-23 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/236#discussion_r204370957 --- Diff: src/java/org/apache/cassandra/io/util/FileUtils.java --- @@ -350,13 +396,38 @@ public static String getRelativePath(String basePath, String

[GitHub] cassandra pull request #236: 9608 trunk

2018-07-23 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/236#discussion_r204369509 --- Diff: src/java/org/apache/cassandra/io/util/FileUtils.java --- @@ -350,13 +396,38 @@ public static String getRelativePath(String basePath, String

[GitHub] cassandra pull request #236: 9608 trunk

2018-07-23 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/236#discussion_r204372219 --- Diff: src/java/org/apache/cassandra/utils/NativeLibrary.java --- @@ -78,7 +77,14 @@ static { FILE_DESCRIPTOR_FD_FIELD

[GitHub] cassandra pull request #236: 9608 trunk

2018-07-23 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/236#discussion_r204369082 --- Diff: src/java/org/apache/cassandra/io/util/FileUtils.java --- @@ -106,11 +117,46 @@ public static void createHardLink(File from, File

[GitHub] cassandra pull request #253: 13630

2018-09-07 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/253#discussion_r215944830 --- Diff: src/java/org/apache/cassandra/net/async/RebufferingByteBufDataInputPlus.java --- @@ -183,6 +195,11 @@ public int available() throws

[GitHub] cassandra pull request #253: 13630

2018-09-07 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/253#discussion_r215955652 --- Diff: src/java/org/apache/cassandra/net/async/RebufferingByteBufDataInputPlus.java --- @@ -183,6 +195,11 @@ public int available() throws

[GitHub] cassandra pull request #253: 13630

2018-09-09 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/253#discussion_r216157099 --- Diff: src/java/org/apache/cassandra/net/MessageOut.java --- @@ -180,6 +199,73 @@ public String toString() return sbuf.toString

[GitHub] cassandra pull request #253: 13630

2018-09-09 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/253#discussion_r216157097 --- Diff: src/java/org/apache/cassandra/net/MessageOut.java --- @@ -180,6 +199,73 @@ public String toString() return sbuf.toString

[GitHub] cassandra pull request #253: 13630

2018-09-09 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/253#discussion_r216157093 --- Diff: src/java/org/apache/cassandra/net/MessageIn.java --- @@ -231,4 +241,437 @@ public String toString() sbuf.append("FROM:&quo

[GitHub] cassandra pull request #253: 13630

2018-09-09 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/253#discussion_r216157096 --- Diff: src/java/org/apache/cassandra/net/async/MessageInHandler.java --- @@ -18,143 +18,296 @@ package org.apache.cassandra.net.async

[GitHub] cassandra pull request #253: 13630

2018-09-09 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/253#discussion_r216157094 --- Diff: src/java/org/apache/cassandra/net/async/ByteBufDataOutputStreamPlus.java --- @@ -196,10 +220,12 @@ protected void doFlush(int count) throws

[GitHub] cassandra issue #253: CASSANDRA-13630

2018-09-09 Thread jasobrown
Github user jasobrown commented on the issue: https://github.com/apache/cassandra/pull/253 Wait for CASSANDRA-14503 :) On Sun, Sep 9, 2018 at 18:37 Dinesh wrote: > *@dineshjoshi* commented on this pull request. > -- >

[GitHub] cassandra pull request #253: CASSANDRA-13630

2018-09-09 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/253#discussion_r216185533 --- Diff: test/unit/org/apache/cassandra/net/async/ChannelWriterTest.java --- @@ -70,32 +86,71 @@ public static void before() @Before

[GitHub] cassandra pull request #264: CASSANDRA-14503

2018-09-10 Thread jasobrown
GitHub user jasobrown opened a pull request: https://github.com/apache/cassandra/pull/264 CASSANDRA-14503 You can merge this pull request into a Git repository by running: $ git pull https://github.com/jasobrown/cassandra 14503 Alternatively you can review and apply

[GitHub] cassandra pull request #256: Marcuse/14619

2018-08-30 Thread jasobrown
GitHub user jasobrown opened a pull request: https://github.com/apache/cassandra/pull/256 Marcuse/14619 You can merge this pull request into a Git repository by running: $ git pull https://github.com/krummas/cassandra marcuse/14619 Alternatively you can review and apply

[GitHub] cassandra pull request #256: Marcuse/14619

2018-08-30 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/256#discussion_r214221065 --- Diff: src/java/org/apache/cassandra/tools/fqltool/commands/Compare.java --- @@ -0,0 +1,124 @@ +/* + * Licensed to the Apache Software

[GitHub] cassandra pull request #256: Marcuse/14619

2018-08-30 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/256#discussion_r214221005 --- Diff: src/java/org/apache/cassandra/tools/fqltool/commands/Compare.java --- @@ -0,0 +1,124 @@ +/* + * Licensed to the Apache Software

[GitHub] cassandra pull request #256: Marcuse/14619

2018-08-31 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/256#discussion_r214339851 --- Diff: src/java/org/apache/cassandra/tools/fqltool/commands/Compare.java --- @@ -0,0 +1,124 @@ +/* + * Licensed to the Apache Software

[GitHub] cassandra pull request #256: Marcuse/14619

2018-08-31 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/256#discussion_r214339180 --- Diff: src/java/org/apache/cassandra/tools/fqltool/commands/Compare.java --- @@ -0,0 +1,124 @@ +/* + * Licensed to the Apache Software

[GitHub] cassandra pull request #253: 13630

2018-09-07 Thread jasobrown
Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/253#discussion_r216069307 --- Diff: src/java/org/apache/cassandra/net/MessageIn.java --- @@ -231,4 +241,437 @@ public String toString() sbuf.append("FROM:&quo

  1   2   >