[GitHub] cassandra pull request #:

2018-06-05 Thread krummas
Github user krummas commented on the pull request: https://github.com/apache/cassandra/commit/74a0728106e8d61340a4d3cd2a34d0c87118529b#commitcomment-29253214 In src/java/org/apache/cassandra/config/DatabaseDescriptor.java: In src/java/org/apache/cassandra/config

[GitHub] cassandra-dtest pull request #30: CASSANDRA-14467: always enable tombstone v...

2018-06-05 Thread krummas
GitHub user krummas opened a pull request: https://github.com/apache/cassandra-dtest/pull/30 CASSANDRA-14467: always enable tombstone validation exceptions during tests You can merge this pull request into a Git repository by running: $ git pull https://github.com/krummas

[GitHub] cassandra pull request #255: Marcuse/14618

2018-08-29 Thread krummas
Github user krummas commented on a diff in the pull request: https://github.com/apache/cassandra/pull/255#discussion_r213565321 --- Diff: src/java/org/apache/cassandra/tools/fqltool/commands/Replay.java --- @@ -0,0 +1,151 @@ +/* + * Licensed to the Apache Software

[GitHub] cassandra pull request #255: Marcuse/14618

2018-08-29 Thread krummas
Github user krummas commented on a diff in the pull request: https://github.com/apache/cassandra/pull/255#discussion_r213565376 --- Diff: src/java/org/apache/cassandra/tools/fqltool/commands/Replay.java --- @@ -0,0 +1,151 @@ +/* + * Licensed to the Apache Software

[GitHub] cassandra pull request #255: Marcuse/14618

2018-08-29 Thread krummas
Github user krummas commented on a diff in the pull request: https://github.com/apache/cassandra/pull/255#discussion_r213569491 --- Diff: src/java/org/apache/cassandra/tools/fqltool/commands/Replay.java --- @@ -0,0 +1,151 @@ +/* + * Licensed to the Apache Software

[GitHub] cassandra pull request #255: Marcuse/14618

2018-08-29 Thread krummas
Github user krummas commented on a diff in the pull request: https://github.com/apache/cassandra/pull/255#discussion_r213572518 --- Diff: src/java/org/apache/cassandra/tools/fqltool/FQLQuery.java --- @@ -0,0 +1,263 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] cassandra pull request #255: Marcuse/14618

2018-08-29 Thread krummas
Github user krummas commented on a diff in the pull request: https://github.com/apache/cassandra/pull/255#discussion_r213570103 --- Diff: src/java/org/apache/cassandra/tools/fqltool/FQLQuery.java --- @@ -0,0 +1,263 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] cassandra-dtest pull request #32: compact storage when testing thrift

2018-07-24 Thread krummas
Github user krummas closed the pull request at: https://github.com/apache/cassandra-dtest/pull/32 --- - To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h

[GitHub] cassandra-dtest pull request #32: compact storage when testing thrift

2018-07-24 Thread krummas
GitHub user krummas opened a pull request: https://github.com/apache/cassandra-dtest/pull/32 compact storage when testing thrift Patch by marcuse; reviewed by Jason Brown for CASSANDRA-14583 You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] cassandra pull request #252: Reduce heap pressure during compactions for CAS...

2018-10-12 Thread krummas
Github user krummas commented on a diff in the pull request: https://github.com/apache/cassandra/pull/252#discussion_r224696746 --- Diff: src/java/org/apache/cassandra/config/Config.java --- @@ -238,6 +238,7 @@ public int hints_flush_period_in_ms = 1; public

[GitHub] cassandra pull request #252: Reduce heap pressure during compactions for CAS...

2018-10-12 Thread krummas
Github user krummas commented on a diff in the pull request: https://github.com/apache/cassandra/pull/252#discussion_r224695370 --- Diff: src/java/org/apache/cassandra/config/Config.java --- @@ -238,6 +238,7 @@ public int hints_flush_period_in_ms = 1; public

[GitHub] cassandra pull request #252: Reduce heap pressure during compactions for CAS...

2018-10-12 Thread krummas
Github user krummas commented on a diff in the pull request: https://github.com/apache/cassandra/pull/252#discussion_r224459241 --- Diff: src/java/org/apache/cassandra/io/sstable/SSTableRewriter.java --- @@ -131,16 +132,20 @@ public RowIndexEntry append(UnfilteredRowIterator

[GitHub] cassandra pull request #276: Repair job tests

2018-10-04 Thread krummas
Github user krummas commented on a diff in the pull request: https://github.com/apache/cassandra/pull/276#discussion_r222566547 --- Diff: test/unit/org/apache/cassandra/repair/RepairJobTest.java --- @@ -0,0 +1,569 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] cassandra pull request #276: Repair job tests

2018-10-04 Thread krummas
Github user krummas commented on a diff in the pull request: https://github.com/apache/cassandra/pull/276#discussion_r222600025 --- Diff: test/unit/org/apache/cassandra/repair/RepairJobTest.java --- @@ -0,0 +1,569 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] cassandra pull request #276: Repair job tests

2018-10-04 Thread krummas
Github user krummas commented on a diff in the pull request: https://github.com/apache/cassandra/pull/276#discussion_r222609899 --- Diff: test/unit/org/apache/cassandra/repair/RepairJobTest.java --- @@ -0,0 +1,569 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] cassandra pull request #276: Repair job tests

2018-10-04 Thread krummas
Github user krummas commented on a diff in the pull request: https://github.com/apache/cassandra/pull/276#discussion_r222603722 --- Diff: test/unit/org/apache/cassandra/repair/RepairJobTest.java --- @@ -0,0 +1,569 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] cassandra pull request #276: Repair job tests

2018-10-04 Thread krummas
Github user krummas commented on a diff in the pull request: https://github.com/apache/cassandra/pull/276#discussion_r222610027 --- Diff: test/unit/org/apache/cassandra/repair/RepairJobTest.java --- @@ -0,0 +1,569 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] cassandra pull request #276: Repair job tests

2018-10-04 Thread krummas
Github user krummas commented on a diff in the pull request: https://github.com/apache/cassandra/pull/276#discussion_r222552355 --- Diff: src/java/org/apache/cassandra/repair/LocalSyncTask.java --- @@ -52,15 +52,9 @@ private static final Logger logger

[GitHub] cassandra pull request #276: Repair job tests

2018-10-04 Thread krummas
Github user krummas commented on a diff in the pull request: https://github.com/apache/cassandra/pull/276#discussion_r222596795 --- Diff: test/unit/org/apache/cassandra/repair/RepairJobTest.java --- @@ -0,0 +1,569 @@ +/* + * Licensed to the Apache Software Foundation (ASF