[GitHub] [cassandra] bereng commented on pull request #570: CASSANDRA-13606 Improve handling of 2i initialization failures

2020-05-28 Thread GitBox
bereng commented on pull request #570: URL: https://github.com/apache/cassandra/pull/570#issuecomment-635762103 Lgtm. Wdyt? This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [cassandra] bereng commented on pull request #570: CASSANDRA-13606 Improve handling of 2i initialization failures

2020-05-28 Thread GitBox
bereng commented on pull request #570: URL: https://github.com/apache/cassandra/pull/570#issuecomment-635379425 @adelapena circle CI is on a partial outage and it fails on dtests env set up etc. If you fancy firing one in cassandra ci good, otherwise I'll try to get CI runs again tomorrow

[GitHub] [cassandra] bereng commented on pull request #570: CASSANDRA-13606 Improve handling of 2i initialization failures

2020-05-27 Thread GitBox
bereng commented on pull request #570: URL: https://github.com/apache/cassandra/pull/570#issuecomment-634689660 @adelapena The CI runs are complete. The failures I see I think are just flaky tests because I ran some locally and they passed. The scare comes from the j8/j11UnitTests

[GitHub] [cassandra] bereng commented on pull request #570: CASSANDRA-13606 Improve handling of 2i initialization failures

2020-05-27 Thread GitBox
bereng commented on pull request #570: URL: https://github.com/apache/cassandra/pull/570#issuecomment-634507197 @adelapena apologies for the late reply. I was going down a rabbit hole debugging a failing test yesterday and I didn't get around to this. Rebased and squashed. We'll have to

[GitHub] [cassandra] bereng commented on pull request #570: CASSANDRA-13606 Improve handling of 2i initialization failures

2020-05-25 Thread GitBox
bereng commented on pull request #570: URL: https://github.com/apache/cassandra/pull/570#issuecomment-633435042 Great, so you can't access them. I can't tell why as they seem to work for me and your ci-cassandra run failed on trying to pull my dtests branch. The joys of CI :-) What error

[GitHub] [cassandra] bereng commented on pull request #570: CASSANDRA-13606 Improve handling of 2i initialization failures

2020-05-21 Thread GitBox
bereng commented on pull request #570: URL: https://github.com/apache/cassandra/pull/570#issuecomment-632103017 CI runs: - [CI j8](https://app.circleci.com/pipelines/github/bereng/cassandra/34/workflows/aca7db2f-b52d-452d-8264-c0a478c11a76) - [CI

[GitHub] [cassandra] bereng commented on pull request #570: CASSANDRA-13606 Improve handling of 2i initialization failures

2020-05-21 Thread GitBox
bereng commented on pull request #570: URL: https://github.com/apache/cassandra/pull/570#issuecomment-631991871 Hi @adelapena. Thx for the commit. I patched it and apply it here. Feel free to push here directly next time so it's authored by you rather than me so I don't steal your thunder

[GitHub] [cassandra] bereng commented on pull request #570: CASSANDRA-13606 Improve handling of 2i initialization failures

2020-05-14 Thread GitBox
bereng commented on pull request #570: URL: https://github.com/apache/cassandra/pull/570#issuecomment-628653408 @adelapena I have pushed the latest + you can find the dtests PR on the jira ticket. The 2i dtest passes locally also. If you like what you see I'll run the full dtest suite. So

[GitHub] [cassandra] bereng commented on pull request #570: CASSANDRA-13606 Improve handling of 2i initialization failures

2020-05-11 Thread GitBox
bereng commented on pull request #570: URL: https://github.com/apache/cassandra/pull/570#issuecomment-626629871 - [CI j11](https://app.circleci.com/pipelines/github/bereng/cassandra/18/workflows/dcb313cc-b897-4a19-8840-09550a62d6d2) - [CI

[GitHub] [cassandra] bereng commented on pull request #570: CASSANDRA-13606 Improve handling of 2i initialization failures

2020-05-06 Thread GitBox
bereng commented on pull request #570: URL: https://github.com/apache/cassandra/pull/570#issuecomment-624708628 - [Ci j11](https://app.circleci.com/pipelines/github/bereng/cassandra/15/workflows/2c0458de-6534-47e6-8e7c-4909e7827001) - [CI

[GitHub] [cassandra] bereng commented on pull request #570: CASSANDRA-13606 Improve handling of 2i initialization failures

2020-04-28 Thread GitBox
bereng commented on pull request #570: URL: https://github.com/apache/cassandra/pull/570#issuecomment-620694006 - j11 [CI](https://app.circleci.com/pipelines/github/bereng/cassandra/11/workflows/34a10f44-be84-423b-82f7-89cbb756e8ca) - j8