[GitHub] cassandra-dtest issue #6: 12148 style
Github user josh-mckenzie commented on the issue: https://github.com/apache/cassandra-dtest/pull/6 Interesting. Though we moved to pytest, I'd assumed we still had nose available. Thanks for fixing that! --- - To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org
[GitHub] cassandra-dtest issue #6: 12148 style
Github user spodkowinski commented on the issue: https://github.com/apache/cassandra-dtest/pull/6 Should now be fixed in 3d0d0f45f56be3e4278a3bcfae763c052bf65dc7 --- - To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org
[GitHub] cassandra-dtest issue #6: 12148 style
Github user spodkowinski commented on the issue: https://github.com/apache/cassandra-dtest/pull/6 This seems to break builds.apache.org as the nose imports fail to resolve. I think we moved to pytest for that. https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-dtest/493/console --- - To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org
[GitHub] cassandra-dtest issue #6: 12148 style
Github user jeffjirsa commented on the issue: https://github.com/apache/cassandra-dtest/pull/6 Should be same group as Cassandra committers - make sure youâre pointing at asf git with https endpoint, not GitHub, etc. --- - To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org
[GitHub] cassandra-dtest issue #6: 12148 style
Github user josh-mckenzie commented on the issue: https://github.com/apache/cassandra-dtest/pull/6 Right, operating under the assumption that Jim's initial logic (that I reviewed back then) is accurate. This is more a "style sanity check" thing. --- - To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org
[GitHub] cassandra-dtest issue #6: 12148 style
Github user ptnapoleon commented on the issue: https://github.com/apache/cassandra-dtest/pull/6 I'm not yet familiar with pytest and I know nothing about CDC, but this all looks legitimate. +1 --- - To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org
[GitHub] cassandra-dtest issue #6: 12148 style
Github user josh-mckenzie commented on the issue: https://github.com/apache/cassandra-dtest/pull/6 Taking a look @spodkowinski. Local env is being a bitch thanks to 2.7 + 3.5 on same host, win w/linux subsystem, but when I finally get the damned setup working I'll get on this. Sorry about the delay. --- - To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org
[GitHub] cassandra-dtest issue #6: 12148 style
Github user spodkowinski commented on the issue: https://github.com/apache/cassandra-dtest/pull/6 I'm still seeing related failures in dtest results /ping @josh-mckenzie @ptnapoleon --- - To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org
[GitHub] cassandra-dtest issue #6: 12148 style
Github user ptnapoleon commented on the issue: https://github.com/apache/cassandra-dtest/pull/6 Grepping through the codebase and the git log, this has not been merged elsewhere. --- - To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org
[GitHub] cassandra-dtest issue #6: 12148 style
Github user josh-mckenzie commented on the issue: https://github.com/apache/cassandra-dtest/pull/6 Could have sworn we merged in the tests for the 12148 changes. @ptnapoleon - any ideas on this? This PR was for a branch that migrated from Jim's ownership to me and then 12148 sat for months so I wouldn't be surprised for something like this to slip through the cracks. --- - To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org
[GitHub] cassandra-dtest issue #6: 12148 style
Github user spodkowinski commented on the issue: https://github.com/apache/cassandra-dtest/pull/6 The jira is already committed. What's the status of this PR @josh-mckenzie ? --- - To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org
