Re: [PR] CASSANDRA-20322: Fix flakey test org.apache.cassandra.simulator.test.ShortPaxosSimulationTest#casOnAccordSimulationTest [cassandra]

2025-02-12 Thread via GitHub


dcapwell commented on PR #3895:
URL: https://github.com/apache/cassandra/pull/3895#issuecomment-2655029111

   merged


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org



Re: [PR] CASSANDRA-20322: Fix flakey test org.apache.cassandra.simulator.test.ShortPaxosSimulationTest#casOnAccordSimulationTest [cassandra]

2025-02-12 Thread via GitHub


dcapwell closed pull request #3895: CASSANDRA-20322: Fix flakey test 
org.apache.cassandra.simulator.test.ShortPaxosSimulationTest#casOnAccordSimulationTest
URL: https://github.com/apache/cassandra/pull/3895


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org



Re: [PR] CASSANDRA-20322: Fix flakey test org.apache.cassandra.simulator.test.ShortPaxosSimulationTest#casOnAccordSimulationTest [cassandra]

2025-02-12 Thread via GitHub


dcapwell commented on code in PR #3895:
URL: https://github.com/apache/cassandra/pull/3895#discussion_r1953482134


##
test/simulator/main/org/apache/cassandra/simulator/paxos/PaxosSimulation.java:
##
@@ -74,17 +77,31 @@ public abstract class PaxosSimulation implements 
Simulation, ClusterActionListen
 
 private static String createDescription(int[] primaryKeys, int id, String 
idString)
 {
-return (primaryKeys.length == 1 ? Integer.toString(primaryKeys[0]) : 
Arrays.toString(primaryKeys)) + "/" + id + ": " + idString;
+return (primaryKeys.length == 1 ? Integer.toString(primaryKeys[0]) : 
Arrays.toString(primaryKeys)) + '/' + id + ": " + idString;

Review Comment:
   this was just a warning from intellij, so ninja fix



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org