Re: [prometheus-developers] Call for Consensus: node_exporter 1.0.0 release

2020-04-23 Thread Julien Pivotto
On 24 Apr 01:14, Bjoern Rabenstein wrote: > On 23.04.20 13:40, Richard Hartmann wrote: > > > > Should the maintainers (Ben & Fish) be allowed to release without > > waiting for the audit to finish? > > If that's their wish, yes, sure. > > Under the described circumstances, I don't see a reason

Re: [prometheus-developers] Call for Consensus: node_exporter 1.0.0 release

2020-04-23 Thread Bjoern Rabenstein
On 23.04.20 13:40, Richard Hartmann wrote: > > Should the maintainers (Ben & Fish) be allowed to release without > waiting for the audit to finish? If that's their wish, yes, sure. Under the described circumstances, I don't see a reason to block them. -- Björn Rabenstein [PGP-ID]

Re: [prometheus-developers] client_golang: lenient version of promauto.Filter

2020-04-23 Thread Bjoern Rabenstein
On 22.04.20 14:04, 'Chris Taylor' via Prometheus Developers wrote: > > Currently, my code uses prometheus.Register(), and checks whether the returned > error is > a prometheus.AlreadyRegisteredError to get access to the previously-registered > metric and > uses that instead. > > It'd be easy

Re: [prometheus-developers] client_golang: lenient version of promauto.Filter

2020-04-23 Thread Brian Brazil
On Thu, 23 Apr 2020 at 21:08, Chris Taylor < christopher.tay...@soundcloud.com> wrote: > > > On Thu, 23 Apr 2020 at 10:46, Brian Brazil < > brian.bra...@robustperception.io> wrote: > >> On Wed, 22 Apr 2020 at 22:04, 'Chris Taylor' via Prometheus Developers < >>

Re: [prometheus-developers] client_golang: lenient version of promauto.Filter

2020-04-23 Thread 'Chris Taylor' via Prometheus Developers
On Thu, 23 Apr 2020 at 10:46, Brian Brazil wrote: > On Wed, 22 Apr 2020 at 22:04, 'Chris Taylor' via Prometheus Developers < > prometheus-developers@googlegroups.com> wrote: > >> Dear Prometheans, >> >> posting this here because the Github issue template suggested discussing >> changes on the >>

Re: [prometheus-developers] Call for Consensus: node_exporter 1.0.0 release

2020-04-23 Thread 'GANESH VERNEKAR' via Prometheus Developers
Yes to release now On Thu, Apr 23, 2020, 5:11 PM Richard Hartmann wrote: > Dear all, > > This is a call for consensus within Prometheus-team on releasing > node_exporter 1.0.0 as-is. > > node_exporter 1.0.0-rc.0 has been cut on 2020-02-20[1]. It features > experimental TLS support[2]. We are

Re: [prometheus-developers] Call for Consensus: node_exporter 1.0.0 release

2020-04-23 Thread Bartłomiej Płotka
Yes to release now. On Thu, 23 Apr 2020 at 17:12, Chris Marchbanks wrote: > Yes to releasing now. > > On Thu, Apr 23, 2020 at 13:40, Richard Hartmann < > richih.mailingl...@gmail.com> wrote: > > Dear all, This is a call for consensus within Prometheus-team on releasing > node_exporter 1.0.0

Re: [prometheus-developers] Call for Consensus: node_exporter 1.0.0 release

2020-04-23 Thread Chris Marchbanks
Yes to releasing now. On Thu, Apr 23, 2020 at 13:40, Richard Hartmann wrote: Dear all, This is a call for consensus within Prometheus-team on releasing node_exporter 1.0.0 as-is. node_exporter 1.0.0-rc.0 has been cut on 2020-02-20[1]. It features experimental TLS support[2]. We are planning

[prometheus-developers] Re: Call for Consensus: node_exporter 1.0.0 release

2020-04-23 Thread 'Goutham Veeramachaneni' via Prometheus Developers
Yes to release 1.0.0 as is. Lets not block on the security review. On Thursday, April 23, 2020 at 12:41:10 PM UTC+1, Richard Hartmann wrote: > > Dear all, > > This is a call for consensus within Prometheus-team on releasing > node_exporter 1.0.0 as-is. > > node_exporter 1.0.0-rc.0 has been cut

Re: [prometheus-developers] Re: Call for Consensus: node_exporter 1.0.0 release

2020-04-23 Thread Richard Hartmann
On Thu, Apr 23, 2020 at 2:43 PM Brian Brazil wrote: > Let's be careful here with the word experimental, as that means something > very specific in Prometheus terms. "experimental" means that we can make > breaking changes to the API across versions, but doesn't say anything about > how

Re: [prometheus-developers] Call for Consensus: node_exporter 1.0.0 release

2020-04-23 Thread Julien Pivotto
On 23 Apr 13:40, Richard Hartmann wrote: > Dear all, > > This is a call for consensus within Prometheus-team on releasing > node_exporter 1.0.0 as-is. > > node_exporter 1.0.0-rc.0 has been cut on 2020-02-20[1]. It features > experimental TLS support[2]. We are planning to use this TLS support >

Re: [prometheus-developers] Re: Call for Consensus: node_exporter 1.0.0 release

2020-04-23 Thread Brian Brazil
On Thu, 23 Apr 2020 at 12:53, Matthias Rampke wrote: > I agree, if we plan on releasing 1.0, have an RC, a security review for a > feature marked experimental doesn't need to hold things up. We should make > it clear when we consider TLS "ready for serious use" but that's for > another release.

Re: [prometheus-developers] Re: Call for Consensus: node_exporter 1.0.0 release

2020-04-23 Thread Julius Volz
Agreed as well under these circumstances. On Thu, Apr 23, 2020 at 1:53 PM Matthias Rampke wrote: > I agree, if we plan on releasing 1.0, have an RC, a security review for a > feature marked experimental doesn't need to hold things up. We should make > it clear when we consider TLS "ready for

Re: [prometheus-developers] Re: Call for Consensus: node_exporter 1.0.0 release

2020-04-23 Thread Matthias Rampke
I agree, if we plan on releasing 1.0, have an RC, a security review for a feature marked experimental doesn't need to hold things up. We should make it clear when we consider TLS "ready for serious use" but that's for another release. /MR On Thu, Apr 23, 2020 at 11:47 AM Richard Hartmann <

[prometheus-developers] Re: Call for Consensus: node_exporter 1.0.0 release

2020-04-23 Thread Richard Hartmann
Yes On Thu, Apr 23, 2020 at 1:40 PM Richard Hartmann wrote: > > Dear all, > > This is a call for consensus within Prometheus-team on releasing > node_exporter 1.0.0 as-is. > > node_exporter 1.0.0-rc.0 has been cut on 2020-02-20[1]. It features > experimental TLS support[2]. We are planning to

Re: [prometheus-developers] Call for Consensus: node_exporter 1.0.0 release

2020-04-23 Thread Ben Kochie
Yes, let's release right away. On Thu, Apr 23, 2020 at 1:41 PM Richard Hartmann < richih.mailingl...@gmail.com> wrote: > Dear all, > > This is a call for consensus within Prometheus-team on releasing > node_exporter 1.0.0 as-is. > > node_exporter 1.0.0-rc.0 has been cut on 2020-02-20[1]. It

[prometheus-developers] Call for Consensus: node_exporter 1.0.0 release

2020-04-23 Thread Richard Hartmann
Dear all, This is a call for consensus within Prometheus-team on releasing node_exporter 1.0.0 as-is. node_exporter 1.0.0-rc.0 has been cut on 2020-02-20[1]. It features experimental TLS support[2]. We are planning to use this TLS support as a template for all other exporters within and outside

Re: [prometheus-developers] Scraping metrics from Splunk Logs

2020-04-23 Thread Julius Volz
Hi Sudhakar, This is the development mailing list for Prometheus - questions about usage are better asked (and you'll get better replies) on the Prometheus users mailing list: https://groups.google.com/forum/#!forum/prometheus-users (see also https://prometheus.io/community/). Cheers, Julius On

Re: [prometheus-developers] client_golang: lenient version of promauto.Filter

2020-04-23 Thread Brian Brazil
On Wed, 22 Apr 2020 at 22:04, 'Chris Taylor' via Prometheus Developers < prometheus-developers@googlegroups.com> wrote: > Dear Prometheans, > > posting this here because the Github issue template suggested discussing > changes on the > mailing list first. > > I just discovered the

[prometheus-developers] Scraping metrics from Splunk Logs

2020-04-23 Thread 'Sudhakar Balakrishnan' via Prometheus Developers
I'm new to Prometheus and have gone through the documentation not clear on couple of things related to collecting metrics: 1. How do I scrape metrics from Splunk logs? Context: All application logs are sent to Splunk. You have the visibility of how the application is functioning based on the

Re: [prometheus-developers] Re: Structure of reference and user documentation

2020-04-23 Thread Sivan Esan
https://youtu.be/cYjF4zTJxP4 Check it out and let me know On Sat 18 Apr, 2020, 1:40 PM Julius Volz, wrote: > On Fri, Apr 17, 2020 at 5:46 PM 'Diana Payton' via Prometheus Developers < > prometheus-developers@googlegroups.com> wrote: > >> >> >>> Question is, does someone feel called upon (and

Re: [prometheus-developers] client_golang: lenient version of promauto.Filter

2020-04-23 Thread Sivan Esan
https://youtu.be/cYjF4zTJxP4 Check it out and let me know On Thu 23 Apr, 2020, 2:34 AM 'Chris Taylor' via Prometheus Developers, < prometheus-developers@googlegroups.com> wrote: > Dear Prometheans, > > posting this here because the Github issue template suggested discussing > changes on the >