Re: [prometheus-developers] Exemplar Query API query parameter

2021-04-28 Thread Ben Ye
Hi Julien, Thanks for the reply. That makes sense to me and it is very natural to implement it this way in Grafana. I am working on adding a new promtool subcommand for querying exemplars with a query flag. From the UX perspective, it is a little bit weird to let users provide promql queries inst

Re: [prometheus-developers] [python prometheus_client] is Gauge.set guaranteed to always cast as float given value?

2021-04-28 Thread Jonathan Martin, MARSS
Hi Chris, Thanks a lot for the clarification! As long as it is considered OK to give a boolean (whatever it becomes under the hood), then I'm happy. Indeed, adding a test case and official doc for using booleans makes total sense and would avoid unexpected change in that area. Best regards, Jon

Re: [prometheus-developers] Migrating away from github.com/gogo/protobuf

2021-04-28 Thread Austin Cawley-Edwards
Looks like Thanos is having a similar discussion internally: https://github.com/thanos-io/thanos/pull/4086#discussion_r617274400 On Wed, Apr 28, 2021 at 1:19 PM Austin Cawley-Edwards < austin.caw...@gmail.com> wrote: > Here's also some nice history on how Protobuf in Go has changed: > https://git

Re: [prometheus-developers] [python prometheus_client] is Gauge.set guaranteed to always cast as float given value?

2021-04-28 Thread Chris Marchbanks
Hi Jonathan, As it stands I would say that is an implementation detail that could change, for example we might treat integers differently from floats in the future. That is just the status quo, and if the community would like to see this as the official behavior we could add a test case for settin

[prometheus-developers] Exemplar Query API query parameter

2021-04-28 Thread Ben Ye
Hi Prometheus developers & maintainers, I am looking at the Exemplar API and I have one question about the query parameter. Here query supports any promql expression. But from the code

Re: [prometheus-developers] Migrating away from github.com/gogo/protobuf

2021-04-28 Thread Austin Cawley-Edwards
Here's also some nice history on how Protobuf in Go has changed: https://github.com/protocolbuffers/protobuf-go#historical-legacy And just for clarification, I'm recommending we switch to google.golang.org/protobuf (which is now the official implementation), sorry for the confusion/typo with golan

Re: [prometheus-developers] Migrating away from github.com/gogo/protobuf

2021-04-28 Thread Austin Cawley-Edwards
> > This surprised me a little, and sounds awesome - but I can't find any more > information about it. Does v1.4.0 generate code for the serialisation / > deserialisation function or still rely on Golang reflection? Does it allow > for the neat tricks to get rid of pointers and all the allocation

Re: [prometheus-developers] Migrating away from github.com/gogo/protobuf

2021-04-28 Thread Tom Wilkie
> Along with that, many of the performance boosts that are provided by gogo have been addressed in the official Go lib, golang/protobuf , as of v1.4.0 . This surprised me a little, and sounds awesome - but I can't find any

[prometheus-developers] [python prometheus_client] is Gauge.set guaranteed to always cast as float given value?

2021-04-28 Thread Jonathan Martin
Hi there, I have a question relative to Gauge and booleans, if you don't mind. I'm considering to use a gauge to reflect the evolution of a boolean value. Knowing that the set method of a Gauge cast the given value as a float, I could call directly my_gauge.set(my_bool_value), and have it set t

[prometheus-developers] Announcing the Prometheus April 2021 dev summit

2021-04-28 Thread Julien Pivotto
Hello o/ Tomorrow we will have our April 2021 dev summit, at 2pm UTC. You can find the google meet link in our public calendar: https://prometheus.io/community/ What are the Prometheus dev summits? The Prometheus dev summits are monthly virtual events where the Prometheus developers community d

Re: [prometheus-developers] Migrating away from github.com/gogo/protobuf

2021-04-28 Thread Frederic Branczyk
I'd be very happy with this. One consideration that we should take (certainly not blocking this but should keep in mind) is how this would affect immediate downstream users. Off the top of my head, I would think checking in with the Cortex and Thanos projects is probably a good idea, I know both ha