Re: [prometheus-developers] Change the implementation of labels.Builder in Prometheus

2022-05-13 Thread Brian Brazil
On Thu, 12 May 2022 at 12:56, Augustin Husson wrote: > Hi Brian, > > Thanks for your input ! > > >> A large part of the performance gains of Prometheus 2.x is attributed to >> it not using maps, so I would be extremely cautious about changing it for >> the sake of SD which is not the hot path. n

Re: [prometheus-developers] Change the implementation of labels.Builder in Prometheus

2022-05-13 Thread Bryan Boreham
Hi, I was interested to see your comments; I have been looking over the last few months at the implementation of labels.Labels and labels.Builder. I have done quite a lot of work on Go performance optimisation, maybe I can help. I took a look at

[prometheus-developers] RFC: The implementation of labels.Labels

2022-05-13 Thread Bryan Boreham
Hi, as you might infer from recent PRs I posted, I have been looking at the implementation of labels.Labels. I wanted to post a comprehensive design document, but it's been a few months and I didn't finish it, so I thought I would briefly describe the work here. Motivation: when I look at