Re: [prometheus-developers] Add collector for database/sql#DBStats

2021-03-23 Thread Julien Pivotto
On 23 Mar 20:45, Bjoern Rabenstein wrote: > On 23.03.21 14:31, Julien Pivotto wrote: > > > > I find what we do with Java quite nice: > > > > https://github.com/prometheus/client_java > > Could you be more specific what you are referring to? Client java has helpers/examples for jetty, log4j,

Re: [prometheus-developers] Add collector for database/sql#DBStats

2021-03-23 Thread Bjoern Rabenstein
On 23.03.21 14:31, Julien Pivotto wrote: > > I find what we do with Java quite nice: > > https://github.com/prometheus/client_java Could you be more specific what you are referring to? > Unfortunately for golang, it will be more difficult for at least 2 > releases, the time for go mod lazy

Re: [prometheus-developers] Add collector for database/sql#DBStats

2021-03-23 Thread Julien Pivotto
I find what we do with Java quite nice: https://github.com/prometheus/client_java Unfortunately for golang, it will be more difficult for at least 2 releases, the time for go mod lazy loading to come and make its youth sicknesses. let's not forget client_golang is one of the most used go

Re: [prometheus-developers] Add collector for database/sql#DBStats

2021-03-23 Thread Ben Kochie
I like the idea of making client_golang have more "APM" like features. I'm not sure this would be something to enable by default, but having a central place for these things makes sense to me. On Tue, Mar 23, 2021 at 11:24 AM Matthias Rampke wrote: > Ah, even before following the link I had

Re: [prometheus-developers] Add collector for database/sql#DBStats

2021-03-23 Thread Matthias Rampke
Ah, even before following the link I had the same questions as Björn: Could this be a separate thing? Does it benefit significantly from being part of the standard client_golang, or could it just as well be something people pull in on demand? I see at least two

[prometheus-developers] Add collector for database/sql#DBStats

2021-03-22 Thread Mitsuo Heijo
Hi Prometheus Developers. I was guided here from https://github.com/prometheus/client_golang/pull/848 There are several agenda items. 1. Whether client_golang should include DBStatsCollector. 2. Should the metrics be prefixed with go_... ? While the database/sql package is Go-specific, those