Re: [prosody-dev] [PATCH][0.10] muc: Allow clients to change multiple affiliations or roles at once (#345)

2017-05-01 Thread Lennart Sauerbeck
On 01.05.2017 14:48, Lennart Sauerbeck wrote: > Attached is a patch implementing atomic changes for both affiliation and > roles change requests. While taking a look at issue #337 I noticed that while the XSD for muc#admin allows changes to both affiliations and roles in the same r

Re: [prosody-dev] [PATCH][0.10] muc: Allow clients to change multiple affiliations or roles at once (#345)

2017-04-22 Thread Lennart Sauerbeck
On 17.04.2017 22:21, Matthew Wild wrote: > On 17 April 2017 at 19:34, Kim Alvefur wrote: >> On Mon, Apr 17, 2017 at 02:32:22PM +0100, Matthew Wild wrote: >>> - Treat the request as an atomic change: succeed for all, or fail >>> all (i.e. if one of the JIDs is malformed, don't

Re: [prosody-dev] [PATCH][0.10] muc: Allow clients to change multiple affiliations or roles at once (#345)

2017-04-21 Thread Lennart Sauerbeck
On 17.04.2017 22:21, Matthew Wild wrote: > On 17 April 2017 at 19:34, Kim Alvefur wrote: >> On Mon, Apr 17, 2017 at 02:32:22PM +0100, Matthew Wild wrote: >>> - Treat the request as an atomic change: succeed for all, or fail >>> all (i.e. if one of the JIDs is malformed, don't

Re: [prosody-dev] [PATCH][0.10] muc: Allow clients to change multiple affiliations or roles at once (#345)

2017-04-17 Thread Lennart Sauerbeck
On 17.04.2017 15:32, Matthew Wild wrote: > On 17 April 2017 at 13:43, Lennart Sauerbeck > <de...@lennart.sauerbeck.org> wrote: >> - Regarding the error handling in lines 49, 55 and in-tree 801 (the last >> one is not in the patch because I did no changes there): Is it okay