There are privacy issues with including these options by default because it
can result in unexpected content being shared with arbitrary app
developers. Additionally I added information about the configuration of
these options in the README. mod_push <https://github.com/royneary/mod_push>
also defaults these values to false.
# HG changeset patch
# User Chris Ballinger <chrisballin...@gmail.com>
# Date 1464901642 25200
# Thu Jun 02 14:07:22 2016 -0700
# Node ID eb53a830864ccc7c5303423d7bae4ac8795418f9
# Parent 90a444ccaa8edf373ff089fc4bad2c8eb4bed5f3
mod_cloud_notify: default false for sending body and sender
diff -r 90a444ccaa8e -r eb53a830864c mod_cloud_notify/README.markdown
--- a/mod_cloud_notify/README.markdown Wed Jun 01 22:33:51 2016 +0200
+++ b/mod_cloud_notify/README.markdown Thu Jun 02 14:07:22 2016 -0700
@@ -18,6 +18,16 @@
App servers are notified about offline messages.
+Configuration
+=============
+
+ Option Default Description
+ ------------------------------ -----------------
-----------------------------------------------------------------------------------------
+ `push_notification_with_body` false Whether or not to send the
message body to remote pubsub node.
+ `push_notification_with_sender` false Whether or
not to send the message sender to remote pubsub node.
+
+There are privacy implications for enabling these options because
plaintext content and metadata will be shared with centralized servers (the
pubsub node) run by arbitrary app developers.
+
Installation
============
diff -r 90a444ccaa8e -r eb53a830864c mod_cloud_notify/mod_cloud_notify.lua
--- a/mod_cloud_notify/mod_cloud_notify.lua Wed Jun 01 22:33:51 2016 +0200
+++ b/mod_cloud_notify/mod_cloud_notify.lua Thu Jun 02 14:07:22 2016 -0700
@@ -11,8 +11,8 @@
local xmlns_push = "urn:xmpp:push:0";
-- configuration
-local include_body = module:get_option("push_notification_with_body",
true);
-local include_sender = module:get_option("push_notification_with_sender",
true);
+local include_body = module:get_option("push_notification_with_body",
false);
+local include_sender = module:get_option("push_notification_with_sender",
false);
-- For keeping state across reloads
local push_enabled = module:shared("push-enabled-users");
--
You received this message because you are subscribed to the Google Groups
"prosody-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to prosody-dev+unsubscr...@googlegroups.com.
To post to this group, send email to prosody-dev@googlegroups.com.
Visit this group at https://groups.google.com/group/prosody-dev.
For more options, visit https://groups.google.com/d/optout.
