Re: [protobuf] Re: Generating code via protoc plugin without resolving indirect imports

2023-04-20 Thread 'Adam Cozzette' via Protocol Buffers
As far as I know, the direct deps should be sufficient for parsing .proto files and generating descriptors from them. The one thing I'm not sure about is parsing of custom options; I don't know if we allow proto files to set custom options and reference fields that aren't in the direct deps. For

[protobuf] Re: java.lang.NoSuchMethodError: 'com.google.protobuf.Timestamp com.google.protobuf.Timestamp$Builder.build()'

2023-04-20 Thread 'Jerry Berg' via Protocol Buffers
Hi Daniele, I'm having difficulty reproducing this issue. Do you have a project on GitHub or some other location where I can clone it and try it out? Thanks, Jerry On Tuesday, April 18, 2023 at 1:29:11 AM UTC-6 Daniele Segato wrote: > anyone? > > On Thursday, March 2, 2023 at 11:35:54 AM

Re: [protobuf] Is Resulting Binary from Changing Proto Definition Source (From Nested to Non-Nested) for Fields initialization Backward-Compatible?

2023-04-20 Thread 'Timo' via Protocol Buffers
google.protobuf.Any stores the qualified name of the packed message as a string. It is only a breaking change if InnerProto was stored in Any, not if OuterProto was stored. On Thursday, April 20, 2023 at 8:49:17 AM UTC+2 Marc Gravell wrote: > As long as you aren't using `Any`: then at the

Re: [protobuf] Is Resulting Binary from Changing Proto Definition Source (From Nested to Non-Nested) for Fields initialization Backward-Compatible?

2023-04-20 Thread Marc Gravell
As long as you aren't using `Any`: then at the binary payload data it won't be visible. Any existing code that uses the generated types will need to be updated, obviously. On Thu, 20 Apr 2023, 07:00 'Felik' via Protocol Buffers, < protobuf@googlegroups.com> wrote: > Hello, > > I came to

[protobuf] Is Resulting Binary from Changing Proto Definition Source (From Nested to Non-Nested) for Fields initialization Backward-Compatible?

2023-04-20 Thread 'Felik' via Protocol Buffers
Hello, I came to understand that the binary serialization only concern of field identifiying number (hence renaming field and message is backward compatible). I would like to confirm my understanding if following case is also backward compatible (I could not find any resource that discuss