Hi there -- sorry for the delay on your PR, a couple guys are OOTO right now so we're a bit backed up. I just merged it.
In general, we should be monitoring PR's and not letting them sit too long. A conversation first can be good if the change is involved, but for simple changes like this just submitting the PR should be enough. Thanks, Josh On Wednesday, February 10, 2016 at 7:55:55 AM UTC-8, Josh Humphries wrote: > > The protoc compiler emits a warning message whenever it encounters a proto > file that has no syntax level declared. But the warning doesn't indicate > the filename. I'd like our builds to be warning-free. But with a make task > that builds *lots* of protos at once, it's a total nuisance to find the > offending file. The protoc compiler really should just indicate the name of > the file in the warning. > > I opened a pull request a few days ago to fix this: > https://github.com/google/protobuf/pull/1217 > It hasn't gotten any attention. > > What's the best policy for trying to submit changes? Should I start a > discussion on this group first, to give visibility to it? Or is there some > time window I should allow (few days?) before expecting any > attention/comments on a pull request? > > Thanks in advance. > > ---- > *Josh Humphries* > Manager, Shared Systems | Platform Engineering > Atlanta, GA | 678-400-4867 > *Square* (www.squareup.com) > -- You received this message because you are subscribed to the Google Groups "Protocol Buffers" group. To unsubscribe from this group and stop receiving emails from it, send an email to protobuf+unsubscr...@googlegroups.com. To post to this group, send email to protobuf@googlegroups.com. Visit this group at https://groups.google.com/group/protobuf. For more options, visit https://groups.google.com/d/optout.
