The implementation of tr1::hashtable on OSX 1.5 (GCC 4.0.1) is broken.
find_node() is apparently not declared const, meaning calling find() on a
const hash_map does not compile.
/cry
On Mon, Dec 21, 2009 at 11:24 AM, Kenton Varda ken...@google.com wrote:
Arrghh. I didn't mean to add that...
Worked around with r291. Must test on all platforms all over again...
sigh.
On Wed, Jan 6, 2010 at 8:29 PM, Kenton Varda ken...@google.com wrote:
The implementation of tr1::hashtable on OSX 1.5 (GCC 4.0.1) is broken.
find_node() is apparently not declared const, meaning calling find() on a
Oh, funky. Sorry, I don't have a Mac to test. Do you have automated
builds going?
From my experience gcc 4.0.x versions were somewhat buggy, while the
4.1.x branch is reasonable. I am surprised that std::tr1 was actually
present in that STL... Perhaps it is an Apple-brewed combo?
Oleg.
On Wed,
On Wed, Jan 6, 2010 at 9:02 PM, Oleg Smolsky oleg.smol...@gmail.com wrote:
Oh, funky. Sorry, I don't have a Mac to test. Do you have automated
builds going?
Only on Linux, unfortunately. Well, and the Solaris one that Monty runs. I
suppose I should see about setting up an array of automatic
On Wed, Jan 6, 2010 at 9:40 PM, Monty Taylor mord...@inaugust.com wrote:
Kenton Varda wrote:
On Wed, Jan 6, 2010 at 9:02 PM, Oleg Smolsky oleg.smol...@gmail.com
mailto:oleg.smol...@gmail.com wrote:
Oh, funky. Sorry, I don't have a Mac to test. Do you have automated
builds
Apparently not, as tr1::hashchar* treats values as pointers, not strings.
:/
On Mon, Dec 21, 2009 at 10:26 AM, Kenton Varda ken...@google.com wrote:
Thanks for the fix! Unfortunately your re-ordering makes it hard for me to
see what actually changed. Also, your style doesn't match the
Yes, I see now. But your solution -- constructing string objects every time
the hash function is run -- is very slow. I've submitted r259 with this
implementation instead:
template
struct hashconst char* {
inline size_t operator()(const char* str) const {
size_t result = 0;
for (;
Alright, thanks.
Oleg.
On Dec 21, 10:59 am, Kenton Varda ken...@google.com wrote:
Yes, I see now. But your solution -- constructing string objects every time
the hash function is run -- is very slow. I've submitted r259 with this
implementation instead:
template
struct hashconst char* {
Arrghh. I didn't mean to add that... I just wrote it so that I could hit
F3 and have eclipse show me the file, then forgot to delete it. Fixed.
Thanks for pointing that out; I'm not normally so sloppy.
On Mon, Dec 21, 2009 at 11:19 AM, Oleg Smolsky oleg.smol...@gmail.comwrote:
BTW, you've
