Re: Emulate hash_map using map when necessary.

2008-09-19 Thread Kenton Varda
Kenton Varda [mailto:[EMAIL PROTECTED] > *Envoyé :* 18 septembre 2008 17:13 > *À :* [EMAIL PROTECTED]; Choinière, Vincent; protobuf@googlegroups.com > *Objet :* Re: Emulate hash_map using map when necessary. > > > > Any comments on the code? If not, I'll go ahead and submit

RE: Emulate hash_map using map when necessary.

2008-09-19 Thread Choiniere.Vincent
You can submit it, the code is correct. Thank you. De : Kenton Varda [mailto:[EMAIL PROTECTED] Envoyé : 18 septembre 2008 17:13 À : [EMAIL PROTECTED]; Choinière, Vincent; protobuf@googlegroups.com Objet : Re: Emulate hash_map using map when

Re: Emulate hash_map using map when necessary.

2008-09-18 Thread Kenton Varda
Any comments on the code? If not, I'll go ahead and submit it. On Thu, Sep 18, 2008 at 1:59 PM, <[EMAIL PROTECTED]> wrote: > Yes, is working. > > ==> Test ok on Tru64 (with some other changed in the code for the > compiler) > ==> Test ok on Windows Visual Studio 2005 > > Issue 5682 can be ignore

Re: Emulate hash_map using map when necessary.

2008-09-18 Thread choiniere . vincent
Yes, is working. ==> Test ok on Tru64 (with some other changed in the code for the compiler) ==> Test ok on Windows Visual Studio 2005 Issue 5682 can be ignored... http://codereview.appspot.com/5683 --~--~-~--~~~---~--~~ You received this message because you are

Emulate hash_map using map when necessary.

2008-09-18 Thread kenton
Reviewers: choiniere.vincent, Description: Hi Vincent, After looking at your change I came up with an alternative version. Can you try this out and let me know if it works for you? Please review this at http://codereview.appspot.com/5683 Affected files: src/google/protobuf/stubs/hash.h I