Re: 2.2.0 make check failures on Solaris 10 sparc32 (problems with zlib?)

2009-09-15 Thread Kenton Varda
Committed as rev 228. Thanks. On Mon, Sep 14, 2009 at 7:46 PM, Oliver Jowett oliver.jow...@gmail.comwrote: Kenton Varda wrote: Can you review the diff, too? At Google we have a policy of reviewing all changes. Just tell me if it looks OK to you, or if there's anything you'd recommend

Re: 2.2.0 make check failures on Solaris 10 sparc32 (problems with zlib?)

2009-08-28 Thread Kenton Varda
I'm planning to submit this when I get a free moment (it's been a very busy week). In the meantime, have you signed the CLA? http://code.google.com/legal/individual-cla-v1.0.html -- If you own copyright on this patch. http://code.google.com/legal/individual-cla-v1.0.html

Re: 2.2.0 make check failures on Solaris 10 sparc32 (problems with zlib?)

2009-08-22 Thread Kenton Varda
Run configure --without-zlib to disable zlib support. Alternatively, fix it and send me a patch. :) On Fri, Aug 21, 2009 at 8:44 PM, Oliver Jowett oliver.jow...@gmail.comwrote: Oliver Jowett wrote: The tests start failing here: [--] 14 tests from IoTest [ RUN ]

Re: 2.2.0 make check failures on Solaris 10 sparc32 (problems with zlib?)

2009-08-22 Thread Oliver Jowett
Kenton Varda wrote: Run configure --without-zlib to disable zlib support. Alternatively, fix it and send me a patch. :) I took a look at fixing it in gzip_stream.{cc,h} (conditionally removing GZIP format so you'd get compile errors if you tried to use that on a system with an old zlib), but