Re: [protobuf] Failed to parse map

2017-06-06 Thread Qian Zhang
It seems the URL http://google3/experimental/users/acozzette/map_reflection_test.cc?rcl=158157727 is not working, I can not access it :-( Regards, Qian Zhang On Wed, Jun 7, 2017 at 1:32 AM, Adam Cozzette wrote: > Here's an example of how to do it: http://google3/ >

Re: [protobuf] Failed to parse map

2017-06-06 Thread 'Adam Cozzette' via Protocol Buffers
Here's an example of how to do it: http://google3/experimental/users/acozzette/map_reflection_test.cc?rcl=158157727 It's a bit clunky because you just have to reflect on the map field like you would a repeated field, but it works. On Mon, Jun 5, 2017 at 6:08 PM, Qian Zhang

[protobuf] Re: should i commit *.pb.cc and *.pb.h to my source code repository?

2017-06-06 Thread KarrokDC
Best practice would probably be to incorporate the generation from proto into cmake (or other build system) to ensure you're always up to date. This way you have a good chance (not 100% foolproof) that compilation will start throwing errors after a .proto update if the code using it is not

[protobuf] Re: should i commit *.pb.cc and *.pb.h to my source code repository?

2017-06-06 Thread kant kodali
I don't see a good reason to check in to the source code repository. On Monday, June 5, 2017 at 7:08:33 PM UTC-7, Koo Yak wrote: > > Hi, > > I'm a little confused. > > Should I commit *.pb.cc and *.pb.h files to my source code repository, or > generate them just before compile? > > Which is the