Re: [protobuf] Typos in the C++ Tutorial
On Friday, February 10, 2017 at 7:46:51 PM UTC+1, Feng Xiao wrote: > > Thanks for the report. Can you create a github issue for this? > Unfortunately the developer guide is not hosted on github and we can't > accept PR for it. > Ok, done: https://github.com/google/protobuf/issues/2707 -- You received this message because you are subscribed to the Google Groups "Protocol Buffers" group. To unsubscribe from this group and stop receiving emails from it, send an email to protobuf+unsubscr...@googlegroups.com. To post to this group, send email to protobuf@googlegroups.com. Visit this group at https://groups.google.com/group/protobuf. For more options, visit https://groups.google.com/d/optout.
Re: [protobuf] Typos in the C++ Tutorial
On Wed, Feb 8, 2017 at 2:18 PM, Jacopo Notarstefano <
jacopo.notarstef...@gmail.com> wrote:
> Hi,
>
> I was reading https://developers.google.com/protocol-buffers/
> docs/cpptutorial and I think I found a few typos in the code examples.
>
>
> For example, in https://developers.google.com/protocol-buffers/docs/
> cpptutorial#writing-a-message the code reads
>
> tutorial::Person::PhoneNumber* phone_number = person->add_phone();
>
> but it should read
>
> tutorial::Person::PhoneNumber* phone_number = person->add_phones();
>
> and
>
> PromptForAddress(address_book.add_person());
>
> should be
>
> PromptForAddress(address_book.add_people());
>
>
> Similarly, in https://developers.google.com/protocol-buffers/docs/
> cpptutorial#reading-a-message the code reads
>
> for (int i = 0; i < address_book.person_size(); i++) {
>
> but it should read
>
> for (int i = 0; i < address_book.people_size(); i++) {
>
> and
>
> const tutorial::Person& person = address_book.person(i);
>
> should be
>
> const tutorial::Person& person = address_book.people(i);
>
>
> Moreover, I would consider adding
>
> syntax = "proto2"
>
> to the top of https://developers.google.com/protocol-buffers/docs/
> cpptutorial#defining-your-protocol-format, so that no scary warning is
> printed if one installs a recent version of protobuf.
>
>
> I would have submitted these changes as a proper PR, but I couldn't find
> the repo that generates the documentation at
> https://developers.google.com/protocol-buffers/. Does it exist? If so,
> I'd be happy to convert this email to a PR.
>
Thanks for the report. Can you create a github issue for this?
Unfortunately the developer guide is not hosted on github and we can't
accept PR for it.
>
> Cheers,
> Jacopo
>
> --
> You received this message because you are subscribed to the Google Groups
> "Protocol Buffers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to protobuf+unsubscr...@googlegroups.com.
> To post to this group, send email to protobuf@googlegroups.com.
> Visit this group at https://groups.google.com/group/protobuf.
> For more options, visit https://groups.google.com/d/optout.
>
--
You received this message because you are subscribed to the Google Groups
"Protocol Buffers" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at https://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.
Re: [protobuf] Typos in the C++ Tutorial
Hello,
Wouldn't it be nice if you could tell protoc to use a different singular
and plural form!
Thanks,
Mohamed Koubaa
Software Developer
ANSYS Inc
On Wed, Feb 8, 2017 at 5:18 PM, Jacopo Notarstefano <
jacopo.notarstef...@gmail.com> wrote:
> Hi,
>
> I was reading https://developers.google.com/protocol-buffers/
> docs/cpptutorial and I think I found a few typos in the code examples.
>
>
> For example, in https://developers.google.com/protocol-buffers/docs/
> cpptutorial#writing-a-message the code reads
>
> tutorial::Person::PhoneNumber* phone_number = person->add_phone();
>
> but it should read
>
> tutorial::Person::PhoneNumber* phone_number = person->add_phones();
>
> and
>
> PromptForAddress(address_book.add_person());
>
> should be
>
> PromptForAddress(address_book.add_people());
>
>
> Similarly, in https://developers.google.com/protocol-buffers/docs/
> cpptutorial#reading-a-message the code reads
>
> for (int i = 0; i < address_book.person_size(); i++) {
>
> but it should read
>
> for (int i = 0; i < address_book.people_size(); i++) {
>
> and
>
> const tutorial::Person& person = address_book.person(i);
>
> should be
>
> const tutorial::Person& person = address_book.people(i);
>
>
> Moreover, I would consider adding
>
> syntax = "proto2"
>
> to the top of https://developers.google.com/protocol-buffers/docs/
> cpptutorial#defining-your-protocol-format, so that no scary warning is
> printed if one installs a recent version of protobuf.
>
>
> I would have submitted these changes as a proper PR, but I couldn't find
> the repo that generates the documentation at
> https://developers.google.com/protocol-buffers/. Does it exist? If so,
> I'd be happy to convert this email to a PR.
>
> Cheers,
> Jacopo
>
> --
> You received this message because you are subscribed to the Google Groups
> "Protocol Buffers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to protobuf+unsubscr...@googlegroups.com.
> To post to this group, send email to protobuf@googlegroups.com.
> Visit this group at https://groups.google.com/group/protobuf.
> For more options, visit https://groups.google.com/d/optout.
>
--
You received this message because you are subscribed to the Google Groups
"Protocol Buffers" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at https://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.
