[protobuf] Issue 504 in protobuf: typo in file cpp_file.cc, line 623

2013-04-19 Thread protobuf
Status: New Owner: liuj...@google.com Labels: Type-Defect Priority-Medium New issue 504 by j...@ib-weinhardt.de: typo in file cpp_file.cc, line 623 http://code.google.com/p/protobuf/issues/detail?id=504 What steps will reproduce the problem? 1. set Compiler Flag GOOGLE_PROTOBUF_NO_STATIC_INITIAL

[protobuf] Re: Issue 321 in protobuf: Remove final on AbstractMessage.toString

2013-04-19 Thread protobuf
Comment #1 on issue 321 by steve.f@gmail.com: Remove final on AbstractMessage.toString http://code.google.com/p/protobuf/issues/detail?id=321 Agree! Our messages are very large and I want to be able to trim them down. -- You received this message because this project is configured to se

[protobuf] Re: Issue 504 in protobuf: typo in file cpp_file.cc, line 623

2013-04-19 Thread protobuf
Comment #1 on issue 504 by j...@ib-weinhardt.de: typo in file cpp_file.cc, line 623 http://code.google.com/p/protobuf/issues/detail?id=504 Sorry. Of course the compiler error occurs at the generated output, not at cpp_file.cc. -- You received this message because this project is configure

[protobuf] Protocol Buffers 2.5.0: unit test bug with DOS line endings - missing carriage returns

2013-04-19 Thread Roy Fleck
This bug only seems to happen if the line endings for all the files have been converted from Unix to DOS line endings. In other words, the line endings have been changed from "\n" to "\r\n". Steps: 1) Download the latest version of Protocol Buffers (version 2.5.0) 2) Convert line endings from

[protobuf] Re: Protocol Buffers 2.5.0: unit test bug with DOS line endings - missing carriage returns

2013-04-19 Thread Feng Xiao
I don't think this is a bug. The tests compare golden data files with the actual output. In your case the golden files have been changed, which then causes the test failure. Reverting the change to these files should solve the problem. On Friday, April 19, 2013 12:30:45 PM UTC-7, Roy Fleck wrot

[protobuf] Re: Protocol Buffers 2.5.0: unit test bug with DOS line endings - missing carriage returns

2013-04-19 Thread Roy Fleck
Yes, reverting the line ending change does fix the problem. I just wanted to point out the issue so that someone else does not spend a lot of time wondering why their unit tests are failing. Perhaps the documentation with the SDK should be updated with a warning? On Friday, April 19, 2013 2