Re: [protobuf] Re: Compiler error with GCC targeting ARM - Atomic32 vs AtomicWord

2017-08-10 Thread 'Feng Xiao' via Protocol Buffers
On Thu, Aug 10, 2017 at 9:53 AM, Brad Larson wrote: > > > On Wednesday, August 9, 2017 at 1:13:54 PM UTC-5, Feng Xiao wrote: >> >> Hi Brad, can you send your patch as a pull request? It's easier to review >> the diff there. >> > > Hi Feng, thank you for the reply. I really

Re: [protobuf] Re: Compiler error with GCC targeting ARM - Atomic32 vs AtomicWord

2017-08-10 Thread Brad Larson
On Wednesday, August 9, 2017 at 1:13:54 PM UTC-5, Feng Xiao wrote: > > Hi Brad, can you send your patch as a pull request? It's easier to review > the diff there. > Hi Feng, thank you for the reply. I really didn't have a fix in mind and was looking for more of a discussion on what a better

Re: [protobuf] Re: Compiler error with GCC targeting ARM - Atomic32 vs AtomicWord

2017-08-09 Thread 'Feng Xiao' via Protocol Buffers
Hi Brad, can you send your patch as a pull request? It's easier to review the diff there. On Wed, Aug 9, 2017 at 8:27 AM, Brad Larson wrote: > > > On Monday, August 7, 2017 at 1:13:46 PM UTC-5, Brad Larson wrote: >> >> Hello, I'm getting a compiler error when using GCC to

[protobuf] Re: Compiler error with GCC targeting ARM - Atomic32 vs AtomicWord

2017-08-09 Thread Brad Larson
On Monday, August 7, 2017 at 1:13:46 PM UTC-5, Brad Larson wrote: > > Hello, I'm getting a compiler error when using GCC to target ARM > platforms. I've patched this locally, but would like to upstream my patch > and am not sure on the best generally-acceptable solution. > >