[protobuf] Re: Issue 559 in protobuf: performance enhancement: use String#getBytes(Charset) instead of getBytes(String)
Comment #10 on issue 559 by mellowaredev: performance enhancement: use String#getBytes(Charset) instead of getBytes(String) http://code.google.com/p/protobuf/issues/detail?id=559 Excellent thanks for the update! -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "Protocol Buffers" group. To unsubscribe from this group and stop receiving emails from it, send an email to protobuf+unsubscr...@googlegroups.com. To post to this group, send email to protobuf@googlegroups.com. Visit this group at http://groups.google.com/group/protobuf. For more options, visit https://groups.google.com/groups/opt_out.
[protobuf] Re: Issue 559 in protobuf: performance enhancement: use String#getBytes(Charset) instead of getBytes(String)
Comment #8 on issue 559 by xiaof...@google.com: performance enhancement: use String#getBytes(Charset) instead of getBytes(String) http://code.google.com/p/protobuf/issues/detail?id=559 We have been working on this project actively inside Google, but you won't see much activity here until we start to make another open-source release, -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "Protocol Buffers" group. To unsubscribe from this group and stop receiving emails from it, send an email to protobuf+unsubscr...@googlegroups.com. To post to this group, send email to protobuf@googlegroups.com. Visit this group at http://groups.google.com/group/protobuf. For more options, visit https://groups.google.com/groups/opt_out.
[protobuf] Re: Issue 559 in protobuf: performance enhancement: use String#getBytes(Charset) instead of getBytes(String)
Comment #9 on issue 559 by xiaof...@google.com: performance enhancement: use String#getBytes(Charset) instead of getBytes(String) http://code.google.com/p/protobuf/issues/detail?id=559 We have been working on this project actively inside Google, but you won't see much activity here until we start to make another open-source release, -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "Protocol Buffers" group. To unsubscribe from this group and stop receiving emails from it, send an email to protobuf+unsubscr...@googlegroups.com. To post to this group, send email to protobuf@googlegroups.com. Visit this group at http://groups.google.com/group/protobuf. For more options, visit https://groups.google.com/groups/opt_out.
[protobuf] Re: Issue 559 in protobuf: performance enhancement: use String#getBytes(Charset) instead of getBytes(String)
Comment #7 on issue 559 by mellowaredev: performance enhancement: use String#getBytes(Charset) instead of getBytes(String) http://code.google.com/p/protobuf/issues/detail?id=559 Is this project dead? I am seeing zero activity on the code base since last April? there are tons of great patches and suggestions on this issues page and none of them seem to be acted upon? Can we get a roadmap? -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "Protocol Buffers" group. To unsubscribe from this group and stop receiving emails from it, send an email to protobuf+unsubscr...@googlegroups.com. To post to this group, send email to protobuf@googlegroups.com. Visit this group at http://groups.google.com/group/protobuf. For more options, visit https://groups.google.com/groups/opt_out.
[protobuf] Re: Issue 559 in protobuf: performance enhancement: use String#getBytes(Charset) instead of getBytes(String)
Comment #6 on issue 559 by xiaof...@google.com: performance enhancement: use String#getBytes(Charset) instead of getBytes(String) http://code.google.com/p/protobuf/issues/detail?id=559 We'll fix accepted issues before next release, which probably will come early 2014. You can submit a patch if you'd like get it fixed in trunk sooner than that. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "Protocol Buffers" group. To unsubscribe from this group and stop receiving emails from it, send an email to protobuf+unsubscr...@googlegroups.com. To post to this group, send email to protobuf@googlegroups.com. Visit this group at http://groups.google.com/group/protobuf. For more options, visit https://groups.google.com/groups/opt_out.
[protobuf] Re: Issue 559 in protobuf: performance enhancement: use String#getBytes(Charset) instead of getBytes(String)
Comment #5 on issue 559 by phraktle: performance enhancement: use String#getBytes(Charset) instead of getBytes(String) http://code.google.com/p/protobuf/issues/detail?id=559 Are there plans to incorporate this? -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "Protocol Buffers" group. To unsubscribe from this group and stop receiving emails from it, send an email to protobuf+unsubscr...@googlegroups.com. To post to this group, send email to protobuf@googlegroups.com. Visit this group at http://groups.google.com/group/protobuf. For more options, visit https://groups.google.com/groups/opt_out.
[protobuf] Re: Issue 559 in protobuf: performance enhancement: use String#getBytes(Charset) instead of getBytes(String)
Comment #4 on issue 559 by phraktle: performance enhancement: use String#getBytes(Charset) instead of getBytes(String) http://code.google.com/p/protobuf/issues/detail?id=559 Indeed, the returns are diminishing with longer strings. But there's no downside :) n diff 115% 10 10% 100 5% 1000 1% -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "Protocol Buffers" group. To unsubscribe from this group and stop receiving emails from it, send an email to protobuf+unsubscr...@googlegroups.com. To post to this group, send email to protobuf@googlegroups.com. Visit this group at http://groups.google.com/group/protobuf. For more options, visit https://groups.google.com/groups/opt_out.
[protobuf] Re: Issue 559 in protobuf: performance enhancement: use String#getBytes(Charset) instead of getBytes(String)
Comment #3 on issue 559 by xiaof...@google.com: performance enhancement: use String#getBytes(Charset) instead of getBytes(String) http://code.google.com/p/protobuf/issues/detail?id=559 How large is the String in your benchmark? I expect the performance improvement ratio differs for different sizes of Strings as the overhead of retrieving Charset from its name is constant. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "Protocol Buffers" group. To unsubscribe from this group and stop receiving emails from it, send an email to protobuf+unsubscr...@googlegroups.com. To post to this group, send email to protobuf@googlegroups.com. Visit this group at http://groups.google.com/group/protobuf. For more options, visit https://groups.google.com/groups/opt_out.
[protobuf] Re: Issue 559 in protobuf: performance enhancement: use String#getBytes(Charset) instead of getBytes(String)
Comment #2 on issue 559 by phraktle: performance enhancement: use String#getBytes(Charset) instead of getBytes(String) http://code.google.com/p/protobuf/issues/detail?id=559 The benchmark was a Caliper test comparing String#getBytes(Charset) vs String#getBytes(String). How this translates into overall improvements depends on what portion of the protobufs in the workload consist of Strings (quite a lot in our use-case). -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "Protocol Buffers" group. To unsubscribe from this group and stop receiving emails from it, send an email to protobuf+unsubscr...@googlegroups.com. To post to this group, send email to protobuf@googlegroups.com. Visit this group at http://groups.google.com/group/protobuf. For more options, visit https://groups.google.com/groups/opt_out.
[protobuf] Re: Issue 559 in protobuf: performance enhancement: use String#getBytes(Charset) instead of getBytes(String)
Updates: Status: Accepted Owner: xiaof...@google.com Comment #1 on issue 559 by xiaof...@google.com: performance enhancement: use String#getBytes(Charset) instead of getBytes(String) http://code.google.com/p/protobuf/issues/detail?id=559 Can you share more information on the benchmarks you use? ~10% sounds very impressive but it depends on how you benchmark it. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "Protocol Buffers" group. To unsubscribe from this group and stop receiving emails from it, send an email to protobuf+unsubscr...@googlegroups.com. To post to this group, send email to protobuf@googlegroups.com. Visit this group at http://groups.google.com/group/protobuf. For more options, visit https://groups.google.com/groups/opt_out.
