[protobuf] Re: Issue 607 in protobuf: Replace TSan API declarations in atomicops_internals_tsan.h with a header inclusion
Comment #8 on issue 607 by gli...@chromium.org: Replace TSan API declarations in atomicops_internals_tsan.h with a header inclusion https://code.google.com/p/protobuf/issues/detail?id=607 Niall, which Clang version are you using? Clang 3.5 must have this header (in fact we've just checked that), Clang 3.4 indeed does not. Feng, do you think we need some check for Clang version around this header? Perhaps something along the lines of: (__clang_major__ 3) || (__clang_major__ == 3 __clang_minor__ 4) -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups Protocol Buffers group. To unsubscribe from this group and stop receiving emails from it, send an email to protobuf+unsubscr...@googlegroups.com. To post to this group, send email to protobuf@googlegroups.com. Visit this group at http://groups.google.com/group/protobuf. For more options, visit https://groups.google.com/d/optout.
[protobuf] Re: Issue 607 in protobuf: Replace TSan API declarations in atomicops_internals_tsan.h with a header inclusion
Comment #9 on issue 607 by nialldouglas14: Replace TSan API declarations in atomicops_internals_tsan.h with a header inclusion https://code.google.com/p/protobuf/issues/detail?id=607 I would assume at the time of report I would be running 3.4 as 3.5 wasn't out yet. Actually, until that change allowing multiple clang versions to coexist hits the main apt repos, I still can't install clang 3.5 :( Niall -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups Protocol Buffers group. To unsubscribe from this group and stop receiving emails from it, send an email to protobuf+unsubscr...@googlegroups.com. To post to this group, send email to protobuf@googlegroups.com. Visit this group at http://groups.google.com/group/protobuf. For more options, visit https://groups.google.com/d/optout.
[protobuf] Re: Issue 607 in protobuf: Replace TSan API declarations in atomicops_internals_tsan.h with a header inclusion
Updates: Owner: xiaof...@google.com Comment #10 on issue 607 by xiaof...@google.com: Replace TSan API declarations in atomicops_internals_tsan.h with a header inclusion https://code.google.com/p/protobuf/issues/detail?id=607 Yes, I think we need to make the header work on Clang 3.4 as well. Something like: #if (__clang_major__ 3) || (__clang_major__ == 3 __clang_minor__ 4) #include sanitizer/tsan_interface_atomic.h #else ... atomicops declarations for 3.4 and older... #endif Could you help make this change? We moved to github and you can send us a pull request here: https://github.com/google/protobuf/pulls -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups Protocol Buffers group. To unsubscribe from this group and stop receiving emails from it, send an email to protobuf+unsubscr...@googlegroups.com. To post to this group, send email to protobuf@googlegroups.com. Visit this group at http://groups.google.com/group/protobuf. For more options, visit https://groups.google.com/d/optout.
[protobuf] Re: Issue 607 in protobuf: Replace TSan API declarations in atomicops_internals_tsan.h with a header inclusion
Comment #11 on issue 607 by nialldouglas14: Replace TSan API declarations in atomicops_internals_tsan.h with a header inclusion https://code.google.com/p/protobuf/issues/detail?id=607 I can verify someone else's work after they have tested it themselves. I don't believe I am authorised by my current client to do the work myself. Niall -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups Protocol Buffers group. To unsubscribe from this group and stop receiving emails from it, send an email to protobuf+unsubscr...@googlegroups.com. To post to this group, send email to protobuf@googlegroups.com. Visit this group at http://groups.google.com/group/protobuf. For more options, visit https://groups.google.com/d/optout.
[protobuf] Re: Issue 607 in protobuf: Replace TSan API declarations in atomicops_internals_tsan.h with a header inclusion
Comment #5 on issue 607 by nialldouglas14: Replace TSan API declarations in atomicops_internals_tsan.h with a header inclusion http://code.google.com/p/protobuf/issues/detail?id=607 Can you revert this patch please? I don't have the header file sanitizer/tsan_interface_atomic.h on my Ubuntu 12.04 LTS nor my Ubuntu 14.04 LTS installs. I installed clang from Launchpad PPA for 12.04 whereas it's from the main repos for 14.04, they obviously don't ship this header on Ubuntu clangs. Niall -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups Protocol Buffers group. To unsubscribe from this group and stop receiving emails from it, send an email to protobuf+unsubscr...@googlegroups.com. To post to this group, send email to protobuf@googlegroups.com. Visit this group at http://groups.google.com/group/protobuf. For more options, visit https://groups.google.com/d/optout.
[protobuf] Re: Issue 607 in protobuf: Replace TSan API declarations in atomicops_internals_tsan.h with a header inclusion
Comment #6 on issue 607 by xiaof...@google.com: Replace TSan API declarations in atomicops_internals_tsan.h with a header inclusion http://code.google.com/p/protobuf/issues/detail?id=607 Hi Niall, Do you mean the Clang version you installed supports ThreadSanitizer but without header file sanitizer/tsan_interface_atomic.h? You shouldn't need this header file unless you compile protobuf with ThreadSanitizer enabled. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups Protocol Buffers group. To unsubscribe from this group and stop receiving emails from it, send an email to protobuf+unsubscr...@googlegroups.com. To post to this group, send email to protobuf@googlegroups.com. Visit this group at http://groups.google.com/group/protobuf. For more options, visit https://groups.google.com/d/optout.
[protobuf] Re: Issue 607 in protobuf: Replace TSan API declarations in atomicops_internals_tsan.h with a header inclusion
Comment #7 on issue 607 by nialldouglas14: Replace TSan API declarations in atomicops_internals_tsan.h with a header inclusion http://code.google.com/p/protobuf/issues/detail?id=607 Correct, Ubuntu's clang supports ThreadSanitiser but without the header file mentioned. You can see the CI failure when latest protobuf was merged at https://ci.nedprod.com/job/Maidsafe%20Sanitise%20Linux64%20clang%203.4/45/. I have since reverted this patch in our copy of protobuf, all unit tests are back to passing. That particular CI slave is running Ubuntu 14.04 LTS. Stock clang from standard repos. Niall -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups Protocol Buffers group. To unsubscribe from this group and stop receiving emails from it, send an email to protobuf+unsubscr...@googlegroups.com. To post to this group, send email to protobuf@googlegroups.com. Visit this group at http://groups.google.com/group/protobuf. For more options, visit https://groups.google.com/d/optout.
[protobuf] Re: Issue 607 in protobuf: Replace TSan API declarations in atomicops_internals_tsan.h with a header inclusion
Comment #3 on issue 607 by gli...@chromium.org: Replace TSan API declarations in atomicops_internals_tsan.h with a header inclusion http://code.google.com/p/protobuf/issues/detail?id=607 Ping? -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups Protocol Buffers group. To unsubscribe from this group and stop receiving emails from it, send an email to protobuf+unsubscr...@googlegroups.com. To post to this group, send email to protobuf@googlegroups.com. Visit this group at http://groups.google.com/group/protobuf. For more options, visit https://groups.google.com/d/optout.
[protobuf] Re: Issue 607 in protobuf: Replace TSan API declarations in atomicops_internals_tsan.h with a header inclusion
Updates: Status: Fixed Comment #4 on issue 607 by xiaof...@google.com: Replace TSan API declarations in atomicops_internals_tsan.h with a header inclusion http://code.google.com/p/protobuf/issues/detail?id=607 Committed as r521 -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups Protocol Buffers group. To unsubscribe from this group and stop receiving emails from it, send an email to protobuf+unsubscr...@googlegroups.com. To post to this group, send email to protobuf@googlegroups.com. Visit this group at http://groups.google.com/group/protobuf. For more options, visit https://groups.google.com/d/optout.
[protobuf] Re: Issue 607 in protobuf: Replace TSan API declarations in atomicops_internals_tsan.h with a header inclusion
Comment #1 on issue 607 by xiaof...@google.com: Replace TSan API declarations in atomicops_internals_tsan.h with a header inclusion http://code.google.com/p/protobuf/issues/detail?id=607 Where does this header file come from? Does it mean that users will need to install these header files before they can compile protobuf (while previously they don't need to)? -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups Protocol Buffers group. To unsubscribe from this group and stop receiving emails from it, send an email to protobuf+unsubscr...@googlegroups.com. To post to this group, send email to protobuf@googlegroups.com. Visit this group at http://groups.google.com/group/protobuf. For more options, visit https://groups.google.com/groups/opt_out.
