[protobuf] Re: g++4.4 fix

2009-10-30 Thread Kenton Varda
I've applied the patch anyway -- minus the disparaging comment -- since
there's no harm and other people have complained about this.  Rev 238.

On Fri, Oct 30, 2009 at 10:56 AM, Oleg Smolsky  wrote:

>  Oh, man you are right. It's a combination of -Werror and -Wextra.
>
> Well, this is certainly not a protobuf issue, as it is my code that uses
> -Wextra. The option brings many good checks, but one of them is completely
> retarded. Arg!...
>
> Thanks!
> Oleg.
>
>
> On 10/30/2009 10:32 AM, Kenton Varda wrote:
>
> Are you sure the problem isn't simply that you've enabled certain pedantic
> warnings?  I strongly doubt that GCC 4.4 actually requires explicit
> initialization of superclasses as this would break lots and lots of code.
>
> On Fri, Oct 30, 2009 at 10:13 AM, Oleg Smolsky  wrote:
>
>> Hey Kenton, I've attached a patch for protoc - it now emits code that is
>> accepted by g++4.4/x64. I know the addition looks retarded, but g++ versions
>> 4.4.1 and 4.4.2 just refuse to compile the generated source otherwise...
>>
>> Oleg.
>>
>
>
>

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Protocol Buffers" group.
To post to this group, send email to protobuf@googlegroups.com
To unsubscribe from this group, send email to 
protobuf+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/protobuf?hl=en
-~--~~~~--~~--~--~---



[protobuf] Re: g++4.4 fix

2009-10-30 Thread Kenton Varda
Are you sure the problem isn't simply that you've enabled certain pedantic
warnings?  I strongly doubt that GCC 4.4 actually requires explicit
initialization of superclasses as this would break lots and lots of code.

On Fri, Oct 30, 2009 at 10:13 AM, Oleg Smolsky  wrote:

> Hey Kenton, I've attached a patch for protoc - it now emits code that is
> accepted by g++4.4/x64. I know the addition looks retarded, but g++ versions
> 4.4.1 and 4.4.2 just refuse to compile the generated source otherwise...
>
> Oleg.
>

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Protocol Buffers" group.
To post to this group, send email to protobuf@googlegroups.com
To unsubscribe from this group, send email to 
protobuf+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/protobuf?hl=en
-~--~~~~--~~--~--~---