Re: [protobuf] 2.3.0 release candidate #2
Just noticed that the Builders from the generated java code doesn't protect against empty string (only does null protect). Same goes with ByteString. On Thu, Jan 7, 2010 at 2:44 PM, Kenton Varda ken...@google.com wrote: I've put up a second release candidate in the same place: https://groups.google.com/group/protobuf/files This one has a bunch of fixes for reported bugs, plus the new support for outputting directly to .zip and (source) .jar files. On Mon, Dec 21, 2009 at 3:00 PM, Kenton Varda ken...@google.com wrote: Hi all, I've uploaded a release candidate of protobuf-2.3.0 here: https://groups.google.com/group/protobuf/files I have tested on Linux (gcc 3.3.6 and 4.2.4), Cygwin, MinGW, MSVC, and OSX (Snow Leopard, latest Xcode). Monty, it would be great if you could test this out on Solaris. Since everything went smoothly, I have some extra time in which I'm going to try to get some new utility classes ported out from our internal repo. My guess is that the final release will have to wait until early January as many people are out of town right now (and I will be soon). -- You received this message because you are subscribed to the Google Groups Protocol Buffers group. To post to this group, send email to proto...@googlegroups.com. To unsubscribe from this group, send email to protobuf+unsubscr...@googlegroups.comprotobuf%2bunsubscr...@googlegroups.com . For more options, visit this group at http://groups.google.com/group/protobuf?hl=en. -- When the cat is away, the mouse is alone. - David Yu -- You received this message because you are subscribed to the Google Groups "Protocol Buffers" group. To post to this group, send email to proto...@googlegroups.com. To unsubscribe from this group, send email to protobuf+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/protobuf?hl=en.
Re: [protobuf] 2.3.0 release candidate #2
When writing to the CodedOutputStream, it will be written as 0 length delimited (0)bytes. The Builder's setFoo(String foo) fails to protect it. On Fri, Jan 8, 2010 at 7:50 AM, Kenton Varda ken...@google.com wrote: On Thu, Jan 7, 2010 at 3:34 PM, David Yu david.yu@gmail.com wrote: Just noticed that the Builders from the generated java code doesn't protect against empty string (only does null protect). Same goes with ByteString. What do you mean? Empty strings are perfectly valid field values. On Thu, Jan 7, 2010 at 2:44 PM, Kenton Varda ken...@google.com wrote: I've put up a second release candidate in the same place: https://groups.google.com/group/protobuf/files This one has a bunch of fixes for reported bugs, plus the new support for outputting directly to .zip and (source) .jar files. On Mon, Dec 21, 2009 at 3:00 PM, Kenton Varda ken...@google.com wrote: Hi all, I've uploaded a release candidate of protobuf-2.3.0 here: https://groups.google.com/group/protobuf/files I have tested on Linux (gcc 3.3.6 and 4.2.4), Cygwin, MinGW, MSVC, and OSX (Snow Leopard, latest Xcode). Monty, it would be great if you could test this out on Solaris. Since everything went smoothly, I have some extra time in which I'm going to try to get some new utility classes ported out from our internal repo. My guess is that the final release will have to wait until early January as many people are out of town right now (and I will be soon). -- You received this message because you are subscribed to the Google Groups Protocol Buffers group. To post to this group, send email to proto...@googlegroups.com. To unsubscribe from this group, send email to protobuf+unsubscr...@googlegroups.comprotobuf%2bunsubscr...@googlegroups.com . For more options, visit this group at http://groups.google.com/group/protobuf?hl=en. -- When the cat is away, the mouse is alone. - David Yu -- When the cat is away, the mouse is alone. - David Yu -- You received this message because you are subscribed to the Google Groups "Protocol Buffers" group. To post to this group, send email to proto...@googlegroups.com. To unsubscribe from this group, send email to protobuf+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/protobuf?hl=en.
Re: [protobuf] 2.3.0 release candidate #2
On Thu, Jan 7, 2010 at 3:53 PM, David Yu david.yu@gmail.com wrote: When writing to the CodedOutputStream, it will be written as 0 length delimited (0)bytes. That is correct. The Builder's setFoo(String foo) fails to protect it. What is it supposed to protect? On Fri, Jan 8, 2010 at 7:50 AM, Kenton Varda ken...@google.com wrote: On Thu, Jan 7, 2010 at 3:34 PM, David Yu david.yu@gmail.com wrote: Just noticed that the Builders from the generated java code doesn't protect against empty string (only does null protect). Same goes with ByteString. What do you mean? Empty strings are perfectly valid field values. On Thu, Jan 7, 2010 at 2:44 PM, Kenton Varda ken...@google.com wrote: I've put up a second release candidate in the same place: https://groups.google.com/group/protobuf/files This one has a bunch of fixes for reported bugs, plus the new support for outputting directly to .zip and (source) .jar files. On Mon, Dec 21, 2009 at 3:00 PM, Kenton Varda ken...@google.comwrote: Hi all, I've uploaded a release candidate of protobuf-2.3.0 here: https://groups.google.com/group/protobuf/files I have tested on Linux (gcc 3.3.6 and 4.2.4), Cygwin, MinGW, MSVC, and OSX (Snow Leopard, latest Xcode). Monty, it would be great if you could test this out on Solaris. Since everything went smoothly, I have some extra time in which I'm going to try to get some new utility classes ported out from our internal repo. My guess is that the final release will have to wait until early January as many people are out of town right now (and I will be soon). -- You received this message because you are subscribed to the Google Groups Protocol Buffers group. To post to this group, send email to proto...@googlegroups.com. To unsubscribe from this group, send email to protobuf+unsubscr...@googlegroups.comprotobuf%2bunsubscr...@googlegroups.com . For more options, visit this group at http://groups.google.com/group/protobuf?hl=en. -- When the cat is away, the mouse is alone. - David Yu -- When the cat is away, the mouse is alone. - David Yu -- You received this message because you are subscribed to the Google Groups "Protocol Buffers" group. To post to this group, send email to proto...@googlegroups.com. To unsubscribe from this group, send email to protobuf+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/protobuf?hl=en.
Re: [protobuf] 2.3.0 release candidate #2
Oh ok, didn't think it was normal to write delimited data with 0 length and no data. But I guess that is how the empty string is passed around. Thanks. On Fri, Jan 8, 2010 at 8:00 AM, Kenton Varda ken...@google.com wrote: On Thu, Jan 7, 2010 at 3:53 PM, David Yu david.yu@gmail.com wrote: When writing to the CodedOutputStream, it will be written as 0 length delimited (0)bytes. That is correct. The Builder's setFoo(String foo) fails to protect it. What is it supposed to protect? On Fri, Jan 8, 2010 at 7:50 AM, Kenton Varda ken...@google.com wrote: On Thu, Jan 7, 2010 at 3:34 PM, David Yu david.yu@gmail.com wrote: Just noticed that the Builders from the generated java code doesn't protect against empty string (only does null protect). Same goes with ByteString. What do you mean? Empty strings are perfectly valid field values. On Thu, Jan 7, 2010 at 2:44 PM, Kenton Varda ken...@google.com wrote: I've put up a second release candidate in the same place: https://groups.google.com/group/protobuf/files This one has a bunch of fixes for reported bugs, plus the new support for outputting directly to .zip and (source) .jar files. On Mon, Dec 21, 2009 at 3:00 PM, Kenton Varda ken...@google.comwrote: Hi all, I've uploaded a release candidate of protobuf-2.3.0 here: https://groups.google.com/group/protobuf/files I have tested on Linux (gcc 3.3.6 and 4.2.4), Cygwin, MinGW, MSVC, and OSX (Snow Leopard, latest Xcode). Monty, it would be great if you could test this out on Solaris. Since everything went smoothly, I have some extra time in which I'm going to try to get some new utility classes ported out from our internal repo. My guess is that the final release will have to wait until early January as many people are out of town right now (and I will be soon). -- You received this message because you are subscribed to the Google Groups Protocol Buffers group. To post to this group, send email to proto...@googlegroups.com. To unsubscribe from this group, send email to protobuf+unsubscr...@googlegroups.comprotobuf%2bunsubscr...@googlegroups.com . For more options, visit this group at http://groups.google.com/group/protobuf?hl=en. -- When the cat is away, the mouse is alone. - David Yu -- When the cat is away, the mouse is alone. - David Yu -- When the cat is away, the mouse is alone. - David Yu -- You received this message because you are subscribed to the Google Groups "Protocol Buffers" group. To post to this group, send email to proto...@googlegroups.com. To unsubscribe from this group, send email to protobuf+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/protobuf?hl=en.
