Re: optimize_for option default

2009-04-24 Thread danila.ermakov
+1 for SPEED. --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Protocol Buffers group. To post to this group, send email to protobuf@googlegroups.com To unsubscribe from this group, send email to

Re: optimize_for option default

2009-03-06 Thread Jon Skeet sk...@pobox.com
On Mar 5, 11:39 pm, Kenton Varda ken...@google.com wrote: As you know if you've read the docs carefully, when using C++ or Java protocol buffers, for best performance you need to add a line to your .proto files:   option optimize_for = SPEED; snip commentary I think there are three issues

Re: optimize_for option default

2009-03-06 Thread aepensky
+1 for making it a compiler command-line option. Pretty much all other IDLs get this wrong to some degree also. Having annotations or options in the IDL file is nice, but make sure they are only helping to define the message and the service, not the implementation. When I get a service

Re: optimize_for option default

2009-03-06 Thread aepensky
+1 for making it a compiler command-line option. Pretty much all other IDLs get this wrong to some degree also. Having annotations or options in the IDL file is nice, but make sure they are only helping to define the message and the service, not the implementation. When I get a service

Re: optimize_for option default

2009-03-06 Thread Jon Skeet sk...@pobox.com
On Mar 6, 2:23 pm, aepensky apen...@gmail.com wrote: +1 for making it a compiler command-line option. Pretty much all other IDLs get this wrong to some degree also. Having annotations or options in the IDL file is nice, but make sure they are only helping to define the message and the

Re: optimize_for option default

2009-03-06 Thread aepensky
Sorry, I realize that wasn't a very clear statement... What I mean is, if there is an option which does not leave any fingerprint in either the serialized message or the FileDescriptorSet, so that you can't tell how the option was set by looking at either of these, then the option is controlling

Re: optimize_for option default

2009-03-06 Thread Jon Skeet sk...@pobox.com
On Mar 6, 4:55 pm, aepensky apen...@gmail.com wrote: Sorry, I realize that wasn't a very clear statement... What I mean is, if there is an option which does not leave any fingerprint in either the serialized message or the FileDescriptorSet, so that you can't tell how the option was set by

Re: optimize_for option default

2009-03-06 Thread Kenton Varda
I agree that there should be a way to specify options on the command-line. This applies to pretty much *all* options -- optimize_for, java_Package, ctype, etc. It would even be useful to be able to munge package and class names on the command-line, so that you can generate the same .proto file

Re: optimize_for option default

2009-03-05 Thread Dave Bailey
+1 for SPEED. -dave On Mar 5, 3:39 pm, Kenton Varda ken...@google.com wrote: Hi all, As you know if you've read the docs carefully, when using C++ or Java protocol buffers, for best performance you need to add a line to your .proto files:   option optimize_for = SPEED; Otherwise, by