Re: warnings compiling generated code on Snow Leopard

2009-09-25 Thread mo
So is there a decision for this issue? Will it be a flag for protoc or a patch (I think I saw somewhere a post mentioning that the patch was not going to be used because of other issues)? And any possible ETA for the solution? On Aug 31, 5:33 pm, Kenton Varda ken...@google.com wrote: I'm OK

Re: warnings compiling generated code on Snow Leopard

2009-09-25 Thread Henner Zeller
On Fri, Sep 25, 2009 at 12:25, mo mohammad.kolahdou...@gmail.com wrote: So is there a decision for this issue? Will it be a flag for protoc or a patch (I think I saw somewhere a post mentioning that the patch was not going to be used because of other issues)? And any possible ETA for the

Re: warnings compiling generated code on Snow Leopard

2009-08-31 Thread Kenton Varda
What compiler flags are you using? Since you were able to compile libprotobuf itself, I assume you have turned on additional warnings for your own project? On Mon, Aug 31, 2009 at 3:26 PM, Joshua Haberman jhaber...@gmail.comwrote: I just installed Snow Leopard, which ships with: $ gcc

Re: warnings compiling generated code on Snow Leopard

2009-08-31 Thread Joshua Haberman
Good point, this was with -Wextra (which I had forgotten I compile with). I can understand if you're not interested in accommodating this. It is strange that -Wextra warns about this for this particular gcc version, but not others that I've tried. On Aug 31, 4:49 pm, Kenton Varda

Re: warnings compiling generated code on Snow Leopard

2009-08-31 Thread Joshua Haberman
On Aug 31, 5:17 pm, Michael Poole mdpo...@troilus.org wrote: Joshua  Haberman writes: The protobuf library compiled and installed fine, but the generated classes threw warnings (and since I was compiling with -Werror, failed to compile).  The warning was: