Re: Swap() and RemoveLast() should be added to Reflection API
Are you interested in a patch from me to add them or would you just add it yourselves at some point? On Mar 9, 2:53 pm, Kenton Varda ken...@google.com wrote: It wasn't added because the reflection interface is already huge, and there are a lot of different things that people could potentially want from it. That said, I'd be OK with adding these. Fortunately they don't need separate versions for every field type. On Mon, Mar 9, 2009 at 5:50 AM, Scott Stafford scott.staff...@gmail.comwrote: Hi - I noticed that the functionality for Swap() and RemoveLast() was not available to reflection. I needed them and tried to add them in a branch, and it seemed trivial enough (especially RemoveLast). Is there anything that I missed? Is there a reason that this is more complex than I can see or was it simply not added yet? Thanks, Scott --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Protocol Buffers group. To post to this group, send email to protobuf@googlegroups.com To unsubscribe from this group, send email to protobuf+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/protobuf?hl=en -~--~~~~--~~--~--~---
Re: Swap() and RemoveLast() should be added to Reflection API
I'd love a patch! As a reminder, you'll have to sign the contributor license agreement: http://code.google.com/legal/individual-cla-v1.0.html http://code.google.com/legal/corporate-cla-v1.0.html (Individual if you own the copyright on your work, corporate if your employer does.) Thanks. On Tue, Mar 10, 2009 at 3:35 PM, Scott Stafford scott.staff...@gmail.comwrote: Are you interested in a patch from me to add them or would you just add it yourselves at some point? On Mar 9, 2:53 pm, Kenton Varda ken...@google.com wrote: It wasn't added because the reflection interface is already huge, and there are a lot of different things that people could potentially want from it. That said, I'd be OK with adding these. Fortunately they don't need separate versions for every field type. On Mon, Mar 9, 2009 at 5:50 AM, Scott Stafford scott.staff...@gmail.com wrote: Hi - I noticed that the functionality for Swap() and RemoveLast() was not available to reflection. I needed them and tried to add them in a branch, and it seemed trivial enough (especially RemoveLast). Is there anything that I missed? Is there a reason that this is more complex than I can see or was it simply not added yet? Thanks, Scott --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Protocol Buffers group. To post to this group, send email to protobuf@googlegroups.com To unsubscribe from this group, send email to protobuf+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/protobuf?hl=en -~--~~~~--~~--~--~---
Swap() and RemoveLast() should be added to Reflection API
Hi - I noticed that the functionality for Swap() and RemoveLast() was not available to reflection. I needed them and tried to add them in a branch, and it seemed trivial enough (especially RemoveLast). Is there anything that I missed? Is there a reason that this is more complex than I can see or was it simply not added yet? Thanks, Scott --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Protocol Buffers group. To post to this group, send email to protobuf@googlegroups.com To unsubscribe from this group, send email to protobuf+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/protobuf?hl=en -~--~~~~--~~--~--~---
