[GitHub] qpid-proton pull request: Fix 2 Code Analysis warnings and a reall...

2015-07-07 Thread dcristoloveanu
Github user dcristoloveanu closed the pull request at: https://github.com/apache/qpid-proton/pull/39 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] qpid-proton pull request: Fix 2 Code Analysis warnings and a reall...

2015-07-07 Thread astitcher
Github user astitcher commented on the pull request: https://github.com/apache/qpid-proton/pull/39#issuecomment-119227983 @dcristoloveanu - Sorry not to reply to your comments - for some reason I got no email to tell me you had commented. * If you change the PR I'll be happy

[GitHub] qpid-proton pull request: Fix 2 Code Analysis warnings and a reall...

2015-07-06 Thread ted-ross
Github user ted-ross commented on the pull request: https://github.com/apache/qpid-proton/pull/39#issuecomment-118902728 I'd like to see this pull request move forward. On Dan's points above: 1) I agree with Andrew that using __LINE__ as an error code should be changed to

[GitHub] qpid-proton pull request: Fix 2 Code Analysis warnings and a reall...

2015-06-24 Thread dcristoloveanu
Github user dcristoloveanu commented on the pull request: https://github.com/apache/qpid-proton/pull/39#issuecomment-114940533 Ping ... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this